From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Alexey Starikovskiy <astarikovskiy@suse.de>
Cc: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] battery: Fix charge_now returned by broken batteries
Date: Sun, 4 Oct 2009 22:46:23 +0200 [thread overview]
Message-ID: <200910042246.23712.rjw@sisk.pl> (raw)
In-Reply-To: <4AC8F02B.6080209@suse.de>
On Sunday 04 October 2009, Alexey Starikovskiy wrote:
> Hi Miguel,
Hi Alex,
> I am going to reject your patch on the basis, that the battery driver should report only
> information it gained from battery hardware, not interpret it in any way.
> As your patch fall into "interpret" category, it does not belong in the kernel and battery
> driver in particular. You may suggest it to any/all user space battery monitoring applications,
> this is the place for "interpretations".
Well, we do quirks for PCI devices, suspend quirks etc. in the kernel, so I'm
not really sure we should use the "no interpretation" as a general rule. IMO,
if there's a known broken system needing a quirk, it may just be more
reasonable to put the quirk into the kernel than to put it into every single
user application out there.
In this particular case we have an evidently quirky hardware (or BIOS) and it's
not a fundamentally wrong idea to try to address that problem in the kernel.
Thanks,
Rafael
next prev parent reply other threads:[~2009-10-04 20:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1254669853.26496.0.camel@carter>
2009-10-04 16:45 ` [PATCH] battery: Fix charge_now returned by broken batteries Henrique de Moraes Holschuh
2009-10-04 17:46 ` Miguel Ojeda
2009-10-04 18:57 ` Alexey Starikovskiy
2009-10-04 20:46 ` Rafael J. Wysocki [this message]
2009-10-04 21:36 ` Alexey Starikovskiy
2009-10-04 21:55 ` Miguel Ojeda
2009-10-04 22:38 ` Alexey Starikovskiy
2009-10-04 23:53 ` Miguel Ojeda
2009-10-05 0:18 ` Alexey Starikovskiy
2009-10-06 17:05 ` Miguel Ojeda
2009-10-10 12:04 ` Pavel Machek
2009-10-10 20:53 ` Miguel Ojeda
2009-10-10 21:25 ` Pavel Machek
2009-10-10 21:44 ` Miguel Ojeda
2009-10-10 22:49 ` Pavel Machek
2009-10-10 21:52 ` Henrique de Moraes Holschuh
2009-10-04 22:43 ` Rafael J. Wysocki
2009-10-04 22:56 ` Alexey Starikovskiy
2009-10-04 23:58 ` Miguel Ojeda
2009-10-04 21:42 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200910042246.23712.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=astarikovskiy@suse.de \
--cc=hmh@hmh.eng.br \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox