From: Pavel Machek <pavel@ucw.cz>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: Alexey Starikovskiy <astarikovskiy@suse.de>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] battery: Fix charge_now returned by broken batteries
Date: Sat, 10 Oct 2009 23:25:21 +0200 [thread overview]
Message-ID: <20091010212521.GD14051@elf.ucw.cz> (raw)
In-Reply-To: <ca2dc2820910101353g65e4591ds82bf9fff8378abd4@mail.gmail.com>
Hi!
> >> In "broken" batteries (is it broken finally? or is it expected
> >> behaviour?) like mine the old problem will be corrected, as it was
> >> only present in the charged state.
> >
> > I believe you better work around this in userspace... or agree that
> >>100% charge is possible.
>
> I agree that >100% charge is possible while charging (because that
> would mean the battery is over the last charged level); however, what
> does it mean when charged?
Well, maybe the battery only updates full_charge_capacity during
powerdown or when the moon is full or something? (IOW you may be
breaking already working machines).
> In any case, my laptop's battery is not charging over 100% its
> original capacity anyway, just reporting a wrong value.
True. But I do not think you are fixing it properly. Maybe ask for
fixed BIOS?
Or perhaps add quirk based on DMI or something?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2009-10-10 21:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1254669853.26496.0.camel@carter>
2009-10-04 16:45 ` [PATCH] battery: Fix charge_now returned by broken batteries Henrique de Moraes Holschuh
2009-10-04 17:46 ` Miguel Ojeda
2009-10-04 18:57 ` Alexey Starikovskiy
2009-10-04 20:46 ` Rafael J. Wysocki
2009-10-04 21:36 ` Alexey Starikovskiy
2009-10-04 21:55 ` Miguel Ojeda
2009-10-04 22:38 ` Alexey Starikovskiy
2009-10-04 23:53 ` Miguel Ojeda
2009-10-05 0:18 ` Alexey Starikovskiy
2009-10-06 17:05 ` Miguel Ojeda
2009-10-10 12:04 ` Pavel Machek
2009-10-10 20:53 ` Miguel Ojeda
2009-10-10 21:25 ` Pavel Machek [this message]
2009-10-10 21:44 ` Miguel Ojeda
2009-10-10 22:49 ` Pavel Machek
2009-10-10 21:52 ` Henrique de Moraes Holschuh
2009-10-04 22:43 ` Rafael J. Wysocki
2009-10-04 22:56 ` Alexey Starikovskiy
2009-10-04 23:58 ` Miguel Ojeda
2009-10-04 21:42 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091010212521.GD14051@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=astarikovskiy@suse.de \
--cc=hmh@hmh.eng.br \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox