Re: [lm-sensors] Core i3 support?

Re: [lm-sensors] Core i3 support?

[Darrick J. Wong]

On Thu, Feb 11, 2010 at 06:42:28PM +0200, D. Can Celasun wrote:
> On 11 February 2010 10:17, Jean Delvare <khali@linux-fr.org> wrote:
> 
> > > On 11 February 2010 03:21, Darrick J. Wong <djwong@us.ibm.com> wrote:
> > > > Does sensors-detect/i2cdetect find anything on either i2c controller?
> >
> > On Thu, 11 Feb 2010 09:33:06 +0200, D. Can Celasun wrote:
> > > Relevant sensors-detect output:
> > >
> > > Do you want to probe the I2C/SMBus adapters now? (YES/no):
> > > Found unknown SMBus adapter 8086:3b30 at 0000:00:1f.3.
> > > Sorry, no supported PCI bus adapters found.
> > > Module i2c-dev loaded successfully.
> >
> > At that time, the i2c-i801 driver was loaded but not the i2c-scmi
> > driver. The i2c-i801 driver is hopeless (can't bind to the device). You
> > could try loading the i2c-scmi driver manually and running
> > sensors-detect again.
> >
> > Tried that, doesn't make any difference.
> 
> 
> > Darrick, any chance we could get the i2c-scmi driver to load
> > automatically on systems which need it?

I think all we need to do is add:

MODULE_DEVICE_TABLE(acpi, fan_device_ids);

to i2c-scmi.c, which will add the appropriate aliases to the module info.

That reminds me, I don't think that patch to add ACPI_SMBUS_IBM_HID to the ACPI
header files ever went in, did it?  It doesn't seem to be in 2.6.33-rc7, but
maybe it's queued in someone else's ACPI tree for .34?  If it's not, then I'd
imagine it's still blocking the patchset to i2c-scmi that works around broken
IBM BIOSes, so I'm hoping someone from the ACPI part of the world can comment?

--D

Re: [lm-sensors] Core i3 support?

[Jean Delvare]

On Fri, 12 Feb 2010 10:52:41 -0800, Darrick J. Wong wrote:
> On Thu, Feb 11, 2010 at 06:42:28PM +0200, D. Can Celasun wrote:
> > On 11 February 2010 10:17, Jean Delvare <khali@linux-fr.org> wrote:
> > > Darrick, any chance we could get the i2c-scmi driver to load
> > > automatically on systems which need it?
> 
> I think all we need to do is add:
> 
> MODULE_DEVICE_TABLE(acpi, fan_device_ids);

I guess you mean:

MODULE_DEVICE_TABLE(acpi, acpi_smbus_cmi_ids);

> 
> to i2c-scmi.c, which will add the appropriate aliases to the module info.

OK. Care to send a patch?

> That reminds me, I don't think that patch to add ACPI_SMBUS_IBM_HID to the ACPI
> header files ever went in, did it?  It doesn't seem to be in 2.6.33-rc7, but
> maybe it's queued in someone else's ACPI tree for .34?

I have pinged Bjorn and Len twice already (December 17th, January 5th)
but never heard back.

> If it's not, then I'd
> imagine it's still blocking the patchset to i2c-scmi that works around broken
> IBM BIOSes, so I'm hoping someone from the ACPI part of the world can comment?

Yes it is blocking the i2c-scmi patch. And yes, please ACPI people take
care of it ASAP.

-- 
Jean Delvare

[PATCH] i2c-scmi: Provide module aliases for automatic loading

[Darrick J. Wong]

Ok, here's a quick patch to provide the module aliases.  Lightly tested, and
requires the patch that defines ACPI_SMBUS_IBM_HID.
---
i2c-scmi: Provide module aliases for automatic loading

Signed-off-by: Darrick J. Wong <djwong@us.ibm.com>
---

 drivers/i2c/busses/i2c-scmi.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)


diff --git a/drivers/i2c/busses/i2c-scmi.c b/drivers/i2c/busses/i2c-scmi.c
index 4c9fb4c..388cbdc 100644
--- a/drivers/i2c/busses/i2c-scmi.c
+++ b/drivers/i2c/busses/i2c-scmi.c
@@ -54,6 +54,7 @@ static const struct acpi_device_id acpi_smbus_cmi_ids[] = {
 	{ACPI_SMBUS_IBM_HID, (kernel_ulong_t)&ibm_smbus_methods},
 	{"", 0}
 };
+MODULE_DEVICE_TABLE(acpi, acpi_smbus_cmi_ids);
 
 #define ACPI_SMBUS_STATUS_OK			0x00
 #define ACPI_SMBUS_STATUS_FAIL			0x07

Re: [PATCH] i2c-scmi: Provide module aliases for automatic loading

[Jean Delvare]

On Fri, 12 Feb 2010 13:51:21 -0800, Darrick J. Wong wrote:
> Ok, here's a quick patch to provide the module aliases.  Lightly tested, and
> requires the patch that defines ACPI_SMBUS_IBM_HID.
> ---
> i2c-scmi: Provide module aliases for automatic loading
> 
> Signed-off-by: Darrick J. Wong <djwong@us.ibm.com>
> ---
> 
>  drivers/i2c/busses/i2c-scmi.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> 
> diff --git a/drivers/i2c/busses/i2c-scmi.c b/drivers/i2c/busses/i2c-scmi.c
> index 4c9fb4c..388cbdc 100644
> --- a/drivers/i2c/busses/i2c-scmi.c
> +++ b/drivers/i2c/busses/i2c-scmi.c
> @@ -54,6 +54,7 @@ static const struct acpi_device_id acpi_smbus_cmi_ids[] = {
>  	{ACPI_SMBUS_IBM_HID, (kernel_ulong_t)&ibm_smbus_methods},
>  	{"", 0}
>  };
> +MODULE_DEVICE_TABLE(acpi, acpi_smbus_cmi_ids);
>  
>  #define ACPI_SMBUS_STATUS_OK			0x00
>  #define ACPI_SMBUS_STATUS_FAIL			0x07

Applied, thanks.

-- 
Jean Delvare

Re: Core i3 support?

[D. Can Celasun]

[-- Attachment #1.1: Type: text/plain, Size: 18 bytes --]

Any news on this?

[-- Attachment #1.2: Type: text/html, Size: 22 bytes --]

[-- Attachment #2: Type: text/plain, Size: 153 bytes --]

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors