Re: [PATCH] hwmon: (asus_atk0110) Don't load if ACPI resources aren't enforced

[Jean Delvare <khali@linux-fr.org>]

On Tue, 30 Mar 2010 20:48:36 +0100, Matthew Garrett wrote:
> On Tue, Mar 30, 2010 at 09:47:32PM +0200, Jean Delvare wrote:
> 
> > The asus_atk0110 driver loads automatically. The user doesn't configure
> > anything, and it just loads. That's the problem. If the driver didn't
> > load automatically, I wouldn't care. If you know of any way to prevent
> > the asus_atk0110 driver from auto-loading as soon as
> > acpi_enforce_resouce=lax or =no is passed, I am fine with this as well.
> > This is what I wanted to do originally, but I couldn't find a way to do
> > it, which is why I went for the more radical option of preventing the
> > asus_atk0110 driver from loading.
> 
> echo blacklist asus_atk0110 >/etc/modprobe.d/hwmon_blacklist.conf

Sure, but why do you insist on having the user configure this manually
when we can automate this at the kernel level? When
acpi_enforce_resouce=yes, the kernel doesn't let non-ACPI driver be
loaded, so I fail to see why we let ACPI drivers (for which we also
have native drivers) load when acpi_enforce_resouce=no.

Or is there something really wrong with my patch?

-- 
Jean Delvare