Re: [lm-sensors] [PATCH] hwmon: (asus_atk0110) Don't load if ACPI resources aren't enforced

[Jean Delvare <khali@linux-fr.org>]

On Tue, 30 Mar 2010 22:53:05 +0100, Matthew Garrett wrote:
> On Tue, Mar 30, 2010 at 11:45:46PM +0200, Luca Tettamanti wrote:
> > On Tue, Mar 30, 2010 at 11:10 PM, Matthew Garrett <mjg59@srcf.ucam.org> wrote:
> > > Because the situation with the asus driver loaded isn't obviously any
> > > worse than not having it loaded. The user is telling us that they're
> > > happy with racy access to their hwmon hardware.
> > 
> > "lax" option is typically used when the user wants to load the native
> > driver; in this case we know that it's not safe to load asus driver.
> 
> It's not safe to load the native driver, full stop. Not loading the asus 
> driver doesn't alter that.

It definitely does. At least on some of the affected boards, no access
to the I/O area in question is done at all as long as the asus_atk0110
driver is not loaded. So it is actually safe to pass
acpi_enforce_resources=lax and not load the asus_atk0110 driver. And
people are actually doing this because native drivers can control the
speed of their fans while the asus_atk0110 driver can't. So they see
the current situation as a regression.

Again, can you please point to problems my patch has?

-- 
Jean Delvare