From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: "linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
Wim Van Sebroeck <wim@iguana.be>,
Guenter Roeck <linux@roeck-us.net>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH] watchdog: wdat_wdt: Ping the watchdog on resume
Date: Fri, 21 Oct 2016 15:52:12 +0300 [thread overview]
Message-ID: <20161021125212.GW24289@lahna.fi.intel.com> (raw)
In-Reply-To: <CAJZ5v0g8dx=Mivf8=4kUdW9JHh9hru5dob73UOFMQeLb6zaSiQ@mail.gmail.com>
On Thu, Oct 20, 2016 at 05:48:32PM +0200, Rafael J. Wysocki wrote:
> On Thu, Oct 20, 2016 at 5:17 PM, Mika Westerberg
> <mika.westerberg@linux.intel.com> wrote:
> > On Thu, Oct 20, 2016 at 05:05:22PM +0200, Rafael J. Wysocki wrote:
> >> On Thu, Oct 20, 2016 at 5:03 PM, Mika Westerberg
> >> <mika.westerberg@linux.intel.com> wrote:
> >> > It turns out we need to ping the watchdog hardware on resume when we
> >> > re-program it. Otherwise this results inadvertent reset to trigger right
> >> > after the resume is completed.
> >> >
> >> > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> >>
> >> Is there a Fixes: tag missing here?
> >
> > Oops, right. Sorry about that.
> >
> > It should be:
> >
> > Fixes: 058dfc767008 ("ACPI / watchdog: Add support for WDAT hardware watchdog")
> >
> > (I can resend the patch as well, if needed with the Fixes tag).
>
> No worries, I can pick this up from here.
Thanks :-)
next prev parent reply other threads:[~2016-10-21 12:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-20 15:03 [PATCH] watchdog: wdat_wdt: Ping the watchdog on resume Mika Westerberg
2016-10-20 15:05 ` Rafael J. Wysocki
[not found] ` <CAJZ5v0ipdO2psmdesoQuw_5uuOSqDh22DK04bEJTi1pW0fL53g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-10-20 15:17 ` Mika Westerberg
2016-10-20 15:48 ` Rafael J. Wysocki
2016-10-21 12:52 ` Mika Westerberg [this message]
2016-10-20 22:19 ` Guenter Roeck
2016-10-20 22:47 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161021125212.GW24289@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox