From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Kai Heng Feng <kai.heng.feng@canonical.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
P HeLiOn <perryhelionsemail@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>
Subject: Re: [PATCH] ACPI / LPSS: Avoid PM quirks on suspend and resume from S3
Date: Wed, 13 Jun 2018 15:58:27 +0300 [thread overview]
Message-ID: <20180613125827.GZ2384@lahna.fi.intel.com> (raw)
In-Reply-To: <6a387b8b67497fa4a656c252a010d6d4e72e7774.camel@linux.intel.com>
On Wed, Jun 13, 2018 at 03:53:07PM +0300, Andy Shevchenko wrote:
> On Wed, 2018-06-13 at 13:17 +0200, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> >
> > It is reported that commit a192aa923b66a (ACPI / LPSS: Consolidate
> > runtime PM and system sleep handling) introduced a system suspend
> > regression on some machines, but the only functional change made by
> > it was to cause the PM quirks in the LPSS to also be used during
> > system suspend and resume. While that should always work for
> > suspend-to-idle, it turns out to be problematic for S3
> > (suspend-to-RAM).
> >
> > To address that issue restore the previous S3 suspend and resume
> > behavior of the LPSS to avoid applying PM quirks then.
> >
>
> LGTM,
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Also,
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
next prev parent reply other threads:[~2018-06-13 12:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-11 6:26 Possible regression caused by commit a192aa923b66a Kai-Heng Feng
2018-06-11 8:09 ` Rafael J. Wysocki
2018-06-11 21:52 ` Rafael J. Wysocki
2018-06-12 9:17 ` Rafael J. Wysocki
2018-06-13 2:45 ` Kai Heng Feng
2018-06-13 7:53 ` Rafael J. Wysocki
2018-06-13 11:17 ` [PATCH] ACPI / LPSS: Avoid PM quirks on suspend and resume from S3 Rafael J. Wysocki
2018-06-13 11:54 ` Ulf Hansson
2018-06-13 12:53 ` Andy Shevchenko
2018-06-13 12:58 ` Mika Westerberg [this message]
2018-07-24 8:46 ` Kai Heng Feng
2018-07-24 9:13 ` Rafael J. Wysocki
2018-07-24 10:36 ` Rafael J. Wysocki
2018-07-26 3:46 ` Kai-Heng Feng
2018-07-26 8:14 ` Rafael J. Wysocki
2018-07-26 8:15 ` Kai-Heng Feng
2018-07-26 8:50 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180613125827.GZ2384@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=kai.heng.feng@canonical.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=perryhelionsemail@gmail.com \
--cc=rjw@rjwysocki.net \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox