public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Alexey Dobriyan <adobriyan@gmail.com>
To: rjw@rjwysocki.net, lenb@kernel.org
Cc: linux-acpi@vger.kernel.org
Subject: evaluation order bug in acpi_pic_sci_set_trigger() ?
Date: Wed, 25 Nov 2020 22:59:06 +0300	[thread overview]
Message-ID: <20201125195906.GA3809000@localhost.localdomain> (raw)

acpi_pic_sci_set_trigger() contains the following code:

	/* Real old ELCR mask */
	old = inb(0x4d0) | (inb(0x4d1) << 8);

Operand evalution order is not guaranteed for binary or.
I wonder if this is a bug?

	Alexey

             reply	other threads:[~2020-11-25 19:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-25 19:59 Alexey Dobriyan [this message]
2020-11-26 14:32 ` evaluation order bug in acpi_pic_sci_set_trigger() ? Rafael J. Wysocki
2020-11-27 10:01   ` Alexey Dobriyan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201125195906.GA3809000@localhost.localdomain \
    --to=adobriyan@gmail.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox