From: Alexey Dobriyan <adobriyan@gmail.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>
Subject: Re: evaluation order bug in acpi_pic_sci_set_trigger() ?
Date: Fri, 27 Nov 2020 13:01:02 +0300 [thread overview]
Message-ID: <20201127100102.GA132507@localhost.localdomain> (raw)
In-Reply-To: <CAJZ5v0iUg2DD+o3AVfLqxAqX4vAnTC1o1kK=-nTcnkk2c36DPA@mail.gmail.com>
On Thu, Nov 26, 2020 at 03:32:37PM +0100, Rafael J. Wysocki wrote:
> On Wed, Nov 25, 2020 at 8:59 PM Alexey Dobriyan <adobriyan@gmail.com> wrote:
> >
> > acpi_pic_sci_set_trigger() contains the following code:
> >
> > /* Real old ELCR mask */
> > old = inb(0x4d0) | (inb(0x4d1) << 8);
> >
> > Operand evalution order is not guaranteed for binary or.
> > I wonder if this is a bug?
>
> Does the ordering matter in practice?
I have no idea, this is why I'm asking. :-)
prev parent reply other threads:[~2020-11-27 10:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-25 19:59 evaluation order bug in acpi_pic_sci_set_trigger() ? Alexey Dobriyan
2020-11-26 14:32 ` Rafael J. Wysocki
2020-11-27 10:01 ` Alexey Dobriyan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201127100102.GA132507@localhost.localdomain \
--to=adobriyan@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox