* [PATCH v4 2/7] drivers: acpi: acpi_apd: Remove unused device property "is-rv"
[not found] <20211125110447.1188073-1-AjitKumar.Pandey@amd.com>
@ 2021-11-25 11:04 ` Ajit Kumar Pandey
2021-11-25 11:04 ` [PATCH v4 3/7] ACPI: APD: Add a fmw property clk-name Ajit Kumar Pandey
1 sibling, 0 replies; 2+ messages in thread
From: Ajit Kumar Pandey @ 2021-11-25 11:04 UTC (permalink / raw)
To: sboyd, rafael, linux-clk
Cc: Vijendar.Mukunda, Alexander.Deucher, Basavaraj.Hiregoudar,
Sunil-kumar.Dommati, Mario.Limonciello, Ajit Kumar Pandey,
Len Brown, open list:ACPI, open list
Initially "is-rv" device property is added for 48MHz fixed clock
support on Raven or RV architecture. It's unused now as we moved
to pci device_id based selection to extend such support on other
architectures. This change removed unused code from acpi driver.
Signed-off-by: Ajit Kumar Pandey <AjitKumar.Pandey@amd.com>
---
drivers/acpi/acpi_apd.c | 3 ---
include/linux/platform_data/clk-fch.h | 1 -
2 files changed, 4 deletions(-)
diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c
index 6e02448d15d9..6913e9712852 100644
--- a/drivers/acpi/acpi_apd.c
+++ b/drivers/acpi/acpi_apd.c
@@ -87,9 +87,6 @@ static int fch_misc_setup(struct apd_private_data *pdata)
if (ret < 0)
return -ENOENT;
- if (!acpi_dev_get_property(adev, "is-rv", ACPI_TYPE_INTEGER, &obj))
- clk_data->is_rv = obj->integer.value;
-
list_for_each_entry(rentry, &resource_list, node) {
clk_data->base = devm_ioremap(&adev->dev, rentry->res->start,
resource_size(rentry->res));
diff --git a/include/linux/platform_data/clk-fch.h b/include/linux/platform_data/clk-fch.h
index b9f682459f08..850ca776156d 100644
--- a/include/linux/platform_data/clk-fch.h
+++ b/include/linux/platform_data/clk-fch.h
@@ -12,7 +12,6 @@
struct fch_clk_data {
void __iomem *base;
- u32 is_rv;
};
#endif /* __CLK_FCH_H */
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* [PATCH v4 3/7] ACPI: APD: Add a fmw property clk-name
[not found] <20211125110447.1188073-1-AjitKumar.Pandey@amd.com>
2021-11-25 11:04 ` [PATCH v4 2/7] drivers: acpi: acpi_apd: Remove unused device property "is-rv" Ajit Kumar Pandey
@ 2021-11-25 11:04 ` Ajit Kumar Pandey
1 sibling, 0 replies; 2+ messages in thread
From: Ajit Kumar Pandey @ 2021-11-25 11:04 UTC (permalink / raw)
To: sboyd, rafael, linux-clk
Cc: Vijendar.Mukunda, Alexander.Deucher, Basavaraj.Hiregoudar,
Sunil-kumar.Dommati, Mario.Limonciello, Ajit Kumar Pandey,
Len Brown, open list:ACPI, open list
Add a new device property to fetch clk-name from firmware.
Signed-off-by: Ajit Kumar Pandey <AjitKumar.Pandey@amd.com>
---
drivers/acpi/acpi_apd.c | 10 ++++++++++
include/linux/platform_data/clk-fch.h | 1 +
2 files changed, 11 insertions(+)
diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c
index 6913e9712852..2b958b426b03 100644
--- a/drivers/acpi/acpi_apd.c
+++ b/drivers/acpi/acpi_apd.c
@@ -87,6 +87,16 @@ static int fch_misc_setup(struct apd_private_data *pdata)
if (ret < 0)
return -ENOENT;
+ if (!acpi_dev_get_property(adev, "clk-name", ACPI_TYPE_STRING, &obj)) {
+ clk_data->name = devm_kzalloc(&adev->dev, obj->string.length,
+ GFP_KERNEL);
+
+ strcpy(clk_data->name, obj->string.pointer);
+ } else {
+ /* Set default name to mclk if entry missing in firmware */
+ clk_data->name = "mclk";
+ }
+
list_for_each_entry(rentry, &resource_list, node) {
clk_data->base = devm_ioremap(&adev->dev, rentry->res->start,
resource_size(rentry->res));
diff --git a/include/linux/platform_data/clk-fch.h b/include/linux/platform_data/clk-fch.h
index 850ca776156d..11a2a23fd9b2 100644
--- a/include/linux/platform_data/clk-fch.h
+++ b/include/linux/platform_data/clk-fch.h
@@ -12,6 +12,7 @@
struct fch_clk_data {
void __iomem *base;
+ char *name;
};
#endif /* __CLK_FCH_H */
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread