* [PATCH] ACPI: AGDI: Fix missing prototype warning for acpi_agdi_init()
@ 2022-04-25 22:18 Ilkka Koskinen
2022-05-06 18:36 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Ilkka Koskinen @ 2022-04-25 22:18 UTC (permalink / raw)
To: Lorenzo Pieralisi, Hanjun Guo, Sudeep Holla, Rafael J . Wysocki
Cc: Len Brown, Ilkka Koskinen, linux-acpi, linux-arm-kernel,
linux-kernel
When building with W=1, we get the following warning:
drivers/acpi/arm64/agdi.c:88:13: warning: no previous prototype for ‘acpi_agdi_init’ [-Wmissing-prototypes]
void __init acpi_agdi_init(void)
Include AGDI driver's header file to pull in the prototype definition
for acpi_agdi_init() to get rid of the compiler warning
Fixes: a2a591fb76e6 ("ACPI: AGDI: Add driver for Arm Generic Diagnostic Dump and Reset device")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Ilkka Koskinen <ilkka@os.amperecomputing.com>
---
drivers/acpi/arm64/agdi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/acpi/arm64/agdi.c b/drivers/acpi/arm64/agdi.c
index 4df337d545b7..cf31abd0ed1b 100644
--- a/drivers/acpi/arm64/agdi.c
+++ b/drivers/acpi/arm64/agdi.c
@@ -9,6 +9,7 @@
#define pr_fmt(fmt) "ACPI: AGDI: " fmt
#include <linux/acpi.h>
+#include <linux/acpi_agdi.h>
#include <linux/arm_sdei.h>
#include <linux/io.h>
#include <linux/kernel.h>
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ACPI: AGDI: Fix missing prototype warning for acpi_agdi_init()
2022-04-25 22:18 [PATCH] ACPI: AGDI: Fix missing prototype warning for acpi_agdi_init() Ilkka Koskinen
@ 2022-05-06 18:36 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2022-05-06 18:36 UTC (permalink / raw)
To: Ilkka Koskinen
Cc: Lorenzo Pieralisi, Hanjun Guo, Sudeep Holla, Rafael J . Wysocki,
Len Brown, ACPI Devel Maling List, Linux ARM,
Linux Kernel Mailing List
On Tue, Apr 26, 2022 at 12:18 AM Ilkka Koskinen
<ilkka@os.amperecomputing.com> wrote:
>
> When building with W=1, we get the following warning:
>
> drivers/acpi/arm64/agdi.c:88:13: warning: no previous prototype for ‘acpi_agdi_init’ [-Wmissing-prototypes]
> void __init acpi_agdi_init(void)
>
> Include AGDI driver's header file to pull in the prototype definition
> for acpi_agdi_init() to get rid of the compiler warning
>
> Fixes: a2a591fb76e6 ("ACPI: AGDI: Add driver for Arm Generic Diagnostic Dump and Reset device")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Ilkka Koskinen <ilkka@os.amperecomputing.com>
> ---
> drivers/acpi/arm64/agdi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/acpi/arm64/agdi.c b/drivers/acpi/arm64/agdi.c
> index 4df337d545b7..cf31abd0ed1b 100644
> --- a/drivers/acpi/arm64/agdi.c
> +++ b/drivers/acpi/arm64/agdi.c
> @@ -9,6 +9,7 @@
> #define pr_fmt(fmt) "ACPI: AGDI: " fmt
>
> #include <linux/acpi.h>
> +#include <linux/acpi_agdi.h>
> #include <linux/arm_sdei.h>
> #include <linux/io.h>
> #include <linux/kernel.h>
> --
Applied as 5.19 material, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-06 18:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-25 22:18 [PATCH] ACPI: AGDI: Fix missing prototype warning for acpi_agdi_init() Ilkka Koskinen
2022-05-06 18:36 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox