From: Bjorn Helgaas <helgaas@kernel.org>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Linux PCI <linux-pci@vger.kernel.org>,
Kai-Heng Feng <kai.heng.feng@canonical.com>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH] PCI/ASPM: Unexport pcie_aspm_support_enabled()
Date: Tue, 12 Jul 2022 14:36:08 -0500 [thread overview]
Message-ID: <20220712193608.GA788935@bhelgaas> (raw)
In-Reply-To: <CAJZ5v0gYhSkFWF49+orQsiqO0Kbmc_A+1L+QiZWcO6Q8sGWFKQ@mail.gmail.com>
On Tue, Jul 12, 2022 at 08:10:03PM +0200, Rafael J. Wysocki wrote:
> On Tue, Jul 12, 2022 at 1:14 AM Bjorn Helgaas <helgaas@kernel.org> wrote:
> >
> > From: Bjorn Helgaas <bhelgaas@google.com>
> >
> > pcie_aspm_support_enabled() is used only by the acpi/pci_root.c driver,
> > which cannot be built as a module, so it does not need to be exported.
> > Unexport it.
> >
> > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
>
> Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Thanks, applied with your Reviewed-by to pci/aspm for v5.20.
> > ---
> > drivers/pci/pcie/aspm.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/pci/pcie/aspm.c b/drivers/pci/pcie/aspm.c
> > index 7f76a5875feb..a8aec190986c 100644
> > --- a/drivers/pci/pcie/aspm.c
> > +++ b/drivers/pci/pcie/aspm.c
> > @@ -1347,4 +1347,3 @@ bool pcie_aspm_support_enabled(void)
> > {
> > return aspm_support_enabled;
> > }
> > -EXPORT_SYMBOL(pcie_aspm_support_enabled);
> > --
> > 2.25.1
> >
prev parent reply other threads:[~2022-07-12 19:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-11 23:14 [PATCH] PCI/ASPM: Unexport pcie_aspm_support_enabled() Bjorn Helgaas
2022-07-12 18:10 ` Rafael J. Wysocki
2022-07-12 19:36 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220712193608.GA788935@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=kai.heng.feng@canonical.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox