* [PATCH] PCI/ASPM: Unexport pcie_aspm_support_enabled()
@ 2022-07-11 23:14 Bjorn Helgaas
2022-07-12 18:10 ` Rafael J. Wysocki
0 siblings, 1 reply; 3+ messages in thread
From: Bjorn Helgaas @ 2022-07-11 23:14 UTC (permalink / raw)
To: linux-pci; +Cc: Kai-Heng Feng, linux-acpi, linux-kernel, Bjorn Helgaas
From: Bjorn Helgaas <bhelgaas@google.com>
pcie_aspm_support_enabled() is used only by the acpi/pci_root.c driver,
which cannot be built as a module, so it does not need to be exported.
Unexport it.
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
---
drivers/pci/pcie/aspm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/pci/pcie/aspm.c b/drivers/pci/pcie/aspm.c
index 7f76a5875feb..a8aec190986c 100644
--- a/drivers/pci/pcie/aspm.c
+++ b/drivers/pci/pcie/aspm.c
@@ -1347,4 +1347,3 @@ bool pcie_aspm_support_enabled(void)
{
return aspm_support_enabled;
}
-EXPORT_SYMBOL(pcie_aspm_support_enabled);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] PCI/ASPM: Unexport pcie_aspm_support_enabled()
2022-07-11 23:14 [PATCH] PCI/ASPM: Unexport pcie_aspm_support_enabled() Bjorn Helgaas
@ 2022-07-12 18:10 ` Rafael J. Wysocki
2022-07-12 19:36 ` Bjorn Helgaas
0 siblings, 1 reply; 3+ messages in thread
From: Rafael J. Wysocki @ 2022-07-12 18:10 UTC (permalink / raw)
To: Bjorn Helgaas
Cc: Linux PCI, Kai-Heng Feng, ACPI Devel Maling List,
Linux Kernel Mailing List, Bjorn Helgaas
On Tue, Jul 12, 2022 at 1:14 AM Bjorn Helgaas <helgaas@kernel.org> wrote:
>
> From: Bjorn Helgaas <bhelgaas@google.com>
>
> pcie_aspm_support_enabled() is used only by the acpi/pci_root.c driver,
> which cannot be built as a module, so it does not need to be exported.
> Unexport it.
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
> drivers/pci/pcie/aspm.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pci/pcie/aspm.c b/drivers/pci/pcie/aspm.c
> index 7f76a5875feb..a8aec190986c 100644
> --- a/drivers/pci/pcie/aspm.c
> +++ b/drivers/pci/pcie/aspm.c
> @@ -1347,4 +1347,3 @@ bool pcie_aspm_support_enabled(void)
> {
> return aspm_support_enabled;
> }
> -EXPORT_SYMBOL(pcie_aspm_support_enabled);
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] PCI/ASPM: Unexport pcie_aspm_support_enabled()
2022-07-12 18:10 ` Rafael J. Wysocki
@ 2022-07-12 19:36 ` Bjorn Helgaas
0 siblings, 0 replies; 3+ messages in thread
From: Bjorn Helgaas @ 2022-07-12 19:36 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Linux PCI, Kai-Heng Feng, ACPI Devel Maling List,
Linux Kernel Mailing List, Bjorn Helgaas
On Tue, Jul 12, 2022 at 08:10:03PM +0200, Rafael J. Wysocki wrote:
> On Tue, Jul 12, 2022 at 1:14 AM Bjorn Helgaas <helgaas@kernel.org> wrote:
> >
> > From: Bjorn Helgaas <bhelgaas@google.com>
> >
> > pcie_aspm_support_enabled() is used only by the acpi/pci_root.c driver,
> > which cannot be built as a module, so it does not need to be exported.
> > Unexport it.
> >
> > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
>
> Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Thanks, applied with your Reviewed-by to pci/aspm for v5.20.
> > ---
> > drivers/pci/pcie/aspm.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/pci/pcie/aspm.c b/drivers/pci/pcie/aspm.c
> > index 7f76a5875feb..a8aec190986c 100644
> > --- a/drivers/pci/pcie/aspm.c
> > +++ b/drivers/pci/pcie/aspm.c
> > @@ -1347,4 +1347,3 @@ bool pcie_aspm_support_enabled(void)
> > {
> > return aspm_support_enabled;
> > }
> > -EXPORT_SYMBOL(pcie_aspm_support_enabled);
> > --
> > 2.25.1
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-12 19:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-11 23:14 [PATCH] PCI/ASPM: Unexport pcie_aspm_support_enabled() Bjorn Helgaas
2022-07-12 18:10 ` Rafael J. Wysocki
2022-07-12 19:36 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox