From: Sudeep Holla <sudeep.holla@arm.com>
To: Huisong Li <lihuisong@huawei.com>
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
Sudeep Holla <sudeep.holla@arm.com>,
rafael@kernel.org, rafael.j.wysocki@intel.com,
wanghuiqiang@huawei.com, zhangzekun11@huawei.com,
wangxiongfeng2@huawei.com, tanxiaofei@huawei.com,
guohanjun@huawei.com, xiexiuqi@huawei.com,
wangkefeng.wang@huawei.com, huangdaode@huawei.com
Subject: Re: [PATCH 1/3] mailbox: pcc: rename platform interrupt bit macro name
Date: Thu, 10 Nov 2022 10:25:28 +0000 [thread overview]
Message-ID: <20221110102528.6kuznowxtqkouvlb@bogus> (raw)
In-Reply-To: <20221110015034.7943-2-lihuisong@huawei.com>
On Thu, Nov 10, 2022 at 09:50:32AM +0800, Huisong Li wrote:
> Currently, the name of platform interrupt bit macro, ACPI_PCCT_DOORBELL,
> is not very appropriate. The doorbell is generally considered as an action
> when send mailbox data. Actually, the macro value comes from Platform
> Interrupt in Platform Communications Channel Global Flags. If the bit is
> '1', it means that the platform is capable of generating an interrupt to
> indicate completion of a command.
>
This is touching ACPICA header file, so it must be submitted to ACPICA
separately following the guidelines in the github and imported into the
kernel.
However, I don't see any point in this change. Yes the language "doorbell"
is not used in this particular context in the spec, but it is implicit from
other parts. I am not opposing the change though if Rafael is OK and ACPICA
project accepts it.
--
Regards,
Sudeep
next prev parent reply other threads:[~2022-11-10 10:25 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-10 1:50 [PATCH 0/3] ACPI: PCC: optimize pcc codes and fix one bug Huisong Li
2022-11-10 1:50 ` [PATCH 1/3] mailbox: pcc: rename platform interrupt bit macro name Huisong Li
2022-11-10 10:25 ` Sudeep Holla [this message]
2022-11-10 12:17 ` lihuisong (C)
2022-11-10 19:29 ` Rafael J. Wysocki
2022-11-11 1:10 ` lihuisong (C)
2022-11-10 1:50 ` [PATCH 2/3] ACPI: PCC: add check for platform interrupt Huisong Li
2022-11-10 10:36 ` Sudeep Holla
2022-11-10 12:08 ` lihuisong (C)
2022-11-10 1:50 ` [PATCH 3/3] mailbox: pcc: fix 'pcc_chan_count' when fail to initialize PCC Huisong Li
2022-11-10 10:44 ` Sudeep Holla
2022-11-10 12:10 ` lihuisong (C)
2022-11-11 2:44 ` [PATCH V2 0/2] optimize pcc code and fix one bug Huisong Li
2022-11-11 2:44 ` [PATCH V2 1/2] ACPI: PCC: add check for platform interrupt Huisong Li
2022-11-11 14:26 ` Sudeep Holla
2022-11-12 1:27 ` lihuisong (C)
2022-11-11 2:44 ` [PATCH V2 2/2] mailbox: pcc: fix 'pcc_chan_count' when fail to initialize PCC Huisong Li
2022-11-11 14:14 ` Sudeep Holla
2022-11-12 2:05 ` [PATCH V3 0/2] Optimize PCC OpRegion code and reset pcc_chan_count Huisong Li
2022-11-12 2:05 ` [PATCH V3 1/2] ACPI: PCC: Setup PCC Opregion handler only if platform interrupt is available Huisong Li
2022-11-12 2:05 ` [PATCH V3 2/2] mailbox: pcc: Reset pcc_chan_count to zero in case of PCC probe failure Huisong Li
2022-11-23 18:28 ` [PATCH V3 0/2] Optimize PCC OpRegion code and reset pcc_chan_count Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221110102528.6kuznowxtqkouvlb@bogus \
--to=sudeep.holla@arm.com \
--cc=guohanjun@huawei.com \
--cc=huangdaode@huawei.com \
--cc=lihuisong@huawei.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
--cc=tanxiaofei@huawei.com \
--cc=wanghuiqiang@huawei.com \
--cc=wangkefeng.wang@huawei.com \
--cc=wangxiongfeng2@huawei.com \
--cc=xiexiuqi@huawei.com \
--cc=zhangzekun11@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox