From: Michal Wilczynski <michal.wilczynski@intel.com>
To: rafael@kernel.org, lenb@kernel.org, dan.j.williams@intel.com,
vishal.l.verma@intel.com, dave.jiang@intel.com,
ira.weiny@intel.com, rui.zhang@intel.com, jdelvare@suse.com,
linux@roeck-us.net, jic23@kernel.org, lars@metafoo.de,
bleung@chromium.org, yu.c.chen@intel.com, hdegoede@redhat.com,
markgross@kernel.org, luzmaximilian@gmail.com,
corentin.chary@gmail.com, jprvita@gmail.com,
cascardo@holoscopio.com, don@syst.com.br, pali@kernel.org,
jwoithe@just42.net, matan@svgalib.org, kenneth.t.chan@gmail.com,
malattia@linux.it, jeremy@system76.com, productdev@system76.com,
herton@canonical.com, coproscefalo@gmail.com, tytso@mit.edu,
Jason@zx2c4.com, robert.moore@intel.com
Cc: linux-acpi@vger.kernel.org, nvdimm@lists.linux.dev,
linux-hwmon@vger.kernel.org, linux-iio@vger.kernel.org,
chrome-platform@lists.linux.dev,
platform-driver-x86@vger.kernel.org,
acpi4asus-user@lists.sourceforge.net,
Michal Wilczynski <michal.wilczynski@intel.com>
Subject: [PATCH v4 00/35] Remove .notify callback in acpi_device_ops
Date: Thu, 1 Jun 2023 15:16:55 +0200 [thread overview]
Message-ID: <20230601131655.300675-1-michal.wilczynski@intel.com> (raw)
Currently drivers support ACPI event handlers by defining .notify
callback in acpi_device_ops. This solution is suboptimal as event
handler installer installs intermediary function acpi_notify_device as a
handler in every driver. Also this approach requires extra variable
'flags' for specifying event types that the driver want to subscribe to.
Additionally this is a pre-work required to align acpi_driver with
platform_driver and eventually replace acpi_driver with platform_driver.
Remove .notify callback from the acpi_device_ops. Replace it with each
driver installing and removing it's event handlers.
v4:
- added one commit for previously missed driver sony-laptop,
refactored return statements, added NULL check for event installer
v3:
- lkp still reported some failures for eeepc, fujitsu and
toshiba_bluetooth, fix those
v2:
- fix compilation errors for drivers
Michal Wilczynski (35):
acpi: Adjust functions installing bus event handlers
acpi/ac: Move handler installing logic to driver
acpi/video: Move handler installing logic to driver
acpi/battery: Move handler installing logic to driver
acpi/button: Move handler installing logic to driver
acpi/hed: Move handler installing logic to driver
acpi/nfit: Move handler installing logic to driver
acpi/thermal: Move handler installing logic to driver
acpi/tiny-power-button: Move handler installing logic to driver
hwmon/acpi_power_meter: Move handler installing logic to driver
iio/acpi-als: Move handler installing logic to driver
platform/chromeos_tbmc: Move handler installing logic to driver
platform/wilco_ec: Move handler installing logic to driver
platform/surface/button: Move handler installing logic to driver
platform/x86/acer-wireless: Move handler installing logic to driver
platform/x86/asus-laptop: Move handler installing logic to driver
platform/x86/asus-wireless: Move handler installing logic to driver
platform/x86/classmate-laptop: Move handler installing logic to driver
platform/x86/dell/dell-rbtn: Move handler installing logic to driver
platform/x86/eeepc-laptop: Move handler installing logic to driver
platform/x86/fujitsu-laptop: Move handler installing logic to driver
platform/x86/lg-laptop: Move handler installing logic to driver
platform/x86/panasonic-laptop: Move handler installing logic to driver
platform/x86/system76_acpi: Move handler installing logic to driver
platform/x86/topstar-laptop: Move handler installing logic to driver
platform/x86/toshiba_acpi: Move handler installing logic to driver
platform/x86/toshiba_bluetooth: Move handler installing logic to
driver
platform/x86/toshiba_haps: Move handler installing logic to driver
platform/x86/wireless-hotkey: Move handler installing logic to driver
platform/x86/xo15-ebook: Move handler installing logic to driver
platform/x86/sony-laptop: Move handler installing logic to driver
virt/vmgenid: Move handler installing logic to driver
acpi/bus: Remove installing/removing notify handlers from probe/remove
acpi/bus: Remove redundant functions
acpi/bus: Remove notify callback and flags
drivers/acpi/ac.c | 14 +-
drivers/acpi/acpi_video.c | 16 ++-
drivers/acpi/battery.c | 16 ++-
drivers/acpi/bus.c | 56 +++-----
drivers/acpi/button.c | 16 ++-
drivers/acpi/hed.c | 7 +-
drivers/acpi/nfit/core.c | 25 ++--
drivers/acpi/thermal.c | 20 ++-
drivers/acpi/tiny-power-button.c | 18 +--
drivers/hwmon/acpi_power_meter.c | 15 +-
drivers/iio/light/acpi-als.c | 23 +++-
drivers/platform/chrome/chromeos_tbmc.c | 14 +-
drivers/platform/chrome/wilco_ec/event.c | 17 ++-
drivers/platform/surface/surfacepro3_button.c | 17 ++-
drivers/platform/x86/acer-wireless.c | 22 ++-
drivers/platform/x86/asus-laptop.c | 14 +-
drivers/platform/x86/asus-wireless.c | 24 ++--
drivers/platform/x86/classmate-laptop.c | 53 +++++--
drivers/platform/x86/dell/dell-rbtn.c | 17 ++-
drivers/platform/x86/eeepc-laptop.c | 16 ++-
drivers/platform/x86/fujitsu-laptop.c | 86 +++++++-----
drivers/platform/x86/lg-laptop.c | 10 +-
drivers/platform/x86/panasonic-laptop.c | 18 ++-
drivers/platform/x86/sony-laptop.c | 9 +-
drivers/platform/x86/system76_acpi.c | 26 ++--
drivers/platform/x86/topstar-laptop.c | 14 +-
drivers/platform/x86/toshiba_acpi.c | 129 +++++++++---------
drivers/platform/x86/toshiba_bluetooth.c | 30 ++--
drivers/platform/x86/toshiba_haps.c | 9 +-
drivers/platform/x86/wireless-hotkey.c | 24 +++-
drivers/platform/x86/xo15-ebook.c | 9 +-
drivers/virt/vmgenid.c | 30 ++--
include/acpi/acpi_bus.h | 10 +-
33 files changed, 530 insertions(+), 294 deletions(-)
--
2.40.1
next reply other threads:[~2023-06-01 13:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 13:16 Michal Wilczynski [this message]
2023-06-03 11:03 ` [PATCH v4 00/35] Remove .notify callback in acpi_device_ops andy.shevchenko
2023-06-05 8:39 ` Wilczynski, Michal
2023-06-05 9:50 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230601131655.300675-1-michal.wilczynski@intel.com \
--to=michal.wilczynski@intel.com \
--cc=Jason@zx2c4.com \
--cc=acpi4asus-user@lists.sourceforge.net \
--cc=bleung@chromium.org \
--cc=cascardo@holoscopio.com \
--cc=chrome-platform@lists.linux.dev \
--cc=coproscefalo@gmail.com \
--cc=corentin.chary@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=don@syst.com.br \
--cc=hdegoede@redhat.com \
--cc=herton@canonical.com \
--cc=ira.weiny@intel.com \
--cc=jdelvare@suse.com \
--cc=jeremy@system76.com \
--cc=jic23@kernel.org \
--cc=jprvita@gmail.com \
--cc=jwoithe@just42.net \
--cc=kenneth.t.chan@gmail.com \
--cc=lars@metafoo.de \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=luzmaximilian@gmail.com \
--cc=malattia@linux.it \
--cc=markgross@kernel.org \
--cc=matan@svgalib.org \
--cc=nvdimm@lists.linux.dev \
--cc=pali@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=productdev@system76.com \
--cc=rafael@kernel.org \
--cc=robert.moore@intel.com \
--cc=rui.zhang@intel.com \
--cc=tytso@mit.edu \
--cc=vishal.l.verma@intel.com \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox