Linux ACPI
 help / color / mirror / Atom feed
From: "Wilczynski, Michal" <michal.wilczynski@intel.com>
To: <andy.shevchenko@gmail.com>
Cc: <rafael@kernel.org>, <lenb@kernel.org>,
	<dan.j.williams@intel.com>, <vishal.l.verma@intel.com>,
	<dave.jiang@intel.com>, <ira.weiny@intel.com>,
	<rui.zhang@intel.com>, <jdelvare@suse.com>, <linux@roeck-us.net>,
	<jic23@kernel.org>, <lars@metafoo.de>, <bleung@chromium.org>,
	<yu.c.chen@intel.com>, <hdegoede@redhat.com>,
	<markgross@kernel.org>, <luzmaximilian@gmail.com>,
	<corentin.chary@gmail.com>, <jprvita@gmail.com>,
	<cascardo@holoscopio.com>, <don@syst.com.br>, <pali@kernel.org>,
	<jwoithe@just42.net>, <matan@svgalib.org>,
	<kenneth.t.chan@gmail.com>, <malattia@linux.it>,
	<jeremy@system76.com>, <productdev@system76.com>,
	<herton@canonical.com>, <coproscefalo@gmail.com>, <tytso@mit.edu>,
	<Jason@zx2c4.com>, <robert.moore@intel.com>,
	<linux-acpi@vger.kernel.org>, <nvdimm@lists.linux.dev>,
	<linux-hwmon@vger.kernel.org>, <linux-iio@vger.kernel.org>,
	<chrome-platform@lists.linux.dev>,
	<platform-driver-x86@vger.kernel.org>,
	<acpi4asus-user@lists.sourceforge.net>
Subject: Re: [PATCH v4 00/35] Remove .notify callback in acpi_device_ops
Date: Mon, 5 Jun 2023 10:39:27 +0200	[thread overview]
Message-ID: <9180d191-9713-b6a0-6a77-43310f9fe9df@intel.com> (raw)
In-Reply-To: <ZHsd-je7kDDpii2q@surfacebook>



On 6/3/2023 1:03 PM, andy.shevchenko@gmail.com wrote:
> Thu, Jun 01, 2023 at 03:16:55PM +0200, Michal Wilczynski kirjoitti:
>> Currently drivers support ACPI event handlers by defining .notify
>> callback in acpi_device_ops. This solution is suboptimal as event
>> handler installer installs intermediary function acpi_notify_device as a
>> handler in every driver. Also this approach requires extra variable
>> 'flags' for specifying event types that the driver want to subscribe to.
>> Additionally this is a pre-work required to align acpi_driver with
>> platform_driver and eventually replace acpi_driver with platform_driver.
>>
>> Remove .notify callback from the acpi_device_ops. Replace it with each
>> driver installing and removing it's event handlers.
> Somehow this thread is screwed up in a sense of linking messages.
> Even on the archives there are rather individual patches.
>
> Please, be sure you are always use --thread when formatting it.
> Yet you have a possibility to Cc different patches to the different
> mailing lists and people.

Hi,
Thank you for this remark, I was trying to be clever and tried to send a patch
in a bit non-canonical way. So I've send a cover letter and a couple of other
major bits of a solution to everyone from the output of scripts/get_maintainer.pl
run on every patch from this series.

./scripts/get_maintainer.pl /home/mwilczyn/patches/remove_notify_external/*

(where remove_notify_external contains all patches generated for this patchset)

For the rest I used --to-cmd and --cc-cmd options of git send-email. This way I could
send patches with minor changes to every driver to only specified people marked
by get_maintainer.pl for this individual patch.

Hope that when re-sending with next revision --thread can help.

>


  reply	other threads:[~2023-06-05  8:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-01 13:16 [PATCH v4 00/35] Remove .notify callback in acpi_device_ops Michal Wilczynski
2023-06-03 11:03 ` andy.shevchenko
2023-06-05  8:39   ` Wilczynski, Michal [this message]
2023-06-05  9:50     ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9180d191-9713-b6a0-6a77-43310f9fe9df@intel.com \
    --to=michal.wilczynski@intel.com \
    --cc=Jason@zx2c4.com \
    --cc=acpi4asus-user@lists.sourceforge.net \
    --cc=andy.shevchenko@gmail.com \
    --cc=bleung@chromium.org \
    --cc=cascardo@holoscopio.com \
    --cc=chrome-platform@lists.linux.dev \
    --cc=coproscefalo@gmail.com \
    --cc=corentin.chary@gmail.com \
    --cc=dan.j.williams@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=don@syst.com.br \
    --cc=hdegoede@redhat.com \
    --cc=herton@canonical.com \
    --cc=ira.weiny@intel.com \
    --cc=jdelvare@suse.com \
    --cc=jeremy@system76.com \
    --cc=jic23@kernel.org \
    --cc=jprvita@gmail.com \
    --cc=jwoithe@just42.net \
    --cc=kenneth.t.chan@gmail.com \
    --cc=lars@metafoo.de \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=luzmaximilian@gmail.com \
    --cc=malattia@linux.it \
    --cc=markgross@kernel.org \
    --cc=matan@svgalib.org \
    --cc=nvdimm@lists.linux.dev \
    --cc=pali@kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=productdev@system76.com \
    --cc=rafael@kernel.org \
    --cc=robert.moore@intel.com \
    --cc=rui.zhang@intel.com \
    --cc=tytso@mit.edu \
    --cc=vishal.l.verma@intel.com \
    --cc=yu.c.chen@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox