Linux ACPI
 help / color / mirror / Atom feed
From: Mario Limonciello <mario.limonciello@amd.com>
To: "Rafael J . Wysocki" <rafael@kernel.org>
Cc: "open list:ACPI" <linux-acpi@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>,
	Mario Limonciello <mario.limonciello@amd.com>,
	PradeepVineshReddy Kodamati <PradeepVineshReddy.Kodamati@amd.com>,
	CL Lin <clin41@lenovo.com>
Subject: [PATCH] ACPI: Only evaluate the Intel _OSC and _PDC on platforms with HWP
Date: Fri, 14 Jun 2024 14:32:41 -0500	[thread overview]
Message-ID: <20240614193241.7341-1-mario.limonciello@amd.com> (raw)

The UUID 4077A616-290C-47BE-9EBD-D87058713953 and _PDC methods are
only used on Intel platforms with HWP support.

Attempting to evaluate them and showing messages on hardware without
HWP is pointless needlessly noisy.

Gate the code on X86_FEATURE_HWP.

Cc: PradeepVineshReddy (Pradeep Vinesh Reddy) Kodamati <PradeepVineshReddy.Kodamati@amd.com>
Suggested-by: CL Lin <clin41@lenovo.com>
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
 drivers/acpi/acpi_processor.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/acpi/acpi_processor.c b/drivers/acpi/acpi_processor.c
index 7a0dd35d62c9..84848b5e65d6 100644
--- a/drivers/acpi/acpi_processor.c
+++ b/drivers/acpi/acpi_processor.c
@@ -597,6 +597,8 @@ static bool __init acpi_early_processor_osc(void)
 
 void __init acpi_early_processor_control_setup(void)
 {
+	if (!boot_cpu_has(X86_FEATURE_HWP))
+		return;
 	if (acpi_early_processor_osc()) {
 		pr_info("_OSC evaluated successfully for all CPUs\n");
 	} else {
-- 
2.43.0


             reply	other threads:[~2024-06-14 19:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-14 19:32 Mario Limonciello [this message]
2024-06-15 10:38 ` [PATCH] ACPI: Only evaluate the Intel _OSC and _PDC on platforms with HWP Rafael J. Wysocki
2024-06-18 19:33   ` Mario Limonciello
2024-06-18 19:46     ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240614193241.7341-1-mario.limonciello@amd.com \
    --to=mario.limonciello@amd.com \
    --cc=PradeepVineshReddy.Kodamati@amd.com \
    --cc=clin41@lenovo.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox