public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Mario Limonciello <mario.limonciello@amd.com>
To: "Hans de Goede" <hdegoede@redhat.com>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: "Rafael J . Wysocki" <rafael@kernel.org>,
	"Len Brown" <lenb@kernel.org>,
	"Maximilian Luz" <luzmaximilian@gmail.com>,
	"Lee Chun-Yi" <jlee@suse.com>,
	"Shyam Sundar S K" <Shyam-sundar.S-k@amd.com>,
	"Corentin Chary" <corentin.chary@gmail.com>,
	"Luke D . Jones" <luke@ljones.dev>,
	"Ike Panhc" <ike.pan@canonical.com>,
	"Henrique de Moraes Holschuh" <hmh@hmh.eng.br>,
	"Alexis Belmonte" <alexbelm48@gmail.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Ai Chao" <aichao@kylinos.cn>, "Gergo Koteles" <soyer@irl.hu>,
	"open list" <linux-kernel@vger.kernel.org>,
	"open list:ACPI" <linux-acpi@vger.kernel.org>,
	"open list:MICROSOFT SURFACE PLATFORM PROFILE DRIVER"
	<platform-driver-x86@vger.kernel.org>,
	"open list:THINKPAD ACPI EXTRAS DRIVER"
	<ibm-acpi-devel@lists.sourceforge.net>,
	"Mark Pearson" <mpearson-lenovo@squebb.ca>,
	"Matthew Schwartz" <matthew.schwartz@linux.dev>,
	"Mario Limonciello" <mario.limonciello@amd.com>
Subject: [PATCH v4 19/20] platform/x86/amd: pmf: Drop all quirks
Date: Tue, 5 Nov 2024 09:33:15 -0600	[thread overview]
Message-ID: <20241105153316.378-20-mario.limonciello@amd.com> (raw)
In-Reply-To: <20241105153316.378-1-mario.limonciello@amd.com>

As multiple platform profile handlers can now be registered, the quirks
to avoid registering amd-pmf as a handler are no longer necessary.
Drop them.

Tested-by: Matthew Schwartz <matthew.schwartz@linux.dev>
Acked-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
 drivers/platform/x86/amd/pmf/Makefile     |  2 +-
 drivers/platform/x86/amd/pmf/core.c       |  1 -
 drivers/platform/x86/amd/pmf/pmf-quirks.c | 66 -----------------------
 drivers/platform/x86/amd/pmf/pmf.h        |  3 --
 4 files changed, 1 insertion(+), 71 deletions(-)
 delete mode 100644 drivers/platform/x86/amd/pmf/pmf-quirks.c

diff --git a/drivers/platform/x86/amd/pmf/Makefile b/drivers/platform/x86/amd/pmf/Makefile
index 7d6079b02589c..6b26e48ce8ad2 100644
--- a/drivers/platform/x86/amd/pmf/Makefile
+++ b/drivers/platform/x86/amd/pmf/Makefile
@@ -7,4 +7,4 @@
 obj-$(CONFIG_AMD_PMF) += amd-pmf.o
 amd-pmf-objs := core.o acpi.o sps.o \
 		auto-mode.o cnqf.o \
-		tee-if.o spc.o pmf-quirks.o
+		tee-if.o spc.o
diff --git a/drivers/platform/x86/amd/pmf/core.c b/drivers/platform/x86/amd/pmf/core.c
index 47126abd13ca0..6ad00b3d472fe 100644
--- a/drivers/platform/x86/amd/pmf/core.c
+++ b/drivers/platform/x86/amd/pmf/core.c
@@ -455,7 +455,6 @@ static int amd_pmf_probe(struct platform_device *pdev)
 	mutex_init(&dev->lock);
 	mutex_init(&dev->update_mutex);
 
-	amd_pmf_quirks_init(dev);
 	apmf_acpi_init(dev);
 	platform_set_drvdata(pdev, dev);
 	amd_pmf_dbgfs_register(dev);
diff --git a/drivers/platform/x86/amd/pmf/pmf-quirks.c b/drivers/platform/x86/amd/pmf/pmf-quirks.c
deleted file mode 100644
index 7cde5733b9cac..0000000000000
--- a/drivers/platform/x86/amd/pmf/pmf-quirks.c
+++ /dev/null
@@ -1,66 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0-or-later
-/*
- * AMD Platform Management Framework Driver Quirks
- *
- * Copyright (c) 2024, Advanced Micro Devices, Inc.
- * All Rights Reserved.
- *
- * Author: Mario Limonciello <mario.limonciello@amd.com>
- */
-
-#include <linux/dmi.h>
-
-#include "pmf.h"
-
-struct quirk_entry {
-	u32 supported_func;
-};
-
-static struct quirk_entry quirk_no_sps_bug = {
-	.supported_func = 0x4003,
-};
-
-static const struct dmi_system_id fwbug_list[] = {
-	{
-		.ident = "ROG Zephyrus G14",
-		.matches = {
-			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
-			DMI_MATCH(DMI_PRODUCT_NAME, "GA403U"),
-		},
-		.driver_data = &quirk_no_sps_bug,
-	},
-	{
-		.ident = "ROG Ally X",
-		.matches = {
-			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
-			DMI_MATCH(DMI_PRODUCT_NAME, "RC72LA"),
-		},
-		.driver_data = &quirk_no_sps_bug,
-	},
-	{
-		.ident = "ASUS TUF Gaming A14",
-		.matches = {
-			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
-			DMI_MATCH(DMI_PRODUCT_NAME, "FA401W"),
-		},
-		.driver_data = &quirk_no_sps_bug,
-	},
-	{}
-};
-
-void amd_pmf_quirks_init(struct amd_pmf_dev *dev)
-{
-	const struct dmi_system_id *dmi_id;
-	struct quirk_entry *quirks;
-
-	dmi_id = dmi_first_match(fwbug_list);
-	if (!dmi_id)
-		return;
-
-	quirks = dmi_id->driver_data;
-	if (quirks->supported_func) {
-		dev->supported_func = quirks->supported_func;
-		pr_info("Using supported funcs quirk to avoid %s platform firmware bug\n",
-			dmi_id->ident);
-	}
-}
diff --git a/drivers/platform/x86/amd/pmf/pmf.h b/drivers/platform/x86/amd/pmf/pmf.h
index 8ce8816da9c16..b89aa38434faa 100644
--- a/drivers/platform/x86/amd/pmf/pmf.h
+++ b/drivers/platform/x86/amd/pmf/pmf.h
@@ -795,7 +795,4 @@ int amd_pmf_smartpc_apply_bios_output(struct amd_pmf_dev *dev, u32 val, u32 preq
 void amd_pmf_populate_ta_inputs(struct amd_pmf_dev *dev, struct ta_pmf_enact_table *in);
 void amd_pmf_dump_ta_inputs(struct amd_pmf_dev *dev, struct ta_pmf_enact_table *in);
 
-/* Quirk infrastructure */
-void amd_pmf_quirks_init(struct amd_pmf_dev *dev);
-
 #endif /* PMF_H */
-- 
2.43.0


  parent reply	other threads:[~2024-11-05 15:33 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-05 15:32 [PATCH v4 00/20] Add support for binding ACPI platform profile to multiple drivers Mario Limonciello
2024-11-05 15:32 ` [PATCH v4 01/20] ACPI: platform-profile: Add a name member to handlers Mario Limonciello
2024-11-06  3:27   ` Armin Wolf
2024-11-05 15:32 ` [PATCH v4 02/20] platform/x86/dell: dell-pc: Create platform device Mario Limonciello
2024-11-06 19:37   ` Armin Wolf
2024-11-05 15:32 ` [PATCH v4 03/20] ACPI: platform_profile: Add device pointer into platform profile handler Mario Limonciello
2024-11-06  3:32   ` Armin Wolf
2024-11-05 15:33 ` [PATCH v4 04/20] ACPI: platform_profile: Add platform handler argument to platform_profile_remove() Mario Limonciello
2024-11-06  3:34   ` Armin Wolf
2024-11-05 15:33 ` [PATCH v4 05/20] ACPI: platform_profile: Move sanity check out of the mutex Mario Limonciello
2024-11-06  3:35   ` Armin Wolf
2024-11-05 15:33 ` [PATCH v4 06/20] ACPI: platform_profile: Move matching string for new profile out of mutex Mario Limonciello
2024-11-05 15:38   ` Ilpo Järvinen
2024-11-06  3:36   ` Armin Wolf
2024-11-05 15:33 ` [PATCH v4 07/20] ACPI: platform_profile: Use guard(mutex) for register/unregister Mario Limonciello
2024-11-06  3:37   ` Armin Wolf
2024-11-05 15:33 ` [PATCH v4 08/20] ACPI: platform_profile: Use `scoped_cond_guard` Mario Limonciello
2024-11-05 15:54   ` Ilpo Järvinen
2024-11-05 15:33 ` [PATCH v4 09/20] ACPI: platform_profile: Create class for ACPI platform profile Mario Limonciello
2024-11-06  3:53   ` Armin Wolf
2024-11-05 15:33 ` [PATCH v4 10/20] ACPI: platform_profile: Add name attribute to class interface Mario Limonciello
2024-11-06  3:56   ` Armin Wolf
2024-11-05 15:33 ` [PATCH v4 11/20] ACPI: platform_profile: Add choices attribute for " Mario Limonciello
2024-11-06  1:09   ` kernel test robot
2024-11-06  4:00   ` Armin Wolf
2024-11-05 15:33 ` [PATCH v4 12/20] ACPI: platform_profile: Add profile " Mario Limonciello
2024-11-06  4:10   ` Armin Wolf
2024-11-06  5:46     ` Mario Limonciello
2024-11-06 19:15       ` Armin Wolf
2024-11-05 15:33 ` [PATCH v4 13/20] ACPI: platform_profile: Notify change events on register and unregister Mario Limonciello
2024-11-06 19:40   ` Armin Wolf
2024-11-06 19:44     ` Mario Limonciello
2024-11-06 20:58       ` Armin Wolf
2024-11-05 15:33 ` [PATCH v4 14/20] ACPI: platform_profile: Only show profiles common for all handlers Mario Limonciello
2024-11-06 19:41   ` Armin Wolf
2024-11-06 19:44     ` Mario Limonciello
2024-11-05 15:33 ` [PATCH v4 15/20] ACPI: platform_profile: Add concept of a "custom" profile Mario Limonciello
2024-11-06 19:17   ` Armin Wolf
2024-11-05 15:33 ` [PATCH v4 16/20] ACPI: platform_profile: Make sure all profile handlers agree on profile Mario Limonciello
2024-11-06 20:58   ` Armin Wolf
2024-11-06 21:25     ` Mario Limonciello
2024-11-06 21:31       ` Armin Wolf
2024-11-05 15:33 ` [PATCH v4 17/20] ACPI: platform_profile: Check all profile handler to calculate next Mario Limonciello
2024-11-06 20:55   ` Armin Wolf
2024-11-05 15:33 ` [PATCH v4 18/20] ACPI: platform_profile: Allow multiple handlers Mario Limonciello
2024-11-06 19:21   ` Armin Wolf
2024-11-06 19:33     ` Armin Wolf
2024-11-06 19:34       ` Mario Limonciello
2024-11-05 15:33 ` Mario Limonciello [this message]
2024-11-06 19:30   ` [PATCH v4 19/20] platform/x86/amd: pmf: Drop all quirks Armin Wolf
2024-11-05 15:33 ` [PATCH v4 20/20] Documentation: Add documentation about class interface for platform profiles Mario Limonciello
2024-11-05 22:49   ` Mark Pearson
2024-11-05 22:47 ` [PATCH v4 00/20] Add support for binding ACPI platform profile to multiple drivers Mark Pearson
2024-11-06  1:11   ` Mario Limonciello
2024-11-06 21:04     ` Armin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241105153316.378-20-mario.limonciello@amd.com \
    --to=mario.limonciello@amd.com \
    --cc=Shyam-sundar.S-k@amd.com \
    --cc=aichao@kylinos.cn \
    --cc=alexbelm48@gmail.com \
    --cc=corentin.chary@gmail.com \
    --cc=hdegoede@redhat.com \
    --cc=hmh@hmh.eng.br \
    --cc=ibm-acpi-devel@lists.sourceforge.net \
    --cc=ike.pan@canonical.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=jlee@suse.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luke@ljones.dev \
    --cc=luzmaximilian@gmail.com \
    --cc=matthew.schwartz@linux.dev \
    --cc=mpearson-lenovo@squebb.ca \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=soyer@irl.hu \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox