Re: [PATCH v4 07/20] ACPI: platform_profile: Use guard(mutex) for register/unregister

[Armin Wolf <W_Armin@gmx.de>]

Am 05.11.24 um 16:33 schrieb Mario Limonciello:

> guard(mutex) can be used to automatically release mutexes when going
> out of scope.

Reviewed-by: Armin Wolf <W_Armin@gmx.de>

> Tested-by: Matthew Schwartz <matthew.schwartz@linux.dev>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
> Reviewed-by: Mark Pearson <mpearson-lenovo@squebb.ca>
> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
>   drivers/acpi/platform_profile.c | 16 +++++-----------
>   1 file changed, 5 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/acpi/platform_profile.c b/drivers/acpi/platform_profile.c
> index 70e7f1ba68676..4454c4a903c8f 100644
> --- a/drivers/acpi/platform_profile.c
> +++ b/drivers/acpi/platform_profile.c
> @@ -188,32 +188,26 @@ int platform_profile_register(struct platform_profile_handler *pprof)
>   		return -EINVAL;
>   	}
>
> -	mutex_lock(&profile_lock);
> +	guard(mutex)(&profile_lock);
>   	/* We can only have one active profile */
> -	if (cur_profile) {
> -		mutex_unlock(&profile_lock);
> +	if (cur_profile)
>   		return -EEXIST;
> -	}
>
>   	err = sysfs_create_group(acpi_kobj, &platform_profile_group);
> -	if (err) {
> -		mutex_unlock(&profile_lock);
> +	if (err)
>   		return err;
> -	}
>
>   	cur_profile = pprof;
> -	mutex_unlock(&profile_lock);
>   	return 0;
>   }
>   EXPORT_SYMBOL_GPL(platform_profile_register);
>
>   int platform_profile_remove(struct platform_profile_handler *pprof)
>   {
> -	sysfs_remove_group(acpi_kobj, &platform_profile_group);
> +	guard(mutex)(&profile_lock);
>
> -	mutex_lock(&profile_lock);
> +	sysfs_remove_group(acpi_kobj, &platform_profile_group);
>   	cur_profile = NULL;
> -	mutex_unlock(&profile_lock);
>   	return 0;
>   }
>   EXPORT_SYMBOL_GPL(platform_profile_remove);