[PATCH v2 1/1] ACPI: LPSS: Remove AudioDSP related ID

[PATCH v2 1/1] ACPI: LPSS: Remove AudioDSP related ID

[Andy Shevchenko]

The AudioDSP drivers are in control for all functions of the hardware
they have (they are multi-functional devices). The LPSS driver prepares
for enumeration only single devices, such as DMA, UART, SPI, I²C. Hence
the registration of AudioDSP should not be covered. Moreover, the very
same ACPI _HID has been added by the catpt driver a few years ago.

And even more serious issue with this, is that the register window at
offset 0x800 is actually D-SRAM0 in case of AudioDSP and writing to it
is a data corruption.

That all being said, remove the AudioDSP ID from the LPSS driver,
where it doesn't belong to.

Fixes: c2f8783fa2d0 ("ASoC: Intel: Add common SST driver loader on ACPI systems")
Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>
Tested-by: Cezary Rojewski <cezary.rojewski@intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---

v2: fixed Fixes (Cezary), added tags (Cezary)

 drivers/acpi/x86/lpss.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/acpi/x86/lpss.c b/drivers/acpi/x86/lpss.c
index 258440b899a9..6daa6372f980 100644
--- a/drivers/acpi/x86/lpss.c
+++ b/drivers/acpi/x86/lpss.c
@@ -387,9 +387,6 @@ static const struct acpi_device_id acpi_lpss_device_ids[] = {
 	{ "INT3435", LPSS_ADDR(lpt_uart_dev_desc) },
 	{ "INT3436", LPSS_ADDR(lpt_sdio_dev_desc) },
 
-	/* Wildcat Point LPSS devices */
-	{ "INT3438", LPSS_ADDR(lpt_spi_dev_desc) },
-
 	{ }
 };
 
-- 
2.47.2

Re: [PATCH v2 1/1] ACPI: LPSS: Remove AudioDSP related ID

[Rafael J. Wysocki]

On Thu, Jun 26, 2025 at 3:26 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> The AudioDSP drivers are in control for all functions of the hardware
> they have (they are multi-functional devices). The LPSS driver prepares
> for enumeration only single devices, such as DMA, UART, SPI, I²C. Hence
> the registration of AudioDSP should not be covered. Moreover, the very
> same ACPI _HID has been added by the catpt driver a few years ago.
>
> And even more serious issue with this, is that the register window at
> offset 0x800 is actually D-SRAM0 in case of AudioDSP and writing to it
> is a data corruption.
>
> That all being said, remove the AudioDSP ID from the LPSS driver,
> where it doesn't belong to.
>
> Fixes: c2f8783fa2d0 ("ASoC: Intel: Add common SST driver loader on ACPI systems")
> Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>
> Tested-by: Cezary Rojewski <cezary.rojewski@intel.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>
> v2: fixed Fixes (Cezary), added tags (Cezary)
>
>  drivers/acpi/x86/lpss.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/drivers/acpi/x86/lpss.c b/drivers/acpi/x86/lpss.c
> index 258440b899a9..6daa6372f980 100644
> --- a/drivers/acpi/x86/lpss.c
> +++ b/drivers/acpi/x86/lpss.c
> @@ -387,9 +387,6 @@ static const struct acpi_device_id acpi_lpss_device_ids[] = {
>         { "INT3435", LPSS_ADDR(lpt_uart_dev_desc) },
>         { "INT3436", LPSS_ADDR(lpt_sdio_dev_desc) },
>
> -       /* Wildcat Point LPSS devices */
> -       { "INT3438", LPSS_ADDR(lpt_spi_dev_desc) },
> -
>         { }
>  };
>
> --

Applied as 6.17 material, thanks!