From: Andrew Jones <ajones@ventanamicro.com>
To: Sunil V L <sunilvl@ventanamicro.com>
Cc: linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
linux-acpi@vger.kernel.org, iommu@lists.linux.dev,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>,
Tomasz Jeznach <tjeznach@rivosinc.com>,
Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Anup Patel <apatel@ventanamicro.com>,
Atish Patra <atishp@rivosinc.com>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>
Subject: Re: [PATCH v3 2/3] ACPI: scan: Add support for RISC-V in acpi_iommu_configure_id()
Date: Mon, 30 Jun 2025 10:02:53 +0200 [thread overview]
Message-ID: <20250630-c479c6607cf8c1430f11336f@orel> (raw)
In-Reply-To: <20250630034803.1611262-3-sunilvl@ventanamicro.com>
On Mon, Jun 30, 2025 at 09:18:02AM +0530, Sunil V L wrote:
> acpi_iommu_configure_id() currently supports only IORT (ARM) and VIOT.
> Add support for RISC-V as well.
>
> Signed-off-by: Sunil V L <sunilvl@ventanamicro.com>
> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
> drivers/acpi/scan.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c
> index fb1fe9f3b1a3..70f57d58fd61 100644
> --- a/drivers/acpi/scan.c
> +++ b/drivers/acpi/scan.c
> @@ -11,6 +11,7 @@
> #include <linux/kernel.h>
> #include <linux/acpi.h>
> #include <linux/acpi_iort.h>
> +#include <linux/acpi_rimt.h>
> #include <linux/acpi_viot.h>
> #include <linux/iommu.h>
> #include <linux/signal.h>
> @@ -1628,8 +1629,12 @@ static int acpi_iommu_configure_id(struct device *dev, const u32 *id_in)
> }
>
> err = iort_iommu_configure_id(dev, id_in);
> - if (err && err != -EPROBE_DEFER)
> - err = viot_iommu_configure(dev);
> + if (err && err != -EPROBE_DEFER) {
> + err = rimt_iommu_configure_id(dev, id_in);
> + if (err && err != -EPROBE_DEFER)
> + err = viot_iommu_configure(dev);
> + }
This can just be
err = iort_iommu_configure_id(dev, id_in);
if (err...
err = rimt_iommu_configure_id(dev, id_in);
if (err...
err = viot_iommu_configure(dev);
Thanks,
drew
> +
> mutex_unlock(&iommu_probe_device_lock);
>
> return err;
> --
> 2.43.0
>
next prev parent reply other threads:[~2025-06-30 8:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-30 3:48 [PATCH v3 0/3] RISC-V: Add ACPI support for IOMMU Sunil V L
2025-06-30 3:48 ` [PATCH v3 1/3] ACPI: RISC-V: Add support for RIMT Sunil V L
2025-06-30 7:55 ` Andrew Jones
2025-07-01 3:47 ` Sunil V L
2025-06-30 3:48 ` [PATCH v3 2/3] ACPI: scan: Add support for RISC-V in acpi_iommu_configure_id() Sunil V L
2025-06-30 8:02 ` Andrew Jones [this message]
2025-07-01 3:33 ` Sunil V L
2025-06-30 3:48 ` [PATCH v3 3/3] iommu/riscv: Add ACPI support Sunil V L
2025-06-30 8:48 ` Andrew Jones
2025-07-13 11:47 ` Will Deacon
2025-06-30 3:51 ` [PATCH v3 0/3] RISC-V: Add ACPI support for IOMMU Sunil V L
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250630-c479c6607cf8c1430f11336f@orel \
--to=ajones@ventanamicro.com \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=apatel@ventanamicro.com \
--cc=atishp@rivosinc.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
--cc=robin.murphy@arm.com \
--cc=sunilvl@ventanamicro.com \
--cc=tjeznach@rivosinc.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox