Linux ACPI
 help / color / mirror / Atom feed
* [PATCH v2] ACPI: FAN: Update fps count debug print
@ 2025-07-05 11:00 Sumeet Pawnikar
  2025-07-07 16:43 ` Rafael J. Wysocki
  0 siblings, 1 reply; 2+ messages in thread
From: Sumeet Pawnikar @ 2025-07-05 11:00 UTC (permalink / raw)
  To: rafael, linux-acpi; +Cc: lenb, linux-kernel, linux-pm, sumeet4linux

Update invalid control value returned debug print with
appropriate message as no matching fps control value
for checking fan fps count condition.

Signed-off-by: Sumeet Pawnikar <sumeet4linux@gmail.com>
---
v1->v2: Addressed review comment received from Rafael Wysocki
        to update the debug message appropriately.
---
 drivers/acpi/fan_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/fan_core.c b/drivers/acpi/fan_core.c
index 8ad12ad3aaaf..095502086b41 100644
--- a/drivers/acpi/fan_core.c
+++ b/drivers/acpi/fan_core.c
@@ -102,7 +102,7 @@ static int fan_get_state_acpi4(struct acpi_device *device, unsigned long *state)
 			break;
 	}
 	if (i == fan->fps_count) {
-		dev_dbg(&device->dev, "Invalid control value returned\n");
+		dev_dbg(&device->dev, "No matching fps control value\n");
 		return -EINVAL;
 	}
 
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] ACPI: FAN: Update fps count debug print
  2025-07-05 11:00 [PATCH v2] ACPI: FAN: Update fps count debug print Sumeet Pawnikar
@ 2025-07-07 16:43 ` Rafael J. Wysocki
  0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2025-07-07 16:43 UTC (permalink / raw)
  To: Sumeet Pawnikar; +Cc: rafael, linux-acpi, lenb, linux-kernel, linux-pm

On Sat, Jul 5, 2025 at 1:00 PM Sumeet Pawnikar <sumeet4linux@gmail.com> wrote:
>
> Update invalid control value returned debug print with
> appropriate message as no matching fps control value
> for checking fan fps count condition.
>
> Signed-off-by: Sumeet Pawnikar <sumeet4linux@gmail.com>
> ---
> v1->v2: Addressed review comment received from Rafael Wysocki
>         to update the debug message appropriately.
> ---
>  drivers/acpi/fan_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/fan_core.c b/drivers/acpi/fan_core.c
> index 8ad12ad3aaaf..095502086b41 100644
> --- a/drivers/acpi/fan_core.c
> +++ b/drivers/acpi/fan_core.c
> @@ -102,7 +102,7 @@ static int fan_get_state_acpi4(struct acpi_device *device, unsigned long *state)
>                         break;
>         }
>         if (i == fan->fps_count) {
> -               dev_dbg(&device->dev, "Invalid control value returned\n");
> +               dev_dbg(&device->dev, "No matching fps control value\n");
>                 return -EINVAL;
>         }
>
> --

Applied as 6.17 material with edited subject, thanks!

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-07-07 16:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-05 11:00 [PATCH v2] ACPI: FAN: Update fps count debug print Sumeet Pawnikar
2025-07-07 16:43 ` Rafael J. Wysocki

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox