* [rafael-pm:bleeding-edge 9/22] drivers/platform/x86/hp/hp-wmi.c:1057:16: error: implicit declaration of function 'devm_battery_hook_register'; did you mean 'acpi_battery_hook_register'?
@ 2026-11-11 10:46 kernel test robot
2026-11-11 11:18 ` Zhongqiu Han
0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2026-11-11 10:46 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: oe-kbuild-all, linux-acpi, linux-pm
tree: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git bleeding-edge
head: 51bafe2e7302403a43ba45415bf9a268a7fcaa05
commit: fafe4f5166bc3d43e28967efb9ea82b1f456b798 [9/22] Merge branch 'acpi-battery' into bleeding-edge
config: x86_64-randconfig-2003-20261111 (https://download.01.org/0day-ci/archive/20261111/202611111143.CWKE7ewK-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261111/202611111143.CWKE7ewK-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202611111143.CWKE7ewK-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/platform/x86/hp/hp-wmi.c: In function 'hp_wmi_charge_control_setup':
>> drivers/platform/x86/hp/hp-wmi.c:1057:16: error: implicit declaration of function 'devm_battery_hook_register'; did you mean 'acpi_battery_hook_register'? [-Wimplicit-function-declaration]
1057 | return devm_battery_hook_register(dev, &hp_wmi_charge_battery_hook);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
| acpi_battery_hook_register
vim +1057 drivers/platform/x86/hp/hp-wmi.c
929433336e0a6e Shang En Sim 2026-09-30 1033
929433336e0a6e Shang En Sim 2026-09-30 1034 static int __init hp_wmi_charge_control_setup(struct device *dev)
929433336e0a6e Shang En Sim 2026-09-30 1035 {
929433336e0a6e Shang En Sim 2026-09-30 1036 enum power_supply_charge_behaviour behaviour;
929433336e0a6e Shang En Sim 2026-09-30 1037 int ret;
929433336e0a6e Shang En Sim 2026-09-30 1038
929433336e0a6e Shang En Sim 2026-09-30 1039 if (!dmi_check_system(hp_wmi_charge_control_quirks))
929433336e0a6e Shang En Sim 2026-09-30 1040 return 0;
929433336e0a6e Shang En Sim 2026-09-30 1041
929433336e0a6e Shang En Sim 2026-09-30 1042 /*
929433336e0a6e Shang En Sim 2026-09-30 1043 * Firmware retains inhibit across reboot, so seed from GBCO rather
929433336e0a6e Shang En Sim 2026-09-30 1044 * than assuming auto.
929433336e0a6e Shang En Sim 2026-09-30 1045 */
929433336e0a6e Shang En Sim 2026-09-30 1046 ret = hp_wmi_charge_mode_read();
929433336e0a6e Shang En Sim 2026-09-30 1047 if (ret < 0)
929433336e0a6e Shang En Sim 2026-09-30 1048 return 0;
929433336e0a6e Shang En Sim 2026-09-30 1049
929433336e0a6e Shang En Sim 2026-09-30 1050 ret = hp_wmi_charge_mode_to_behaviour(ret, &behaviour);
929433336e0a6e Shang En Sim 2026-09-30 1051 if (ret)
929433336e0a6e Shang En Sim 2026-09-30 1052 return 0;
929433336e0a6e Shang En Sim 2026-09-30 1053
929433336e0a6e Shang En Sim 2026-09-30 1054 scoped_guard(mutex, &hp_wmi_charge_lock)
929433336e0a6e Shang En Sim 2026-09-30 1055 hp_wmi_charge_behaviour = behaviour;
929433336e0a6e Shang En Sim 2026-09-30 1056
929433336e0a6e Shang En Sim 2026-09-30 @1057 return devm_battery_hook_register(dev, &hp_wmi_charge_battery_hook);
929433336e0a6e Shang En Sim 2026-09-30 1058 }
929433336e0a6e Shang En Sim 2026-09-30 1059 #else
929433336e0a6e Shang En Sim 2026-09-30 1060 static int __init hp_wmi_charge_control_setup(struct device *dev)
929433336e0a6e Shang En Sim 2026-09-30 1061 {
929433336e0a6e Shang En Sim 2026-09-30 1062 return 0;
929433336e0a6e Shang En Sim 2026-09-30 1063 }
929433336e0a6e Shang En Sim 2026-09-30 1064 #endif
929433336e0a6e Shang En Sim 2026-09-30 1065
:::::: The code at line 1057 was first introduced by commit
:::::: 929433336e0a6e5014af7b8849f369712d2c8964 platform/x86: hp-wmi: add charge_behaviour support for Spectre 8C15/8C17
:::::: TO: Shang En Sim <sim@shangen.org>
:::::: CC: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [rafael-pm:bleeding-edge 9/22] drivers/platform/x86/hp/hp-wmi.c:1057:16: error: implicit declaration of function 'devm_battery_hook_register'; did you mean 'acpi_battery_hook_register'?
2026-11-11 10:46 [rafael-pm:bleeding-edge 9/22] drivers/platform/x86/hp/hp-wmi.c:1057:16: error: implicit declaration of function 'devm_battery_hook_register'; did you mean 'acpi_battery_hook_register'? kernel test robot
@ 2026-11-11 11:18 ` Zhongqiu Han
0 siblings, 0 replies; 2+ messages in thread
From: Zhongqiu Han @ 2026-11-11 11:18 UTC (permalink / raw)
To: kernel test robot, Rafael J. Wysocki, Rafael J. Wysocki
Cc: oe-kbuild-all, linux-acpi, linux-pm, Zhongqiu Han
On 11/11/2026 6:46 PM, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git bleeding-edge
> head: 51bafe2e7302403a43ba45415bf9a268a7fcaa05
> commit: fafe4f5166bc3d43e28967efb9ea82b1f456b798 [9/22] Merge branch 'acpi-battery' into bleeding-edge
> config: x86_64-randconfig-2003-20261111 (https://download.01.org/0day-ci/archive/20261111/202611111143.CWKE7ewK-lkp@intel.com/config)
> compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261111/202611111143.CWKE7ewK-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202611111143.CWKE7ewK-lkp@intel.com/
>
Addressed the same issue on
https://lore.kernel.org/all/cbd2aee7-95ae-4d30-8458-b7da2910867f@oss.qualcomm.com/
> All errors (new ones prefixed by >>):
>
> drivers/platform/x86/hp/hp-wmi.c: In function 'hp_wmi_charge_control_setup':
>>> drivers/platform/x86/hp/hp-wmi.c:1057:16: error: implicit declaration of function 'devm_battery_hook_register'; did you mean 'acpi_battery_hook_register'? [-Wimplicit-function-declaration]
> 1057 | return devm_battery_hook_register(dev, &hp_wmi_charge_battery_hook);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~
> | acpi_battery_hook_register
>
>
> vim +1057 drivers/platform/x86/hp/hp-wmi.c
>
> 929433336e0a6e Shang En Sim 2026-09-30 1033
> 929433336e0a6e Shang En Sim 2026-09-30 1034 static int __init hp_wmi_charge_control_setup(struct device *dev)
> 929433336e0a6e Shang En Sim 2026-09-30 1035 {
> 929433336e0a6e Shang En Sim 2026-09-30 1036 enum power_supply_charge_behaviour behaviour;
> 929433336e0a6e Shang En Sim 2026-09-30 1037 int ret;
> 929433336e0a6e Shang En Sim 2026-09-30 1038
> 929433336e0a6e Shang En Sim 2026-09-30 1039 if (!dmi_check_system(hp_wmi_charge_control_quirks))
> 929433336e0a6e Shang En Sim 2026-09-30 1040 return 0;
> 929433336e0a6e Shang En Sim 2026-09-30 1041
> 929433336e0a6e Shang En Sim 2026-09-30 1042 /*
> 929433336e0a6e Shang En Sim 2026-09-30 1043 * Firmware retains inhibit across reboot, so seed from GBCO rather
> 929433336e0a6e Shang En Sim 2026-09-30 1044 * than assuming auto.
> 929433336e0a6e Shang En Sim 2026-09-30 1045 */
> 929433336e0a6e Shang En Sim 2026-09-30 1046 ret = hp_wmi_charge_mode_read();
> 929433336e0a6e Shang En Sim 2026-09-30 1047 if (ret < 0)
> 929433336e0a6e Shang En Sim 2026-09-30 1048 return 0;
> 929433336e0a6e Shang En Sim 2026-09-30 1049
> 929433336e0a6e Shang En Sim 2026-09-30 1050 ret = hp_wmi_charge_mode_to_behaviour(ret, &behaviour);
> 929433336e0a6e Shang En Sim 2026-09-30 1051 if (ret)
> 929433336e0a6e Shang En Sim 2026-09-30 1052 return 0;
> 929433336e0a6e Shang En Sim 2026-09-30 1053
> 929433336e0a6e Shang En Sim 2026-09-30 1054 scoped_guard(mutex, &hp_wmi_charge_lock)
> 929433336e0a6e Shang En Sim 2026-09-30 1055 hp_wmi_charge_behaviour = behaviour;
> 929433336e0a6e Shang En Sim 2026-09-30 1056
> 929433336e0a6e Shang En Sim 2026-09-30 @1057 return devm_battery_hook_register(dev, &hp_wmi_charge_battery_hook);
> 929433336e0a6e Shang En Sim 2026-09-30 1058 }
> 929433336e0a6e Shang En Sim 2026-09-30 1059 #else
> 929433336e0a6e Shang En Sim 2026-09-30 1060 static int __init hp_wmi_charge_control_setup(struct device *dev)
> 929433336e0a6e Shang En Sim 2026-09-30 1061 {
> 929433336e0a6e Shang En Sim 2026-09-30 1062 return 0;
> 929433336e0a6e Shang En Sim 2026-09-30 1063 }
> 929433336e0a6e Shang En Sim 2026-09-30 1064 #endif
> 929433336e0a6e Shang En Sim 2026-09-30 1065
>
> :::::: The code at line 1057 was first introduced by commit
> :::::: 929433336e0a6e5014af7b8849f369712d2c8964 platform/x86: hp-wmi: add charge_behaviour support for Spectre 8C15/8C17
>
> :::::: TO: Shang En Sim <sim@shangen.org>
> :::::: CC: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki
>
--
Thx and BRs,
Zhongqiu Han
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-11 11:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-11 10:46 [rafael-pm:bleeding-edge 9/22] drivers/platform/x86/hp/hp-wmi.c:1057:16: error: implicit declaration of function 'devm_battery_hook_register'; did you mean 'acpi_battery_hook_register'? kernel test robot
2026-11-11 11:18 ` Zhongqiu Han
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox