From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Linux ACPI <linux-acpi@vger.kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH v2 0/6] ACPI: scan: MIPI DiSco for Imaging support
Date: Fri, 20 Oct 2023 16:33:56 +0200 [thread overview]
Message-ID: <2187487.irdbgypaU6@kreacher> (raw)
Hi Folks,
This is a new revision of
https://lore.kernel.org/linux-acpi/13276375.uLZWGnKmhe@kreacher/
which was reported to have issues and it took time to revisit it.
> The main points from the original cover letter are still valid:
>
> The general idea is the same - CSI-2 resource descriptors, introduced in
> ACPI 6.4 and defined by
>
> https://uefi.org/specs/ACPI/6.5/06_Device_Configuration.html#camera-serial-i
> nterface-csi-2-connection-resource-descriptor
>
> are found and used for creating a set of software nodes that represent the
> CSI-2 connection graph.
>
> These software nodes need to be available before any scan handlers or ACPI
> drivers are bound to any struct acpi_device objects, so all of that is done
> at the early stage of ACPI device enumeration, but unnecessary ACPI
> namespace walks are avoided.
>
> The CSI-2 software nodes are populated with data extracted from the CSI-2
> resource descriptors themselves and from device properties defined by the
> MIPI DiSco for Imaging specification (see
> https://www.mipi.org/specifications/mipi-disco-imaging).
>
> Patches [4,6/6] come from the original series directly, but the other
> patches have been changes substantially, so I've decided to re-start patch
> series versioning from scratch.
The v2 addresses at least 3 issues found in the v1 by code inspection:
* A port_count field incrementation was missing in acpi_mipi_scan_crs_csi2(),
so its value for all of the devices having CSI2 resources in _CRS was always
1 (and it should be equal to the number of valid CSI2 connection resources).
* Some acpi_mipi_crs_csi2_list members could be freed prematurely, so they were
inaccessible when extract_crs_csi2_conn_info() attempted to access them.
* A check of remote_swnodes() against NULL was missing, which could result in
a crash in a case when the swnodes memory could not be allocated for some
acpi_mipi_crs_csi2_list entries.
Apart from that, it rearranges the code somewhat to make it easier to follow
and to avoid premature freeing of memory in it in general and the new file
added by it is now called mipi-di.c (instead of mipi-disco-imaging.c) for
compactness.
The series is based on current linux-next.
Thanks!
next reply other threads:[~2023-10-20 14:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-20 14:33 Rafael J. Wysocki [this message]
2023-10-20 14:35 ` [PATCH v2 1/6] ACPI: property: Support using strings in reference properties Rafael J. Wysocki
2023-10-20 14:36 ` [PATCH v2 2/6] ACPI: scan: Extract CSI-2 connection graph from _CRS Rafael J. Wysocki
2023-10-31 8:47 ` Sakari Ailus
2023-10-31 13:36 ` Rafael J. Wysocki
2023-10-20 14:37 ` [PATCH v2 3/6] ACPI: scan: Extract _CRS CSI-2 connection information into swnodes Rafael J. Wysocki
2023-10-20 14:38 ` [PATCH v2 4/6] device property: Add SOFTWARE_NODE() macro for defining software nodes Rafael J. Wysocki
2023-10-20 14:39 ` [PATCH v2 5/6] ACPI: scan: Extract MIPI DiSco for Imaging data into swnodes Rafael J. Wysocki
2023-10-31 8:58 ` Sakari Ailus
2023-10-31 13:46 ` Rafael J. Wysocki
2023-10-31 14:00 ` Sakari Ailus
2023-10-31 15:19 ` Rafael J. Wysocki
2023-10-20 14:40 ` [PATCH v2 6/6] ACPI: property: Dig "rotation" property for devices with CSI2 _CRS Rafael J. Wysocki
2023-10-31 8:45 ` [PATCH v2 0/6] ACPI: scan: MIPI DiSco for Imaging support Sakari Ailus
2023-10-31 13:21 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2187487.irdbgypaU6@kreacher \
--to=rjw@rjwysocki.net \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox