* [PATCH] libnvdimm: fix smart data retrieval
@ 2016-04-07 0:53 Dan Williams
2016-04-07 8:22 ` Johannes Thumshirn
0 siblings, 1 reply; 2+ messages in thread
From: Dan Williams @ 2016-04-07 0:53 UTC (permalink / raw)
To: linux-nvdimm; +Cc: linux-acpi, linux-kernel, stable
It appears that smart data retrieval has been broken the since the
initial implementation. Fix the payload size to be 128-bytes per the
specification.
Cc: <stable@vger.kernel.org>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---
drivers/nvdimm/bus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvdimm/bus.c b/drivers/nvdimm/bus.c
index fc82743aefb6..19f822d7f652 100644
--- a/drivers/nvdimm/bus.c
+++ b/drivers/nvdimm/bus.c
@@ -407,7 +407,7 @@ static const struct nd_cmd_desc __nd_cmd_dimm_descs[] = {
[ND_CMD_IMPLEMENTED] = { },
[ND_CMD_SMART] = {
.out_num = 2,
- .out_sizes = { 4, 8, },
+ .out_sizes = { 4, 128, },
},
[ND_CMD_SMART_THRESHOLD] = {
.out_num = 2,
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] libnvdimm: fix smart data retrieval
2016-04-07 0:53 [PATCH] libnvdimm: fix smart data retrieval Dan Williams
@ 2016-04-07 8:22 ` Johannes Thumshirn
0 siblings, 0 replies; 2+ messages in thread
From: Johannes Thumshirn @ 2016-04-07 8:22 UTC (permalink / raw)
To: linux-nvdimm; +Cc: Dan Williams, linux-acpi, linux-kernel, stable
On Mittwoch, 6. April 2016 17:53:44 CEST Dan Williams wrote:
> It appears that smart data retrieval has been broken the since the
> initial implementation. Fix the payload size to be 128-bytes per the
> specification.
>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> ---
Good catch,
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-04-07 8:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-07 0:53 [PATCH] libnvdimm: fix smart data retrieval Dan Williams
2016-04-07 8:22 ` Johannes Thumshirn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox