[PATCH -next] ACPI / CPPC: Make some symbols static

[PATCH -next] ACPI / CPPC: Make some symbols static

[Zou Wei]

Fix the following sparse warnings:

drivers/acpi/cppc_acpi.c:353:20: warning: symbol 'cppc_mbox_cl' was not declared. Should it be static?
drivers/acpi/cppc_acpi.c:600:5: warning: symbol 'pcc_data_alloc' was not declared. Should it be static?

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
 drivers/acpi/cppc_acpi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c
index 8b2e89c..f818400 100644
--- a/drivers/acpi/cppc_acpi.c
+++ b/drivers/acpi/cppc_acpi.c
@@ -350,7 +350,7 @@ static void cppc_chan_tx_done(struct mbox_client *cl, void *msg, int ret)
 				*(u16 *)msg, ret);
 }
 
-struct mbox_client cppc_mbox_cl = {
+static struct mbox_client cppc_mbox_cl = {
 	.tx_done = cppc_chan_tx_done,
 	.knows_txdone = true,
 };
@@ -597,7 +597,7 @@ bool __weak cpc_ffh_supported(void)
  *
  * Return: 0 for success, errno for failure
  */
-int pcc_data_alloc(int pcc_ss_id)
+static int pcc_data_alloc(int pcc_ss_id)
 {
 	if (pcc_ss_id < 0 || pcc_ss_id >= MAX_PCC_SUBSPACES)
 		return -EINVAL;
-- 
2.6.2

Re: [PATCH -next] ACPI / CPPC: Make some symbols static

[Rafael J. Wysocki]

On Thursday, April 23, 2020 9:21:58 AM CEST Zou Wei wrote:
> Fix the following sparse warnings:
> 
> drivers/acpi/cppc_acpi.c:353:20: warning: symbol 'cppc_mbox_cl' was not declared. Should it be static?
> drivers/acpi/cppc_acpi.c:600:5: warning: symbol 'pcc_data_alloc' was not declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
> ---
>  drivers/acpi/cppc_acpi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c
> index 8b2e89c..f818400 100644
> --- a/drivers/acpi/cppc_acpi.c
> +++ b/drivers/acpi/cppc_acpi.c
> @@ -350,7 +350,7 @@ static void cppc_chan_tx_done(struct mbox_client *cl, void *msg, int ret)
>  				*(u16 *)msg, ret);
>  }
>  
> -struct mbox_client cppc_mbox_cl = {
> +static struct mbox_client cppc_mbox_cl = {
>  	.tx_done = cppc_chan_tx_done,
>  	.knows_txdone = true,
>  };
> @@ -597,7 +597,7 @@ bool __weak cpc_ffh_supported(void)
>   *
>   * Return: 0 for success, errno for failure
>   */
> -int pcc_data_alloc(int pcc_ss_id)
> +static int pcc_data_alloc(int pcc_ss_id)
>  {
>  	if (pcc_ss_id < 0 || pcc_ss_id >= MAX_PCC_SUBSPACES)
>  		return -EINVAL;
> 

Applied as 5.8-candidate material, thanks!