From: Muhammad Usama Anjum <usama.anjum@collabora.com>
To: Tzung-Bi Shih <tzungbi@kernel.org>
Cc: Muhammad Usama Anjum <usama.anjum@collabora.com>,
bleung@chromium.org, groeck@chromium.org, rafael@kernel.org,
lenb@kernel.org, chrome-platform@lists.linux.dev,
linux-acpi@vger.kernel.org, guillaume.tucker@collabora.com,
denys.f@collabora.com, ricardo.canuelo@collabora.com
Subject: Re: [PATCH] platform/chrome: chromeos_acpi: use official HID GOOG0016
Date: Fri, 28 Jul 2023 12:43:57 +0500 [thread overview]
Message-ID: <331b4f97-388c-046a-d8b4-dd5bd45c9557@collabora.com> (raw)
In-Reply-To: <ZMNg6NYSgTf3mIRJ@google.com>
On 7/28/23 11:32 AM, Tzung-Bi Shih wrote:
> On Fri, Jul 28, 2023 at 10:59:22AM +0500, Muhammad Usama Anjum wrote:
>> On 7/28/23 6:42 AM, Tzung-Bi Shih wrote:
>>> Use official HID GOOG0016 for ChromeOS ACPI (see [1]).
>>>
>>> [1]: https://crrev.com/c/2266713
>>>
>>> Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
>>> ---
>>> AFAIK, there has no ChromeOS devices using the driver yet. Instead, they
>>> still stick to some downstream implementation. IOW, I guess we are safe
>>> to just replace the PNP ID.
>> GOOG0016 got introduced in newer firmware. Older firmware will still have
>> only GGL0001 id. Lets keep both IDs otherwise the updated driver will not
>> work on older chromebooks. This can be easily achieved by keeping both IDs
>> in chromeos_device_ids.
>
> Thanks for the review. I overlooked the case. Will fix it in next version.
>
> So if I'm looking for the path, whether it bases on "GOOG0016" or "GGL0001",
> it actually depends on what firmware the system has?
So kernel will the match the firware's ID with list of IDs defined there.
--
BR,
Muhammad Usama Anjum
prev parent reply other threads:[~2023-07-28 7:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-28 1:42 [PATCH] platform/chrome: chromeos_acpi: use official HID GOOG0016 Tzung-Bi Shih
2023-07-28 5:59 ` Muhammad Usama Anjum
2023-07-28 6:32 ` Tzung-Bi Shih
2023-07-28 7:43 ` Muhammad Usama Anjum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=331b4f97-388c-046a-d8b4-dd5bd45c9557@collabora.com \
--to=usama.anjum@collabora.com \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=denys.f@collabora.com \
--cc=groeck@chromium.org \
--cc=guillaume.tucker@collabora.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=ricardo.canuelo@collabora.com \
--cc=tzungbi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox