From: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
To: linux acpi <linux-acpi@vger.kernel.org>
Cc: Alexey Starikovskiy <astarikovskiy@suse.de>
Subject: [RESEND] [PATCH 2/3] ACPI: battery drivers should call power_supply_changed()
Date: Tue, 30 Jun 2009 15:36:16 +0100 [thread overview]
Message-ID: <4A4A22E0.6050400@tuffmail.co.uk> (raw)
In-Reply-To: <4A4A2299.8060401@tuffmail.co.uk>
Calling kobject_uevent() directly is a layering violation. In
particular, it means we'll miss updating the generic LED trigger.
Signed-off-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
CC: Alexey Starikovskiy <astarikovskiy@suse.de>
---
drivers/acpi/battery.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c
index 908edce..7d31a23 100644
--- a/drivers/acpi/battery.c
+++ b/drivers/acpi/battery.c
@@ -811,7 +811,7 @@ static void acpi_battery_notify(struct acpi_device *device, u32 event)
#ifdef CONFIG_ACPI_SYSFS_POWER
/* acpi_batter_update could remove power_supply object */
if (battery->bat.dev)
- kobject_uevent(&battery->bat.dev->kobj, KOBJ_CHANGE);
+ power_supply_changed(&battery->bat);
#endif
}
--
1.6.3.2
next prev parent reply other threads:[~2009-06-30 14:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-30 14:30 [RESEND] [PATCH 1/3] ACPI: battery: Fix CONFIG_ACPI_SYSFS_POWER=n Alan Jenkins
2009-06-30 14:35 ` Alan Jenkins
2009-06-30 14:36 ` Alan Jenkins [this message]
2009-06-30 14:37 ` [RESEND] [PATCH 3/3] ACPI: battery: register power_supply subdevice even when battery not present Alan Jenkins
2009-09-07 16:06 ` [RESEND] [PATCH 1/3] ACPI: battery: Fix CONFIG_ACPI_SYSFS_POWER=n Maxim Levitsky
2009-09-09 17:22 ` Alan Jenkins
2009-09-09 21:21 ` Maxim Levitsky
2009-09-10 11:11 ` Alan Jenkins
2009-09-11 2:34 ` Maxim Levitsky
2009-12-10 4:49 ` Len Brown
2009-12-11 10:50 ` Alan Jenkins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A4A22E0.6050400@tuffmail.co.uk \
--to=alan-jenkins@tuffmail.co.uk \
--cc=astarikovskiy@suse.de \
--cc=linux-acpi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox