Linux ACPI
 help / color / mirror / Atom feed
From: Maxim Levitsky <maximlevitsky@gmail.com>
To: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
Cc: linux acpi <linux-acpi@vger.kernel.org>,
	Alexey Starikovskiy <alexey.y.starikovskiy@linux.intel.com>
Subject: Re: [RESEND] [PATCH 1/3] ACPI: battery: Fix CONFIG_ACPI_SYSFS_POWER=n
Date: Thu, 10 Sep 2009 00:21:11 +0300	[thread overview]
Message-ID: <1252531271.4174.5.camel@maxim-laptop> (raw)
In-Reply-To: <4AA7E438.4070905@tuffmail.co.uk>

On Wed, 2009-09-09 at 18:22 +0100, Alan Jenkins wrote: 
> Maxim Levitsky wrote:
> > Hi,
> >
> > So this is newer version of this patchset.
> > When this will be merged?
> >
> >
> > Last patch doesn't apply, seems that parts of yours patch were applied.
> > I applied it manually.
> >   
> > Will soon test.
> >
> >
> > Best regards,
> > 	Maxim Levitsky
> >   
> 
> I will submit "To: len" next time round.
> 
> You're right, it no longer applies cleanly to acpi-test.  ["patch" is
> happy to apply it and warn about "fuzz", but git-am is more strict.  It
> doesn't look like there's a real conflict.]
I applied it on top of both vanilla and linux-next. Here it really
doesn't apply (with or without 'fuzz')

> 
> I look forward to your results.  Please tell me the diff you end up with
> for the last patch and what tree you applied it on top of.  That way, if
> I add "Tested-by: Maxim..." I can be certain we're talking about the
> same patch :-).
> 
> Thanks!
> Alan

I did that few days ago (applied patch manually, without much thinking)

Unfortunately, resulting kernel oopses if battery is present, and
otherwise, if I plug batter later on, many battery statistics are
missing (probably some locks are held)

I will soon investigate this issue, more deeply.

Best regards,
Maxim Levitsky




  reply	other threads:[~2009-09-09 21:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-30 14:30 [RESEND] [PATCH 1/3] ACPI: battery: Fix CONFIG_ACPI_SYSFS_POWER=n Alan Jenkins
2009-06-30 14:35 ` Alan Jenkins
2009-06-30 14:36   ` [RESEND] [PATCH 2/3] ACPI: battery drivers should call power_supply_changed() Alan Jenkins
2009-06-30 14:37   ` [RESEND] [PATCH 3/3] ACPI: battery: register power_supply subdevice even when battery not present Alan Jenkins
2009-09-07 16:06 ` [RESEND] [PATCH 1/3] ACPI: battery: Fix CONFIG_ACPI_SYSFS_POWER=n Maxim Levitsky
2009-09-09 17:22   ` Alan Jenkins
2009-09-09 21:21     ` Maxim Levitsky [this message]
2009-09-10 11:11       ` Alan Jenkins
2009-09-11  2:34         ` Maxim Levitsky
2009-12-10  4:49         ` Len Brown
2009-12-11 10:50           ` Alan Jenkins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1252531271.4174.5.camel@maxim-laptop \
    --to=maximlevitsky@gmail.com \
    --cc=alan-jenkins@tuffmail.co.uk \
    --cc=alexey.y.starikovskiy@linux.intel.com \
    --cc=linux-acpi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox