Re: [PATCH v1 2/4] ACPI: thermal: Adjust event notification routine

["lihuisong (C)" <lihuisong@huawei.com>]

在 2025/12/10 22:43, Rafael J. Wysocki 写道:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> Adjust acpi_thermal_notify() to cast its "data" argument to a struct
> acpi_thermal pointer istead of a struct acpi_device one, which allows
> the use of acpi_driver_data() to be limited and will facilitate
> subsequent changes.
>
> No intentional functional impact.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
>   drivers/acpi/thermal.c |    9 ++++-----
>   1 file changed, 4 insertions(+), 5 deletions(-)
>
> --- a/drivers/acpi/thermal.c
> +++ b/drivers/acpi/thermal.c
> @@ -670,8 +670,7 @@ static void acpi_thermal_unregister_ther
>   
>   static void acpi_thermal_notify(acpi_handle handle, u32 event, void *data)
>   {
> -	struct acpi_device *device = data;
> -	struct acpi_thermal *tz = acpi_driver_data(device);
> +	struct acpi_thermal *tz = data;
>   
>   	if (!tz)
>   		return;
> @@ -685,8 +684,8 @@ static void acpi_thermal_notify(acpi_han
>   		acpi_thermal_trips_update(tz, event);
>   		break;
>   	default:
> -		acpi_handle_debug(device->handle, "Unsupported event [0x%x]\n",
> -				  event);
> +		acpi_handle_debug(tz->device->handle,
> +				  "Unsupported event [0x%x]\n", event);
>   		break;
>   	}
>   }
> @@ -881,7 +880,7 @@ static int acpi_thermal_add(struct acpi_
>   		acpi_device_bid(device), deci_kelvin_to_celsius(tz->temp_dk));
>   
>   	result = acpi_dev_install_notify_handler(device, ACPI_DEVICE_NOTIFY,
> -						 acpi_thermal_notify, device);
> +						 acpi_thermal_notify, tz);
>   	if (result)
>   		goto flush_wq;
>   
LGTM,
Acked-by: lihuisong@huawei.com
>
>
>