From: "lihuisong (C)" <lihuisong@huawei.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>,
Linux ACPI <linux-acpi@vger.kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>, Armin Wolf <w_armin@gmx.de>,
Hans de Goede <hansg@kernel.org>, <lihuisong@huawei.com>
Subject: Re: [PATCH v1 3/4] ACPI: thermal: Convert the driver to a platform one
Date: Thu, 18 Dec 2025 14:39:25 +0800 [thread overview]
Message-ID: <98caf0d0-92f6-4842-bb49-a1979aed2283@huawei.com> (raw)
In-Reply-To: <2249483.irdbgypaU6@rafael.j.wysocki>
在 2025/12/10 22:43, Rafael J. Wysocki 写道:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> While binding drivers directly to struct acpi_device objects allows
> basic functionality to be provided, at least in the majority of cases,
> there are some problems with it, related to general consistency, sysfs
> layout, power management operation ordering, and code cleanliness.
>
> Overall, it is better to bind drivers to platform devices than to their
> ACPI companions, so convert the ACPI thermal zone driver to a platform
> one.
>
> While this is not expected to alter functionality, it changes sysfs
> layout and so it will be visible to user space.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
I tested this series on my platform.
Yeah, there are some changes, such as a 'wakeup' directory.
But the function is ok. And this change is also ok to 'sensors' tool.
Tested-by: lihuisong@huawei.com
>
>
>
next prev parent reply other threads:[~2025-12-18 6:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-10 14:41 [PATCH v1 0/4] ACPI: thermal: Convert ACPI thermal driver to a platform one Rafael J. Wysocki
2025-12-10 14:42 ` [PATCH v1 1/4] ACPI: scan: Register platform devices for thermal zones Rafael J. Wysocki
2025-12-18 6:28 ` lihuisong (C)
2025-12-10 14:43 ` [PATCH v1 2/4] ACPI: thermal: Adjust event notification routine Rafael J. Wysocki
2025-12-18 6:30 ` lihuisong (C)
2025-12-10 14:43 ` [PATCH v1 3/4] ACPI: thermal: Convert the driver to a platform one Rafael J. Wysocki
2025-12-18 6:39 ` lihuisong (C) [this message]
2025-12-10 14:44 ` [PATCH v1 4/4] ACPI: thermal: Rework system suspend and resume handling Rafael J. Wysocki
2025-12-18 6:48 ` lihuisong (C)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98caf0d0-92f6-4842-bb49-a1979aed2283@huawei.com \
--to=lihuisong@huawei.com \
--cc=hansg@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=w_armin@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox