* [PATCH v4 00/23] gpio: Improvements around device-id arrays
@ 2026-10-27 10:48 Uwe Kleine-König (The Capable Hub)
2026-10-27 10:49 ` [PATCH v4 23/23] gpio: Unify style of various *_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-10-28 13:57 ` [PATCH v4 00/23] gpio: Improvements around device-id arrays Alan Borzeszkowski
0 siblings, 2 replies; 3+ messages in thread
From: Uwe Kleine-König (The Capable Hub) @ 2026-10-27 10:48 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski
Cc: Andy Shevchenko, linux-gpio, linux-kernel, Lixu Zhang,
Sakari Ailus, Broadcom internal kernel review list,
Florian Fainelli, Eugeniy Paltsev, Frank Li, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Imre Kaloz, Conor Dooley,
Valentina Fernandez, Daire McNamara, Daniel Palmer, Romain Perier,
Robert Jarzmik, imx, linux-arm-kernel, linux-riscv, Hoan Tran,
Alan Borzeszkowski, Mika Westerberg, Hans de Goede, Nuno Sá,
linux-hwmon, Matti Vaittinen, Enrico Weigelt, metux IT consult,
Viresh Kumar, virtualization, Yinbo Zhu, Thierry Reding,
Jonathan Hunter, linux-tegra, Geert Uytterhoeven,
AngeloGioacchino Del Regno, Srinivas Neeli, Michal Simek,
linux-aspeed, asahi, linux-mediatek, openbmc, linux-omap,
linux-renesas-soc, linux-unisoc, linux-rockchip, linux-stm32,
Michael Buesch, William Breathitt Gray, Robert Richter,
Andy Shevchenko, linux-acpi
Hello,
the original motivation for this series are the patches that convert the
arrays to use named initializers, see
https://lore.kernel.org/all/cover.1780048925.git.u.kleine-koenig@baylibre.com/
for the idea behind it. Looking left and right a bit while implementing
that, the series grew a bit.
Changes since v3 (available at
https://lore.kernel.org/all/cover.1793030820.git.u.kleine-koenig@baylibre.com):
- Picked up review tags (b4 even found some from v2)
- Add a 2nd MODULE_DEVICE_TABLE(of, ...) in drivers/gpio/gpio-mpc5200.c
(My grep didn't handle >1 driver per file well), noticed by Sashiko
- New patch to use named initializers for auxiliary_device_id arrays
- Fix code style of of_device_id array in drivers/gpio/gpio-grgpio.c
(My script doesn't handle of_device_id::name) and
drivers/gpio/gpio-ppc44x.c (didn't exist yet when I sent v2 and
failed to notice that for v3)
- Fix code style of auxiliary_device_id array in
drivers/gpio/gpio-shared-proxy.c, missed as I didn't have a script
for auxiliary_device_id before.
- Dropped a few broken email addresses from Cc:
Best regards
Uwe
Uwe Kleine-König (The Capable Hub) (23):
gpio: Remove __maybe_unused annotations from acpi_device_id arrays
gpio: fxl6408: Remove __maybe_unused annotations from of_device_id
array
gpio: Drop unused assignment of acpi_device_id driver data
gpio: max7301: Drop unused assignment of spi_device_id driver data
gpio: mmio: Drop unused assignment of platform_device_id driver data
gpio: ljca: Drop unused assignment of auxiliary_device_id driver data
gpio: xgene: Add missing ACPI module annotation
gpio: sodaville: Add missing PCI module annotations
gpio: Add missing OF module annotations
gpio: pxa: Add missing platform module annotations
gpio: pl061: Use empty initializer for amba_id terminator
gpio: Use named initializers for acpi_device_id array
gpio: Use named initializers for auxiliary_device_id arrays
gpio: pcf857x: Use named initializers for of_device_id array
gpio: bd73800: Use named initializers for platform_device_id array
gpio: Use named initializers for spi_device_id array
gpio: virtio: Use a named initializer for virtio_device_id array
gpio: Unify style of acpi_device_id arrays
gpio: Unify style of of_device_id arrays
gpio: max77620: Unify style of platform_device_id array
gpio: Unify style of spi_device_id arrays
gpio: Unify style of pci_device_id arrays
gpio: Unify style of various *_device_id arrays
drivers/gpio/gpio-74x164.c | 4 ++--
drivers/gpio/gpio-adnp.c | 4 ++--
drivers/gpio/gpio-aggregator.c | 2 +-
drivers/gpio/gpio-altera-a10sr.c | 2 +-
drivers/gpio/gpio-altera.c | 4 ++--
drivers/gpio/gpio-amd8111.c | 2 +-
drivers/gpio/gpio-amdpt.c | 8 ++++----
drivers/gpio/gpio-aspeed-sgpio.c | 10 ++++-----
drivers/gpio/gpio-aspeed.c | 10 ++++-----
drivers/gpio/gpio-ath79.c | 2 +-
drivers/gpio/gpio-bcm-kona.c | 1 +
drivers/gpio/gpio-bd73800.c | 4 ++--
drivers/gpio/gpio-blzp1600.c | 4 ++--
drivers/gpio/gpio-brcmstb.c | 2 +-
drivers/gpio/gpio-bt8xx.c | 2 +-
drivers/gpio/gpio-cadence.c | 6 +++---
drivers/gpio/gpio-creg-snps.c | 5 +++--
drivers/gpio/gpio-davinci.c | 8 ++++----
drivers/gpio/gpio-dwapb.c | 14 ++++++-------
drivers/gpio/gpio-elkhartlake.c | 2 +-
drivers/gpio/gpio-em.c | 4 ++--
drivers/gpio/gpio-ep93xx.c | 1 +
drivers/gpio/gpio-ftgpio010.c | 3 ++-
drivers/gpio/gpio-fxl6408.c | 2 +-
drivers/gpio/gpio-graniterapids.c | 4 ++--
drivers/gpio/gpio-grgpio.c | 6 +++---
drivers/gpio/gpio-gw-pld.c | 4 ++--
drivers/gpio/gpio-hisi.c | 6 +++---
drivers/gpio/gpio-hlwd.c | 4 ++--
drivers/gpio/gpio-imx-scu.c | 1 +
drivers/gpio/gpio-ixp4xx.c | 4 ++--
drivers/gpio/gpio-ljca.c | 4 ++--
drivers/gpio/gpio-loongson-64bit.c | 4 ++--
drivers/gpio/gpio-lp3943.c | 2 +-
drivers/gpio/gpio-lpc32xx.c | 4 ++--
drivers/gpio/gpio-ltc4283.c | 2 +-
drivers/gpio/gpio-macsmc.c | 4 ++--
drivers/gpio/gpio-max3191x.c | 12 +++++------
drivers/gpio/gpio-max7301.c | 2 +-
drivers/gpio/gpio-max7360.c | 8 ++++----
drivers/gpio/gpio-max77620.c | 4 ++--
drivers/gpio/gpio-max77759.c | 2 +-
drivers/gpio/gpio-mb86s7x.c | 2 +-
drivers/gpio/gpio-ml-ioh.c | 2 +-
drivers/gpio/gpio-mlxbf.c | 6 +++---
drivers/gpio/gpio-mlxbf2.c | 6 +++---
drivers/gpio/gpio-mlxbf3.c | 4 ++--
drivers/gpio/gpio-mm-lantiq.c | 2 +-
drivers/gpio/gpio-mmio.c | 3 +--
drivers/gpio/gpio-mockup.c | 4 ++--
drivers/gpio/gpio-moxtet.c | 4 ++--
drivers/gpio/gpio-mpc5200.c | 10 +++++----
drivers/gpio/gpio-mpc8xxx.c | 25 +++++++++++-----------
drivers/gpio/gpio-mpfs.c | 1 +
drivers/gpio/gpio-mpsse.c | 3 +--
drivers/gpio/gpio-msc313.c | 1 +
drivers/gpio/gpio-mt7621.c | 2 +-
drivers/gpio/gpio-mvebu.c | 13 ++++++------
drivers/gpio/gpio-mxc.c | 2 +-
drivers/gpio/gpio-mxs.c | 4 ++--
drivers/gpio/gpio-nomadik.c | 7 ++++---
drivers/gpio/gpio-novalake-events.c | 4 ++--
drivers/gpio/gpio-npcm-sgpio.c | 6 +++---
drivers/gpio/gpio-octeon.c | 2 +-
drivers/gpio/gpio-omap.c | 2 +-
drivers/gpio/gpio-palmas.c | 10 ++++-----
drivers/gpio/gpio-pca953x.c | 4 ++--
drivers/gpio/gpio-pca9570.c | 2 +-
drivers/gpio/gpio-pcf857x.c | 26 +++++++++++------------
drivers/gpio/gpio-pci-idio-16.c | 3 ++-
drivers/gpio/gpio-pcie-idio-24.c | 8 +++++---
drivers/gpio/gpio-pisosr.c | 4 ++--
drivers/gpio/gpio-pl061.c | 2 +-
drivers/gpio/gpio-pmic-eic-sprd.c | 2 +-
drivers/gpio/gpio-ppc44x.c | 2 +-
drivers/gpio/gpio-pxa.c | 20 ++++++++++--------
drivers/gpio/gpio-qixis-fpga.c | 3 +--
drivers/gpio/gpio-rcar.c | 2 +-
drivers/gpio/gpio-rda.c | 2 +-
drivers/gpio/gpio-realtek-otto.c | 2 +-
drivers/gpio/gpio-rockchip.c | 4 ++--
drivers/gpio/gpio-sama5d2-piobu.c | 2 +-
drivers/gpio/gpio-shared-proxy.c | 2 +-
drivers/gpio/gpio-sifive.c | 2 +-
drivers/gpio/gpio-sl28cpld.c | 2 +-
drivers/gpio/gpio-sodaville.c | 3 ++-
drivers/gpio/gpio-spear-spics.c | 3 ++-
drivers/gpio/gpio-sprd.c | 2 +-
drivers/gpio/gpio-stmpe.c | 2 +-
drivers/gpio/gpio-stp-xway.c | 2 +-
drivers/gpio/gpio-tc9563.c | 2 +-
drivers/gpio/gpio-tegra.c | 6 +++---
drivers/gpio/gpio-tegra186.c | 32 ++++++++++++++---------------
drivers/gpio/gpio-thunderx.c | 3 +--
drivers/gpio/gpio-tps65218.c | 2 +-
drivers/gpio/gpio-ts4800.c | 4 ++--
drivers/gpio/gpio-ts4900.c | 2 +-
drivers/gpio/gpio-twl4030.c | 4 ++--
drivers/gpio/gpio-usbio.c | 14 ++++++-------
drivers/gpio/gpio-vf610.c | 4 ++--
drivers/gpio/gpio-virtio.c | 4 ++--
drivers/gpio/gpio-visconti.c | 2 +-
drivers/gpio/gpio-waveshare-dsi.c | 2 +-
drivers/gpio/gpio-xgene-sb.c | 6 +++---
drivers/gpio/gpio-xgene.c | 10 +++++----
drivers/gpio/gpio-xgs-iproc.c | 2 +-
drivers/gpio/gpio-xilinx.c | 4 ++--
drivers/gpio/gpio-xlp.c | 6 +++---
drivers/gpio/gpio-xra1403.c | 6 +++---
drivers/gpio/gpio-zevio.c | 5 +++--
drivers/gpio/gpio-zynqmp-modepin.c | 2 +-
drivers/gpio/gpiolib-acpi-quirks.c | 2 +-
112 files changed, 278 insertions(+), 260 deletions(-)
base-commit: 20a33c6b6cbe7e4805dfb6cd68816937443aa148
--
2.56.0.rc1
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v4 23/23] gpio: Unify style of various *_device_id arrays
2026-10-27 10:48 [PATCH v4 00/23] gpio: Improvements around device-id arrays Uwe Kleine-König (The Capable Hub)
@ 2026-10-27 10:49 ` Uwe Kleine-König (The Capable Hub)
2026-10-28 13:57 ` [PATCH v4 00/23] gpio: Improvements around device-id arrays Alan Borzeszkowski
1 sibling, 0 replies; 3+ messages in thread
From: Uwe Kleine-König (The Capable Hub) @ 2026-10-27 10:49 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski
Cc: Lixu Zhang, Sakari Ailus, Enrico Weigelt, metux IT consult,
Viresh Kumar, Mika Westerberg, Andy Shevchenko, linux-gpio,
linux-kernel, virtualization, linux-acpi, Viresh Kumar
Update the various *_device_id arrays to conform to the most used and
generally recommended coding style. That is:
- no comma after the list terminator;
- a comma after an initializer if (and only if) the closing } is not
directly following;
- no explicit zeros in the list terminator;
- a space after an opening { and before a closing }, a single space in
the list terminator;
Adapt the few offenders accordingly.
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
---
drivers/gpio/gpio-ljca.c | 2 +-
drivers/gpio/gpio-mpsse.c | 3 +--
drivers/gpio/gpio-pca953x.c | 2 +-
drivers/gpio/gpio-shared-proxy.c | 2 +-
drivers/gpio/gpio-virtio.c | 2 +-
drivers/gpio/gpiolib-acpi-quirks.c | 2 +-
6 files changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers/gpio/gpio-ljca.c b/drivers/gpio/gpio-ljca.c
index f967feedb5d2..29b4e06497d9 100644
--- a/drivers/gpio/gpio-ljca.c
+++ b/drivers/gpio/gpio-ljca.c
@@ -473,7 +473,7 @@ static void ljca_gpio_remove(struct auxiliary_device *auxdev)
static const struct auxiliary_device_id ljca_gpio_id_table[] = {
{ .name = "usb_ljca.ljca-gpio" },
- { /* sentinel */ },
+ { /* sentinel */ }
};
MODULE_DEVICE_TABLE(auxiliary, ljca_gpio_id_table);
diff --git a/drivers/gpio/gpio-mpsse.c b/drivers/gpio/gpio-mpsse.c
index 61c5ca96314b..a540f6e94f11 100644
--- a/drivers/gpio/gpio-mpsse.c
+++ b/drivers/gpio/gpio-mpsse.c
@@ -80,10 +80,9 @@ static struct mpsse_quirk bryx_brik_quirk = {
static const struct usb_device_id gpio_mpsse_table[] = {
{ USB_DEVICE(0x0c52, 0xa064) }, /* SeaLevel Systems, Inc. */
{ USB_DEVICE(0x0403, 0x6988), /* FTDI, assigned to Bryx */
- .driver_info = (kernel_ulong_t)&bryx_brik_quirk},
+ .driver_info = (kernel_ulong_t)&bryx_brik_quirk },
{ } /* Terminating entry */
};
-
MODULE_DEVICE_TABLE(usb, gpio_mpsse_table);
static DEFINE_IDA(gpio_mpsse_ida);
diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
index 77b447c0fea5..06f7ad0299f3 100644
--- a/drivers/gpio/gpio-pca953x.c
+++ b/drivers/gpio/gpio-pca953x.c
@@ -175,7 +175,7 @@ static const struct dmi_system_id pca953x_dmi_acpi_irq_info[] = {
DMI_EXACT_MATCH(DMI_BOARD_NAME, "GalileoGen2"),
},
},
- {}
+ { }
};
#endif
diff --git a/drivers/gpio/gpio-shared-proxy.c b/drivers/gpio/gpio-shared-proxy.c
index bc69b8729d19..b64e32a1c0a5 100644
--- a/drivers/gpio/gpio-shared-proxy.c
+++ b/drivers/gpio/gpio-shared-proxy.c
@@ -303,7 +303,7 @@ static int gpio_shared_proxy_probe(struct auxiliary_device *adev,
static const struct auxiliary_device_id gpio_shared_proxy_id_table[] = {
{ .name = "gpiolib_shared.proxy" },
- {},
+ { }
};
MODULE_DEVICE_TABLE(auxiliary, gpio_shared_proxy_id_table);
diff --git a/drivers/gpio/gpio-virtio.c b/drivers/gpio/gpio-virtio.c
index 42871db05ec1..062c70fe4671 100644
--- a/drivers/gpio/gpio-virtio.c
+++ b/drivers/gpio/gpio-virtio.c
@@ -647,7 +647,7 @@ static void virtio_gpio_remove(struct virtio_device *vdev)
static const struct virtio_device_id id_table[] = {
{ .device = VIRTIO_ID_GPIO, .vendor = VIRTIO_DEV_ANY_ID },
- {},
+ { }
};
MODULE_DEVICE_TABLE(virtio, id_table);
diff --git a/drivers/gpio/gpiolib-acpi-quirks.c b/drivers/gpio/gpiolib-acpi-quirks.c
index 3ab02c5f95df..77b9e34cd618 100644
--- a/drivers/gpio/gpiolib-acpi-quirks.c
+++ b/drivers/gpio/gpiolib-acpi-quirks.c
@@ -465,7 +465,7 @@ static const struct dmi_system_id gpiolib_acpi_quirks[] __initconst = {
.ignore_wake = "GTCH7503:00@10",
},
},
- {} /* Terminating entry */
+ { } /* Terminating entry */
};
static int __init acpi_gpio_setup_params(void)
--
2.56.0.rc1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v4 00/23] gpio: Improvements around device-id arrays
2026-10-27 10:48 [PATCH v4 00/23] gpio: Improvements around device-id arrays Uwe Kleine-König (The Capable Hub)
2026-10-27 10:49 ` [PATCH v4 23/23] gpio: Unify style of various *_device_id arrays Uwe Kleine-König (The Capable Hub)
@ 2026-10-28 13:57 ` Alan Borzeszkowski
1 sibling, 0 replies; 3+ messages in thread
From: Alan Borzeszkowski @ 2026-10-28 13:57 UTC (permalink / raw)
To: Uwe Kleine-König (The Capable Hub), Linus Walleij,
Bartosz Golaszewski
Cc: Andy Shevchenko, linux-gpio, linux-kernel, Lixu Zhang,
Sakari Ailus, Broadcom internal kernel review list,
Florian Fainelli, Eugeniy Paltsev, Frank Li, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Imre Kaloz, Conor Dooley,
Valentina Fernandez, Daire McNamara, Daniel Palmer, Romain Perier,
Robert Jarzmik, imx, linux-arm-kernel, linux-riscv, Hoan Tran,
Mika Westerberg, Hans de Goede, Nuno Sá, linux-hwmon,
Matti Vaittinen, Enrico Weigelt, metux IT consult, Viresh Kumar,
virtualization, Yinbo Zhu, Thierry Reding, Jonathan Hunter,
linux-tegra, Geert Uytterhoeven, AngeloGioacchino Del Regno,
Srinivas Neeli, Michal Simek, linux-aspeed, asahi, linux-mediatek,
openbmc, linux-omap, linux-renesas-soc, linux-unisoc,
linux-rockchip, linux-stm32, Michael Buesch,
William Breathitt Gray, Robert Richter, Andy Shevchenko,
linux-acpi
Hi,
On Tue, 2026-10-27 at 11:48 +0100, Uwe Kleine-König (The Capable Hub)
wrote:
> Hello,
>
> the original motivation for this series are the patches that convert
> the
> arrays to use named initializers, see
> https://lore.kernel.org/all/cover.1780048925.git.u.kleine-koenig@baylibre.com/
> for the idea behind it. Looking left and right a bit while
> implementing
> that, the series grew a bit.
>
> Changes since v3 (available at
> https://lore.kernel.org/all/cover.1793030820.git.u.kleine-koenig@baylibre.com
> ):
>
> - Picked up review tags (b4 even found some from v2)
> - Add a 2nd MODULE_DEVICE_TABLE(of, ...) in drivers/gpio/gpio-
> mpc5200.c
> (My grep didn't handle >1 driver per file well), noticed by
> Sashiko
> - New patch to use named initializers for auxiliary_device_id arrays
> - Fix code style of of_device_id array in drivers/gpio/gpio-grgpio.c
> (My script doesn't handle of_device_id::name) and
> drivers/gpio/gpio-ppc44x.c (didn't exist yet when I sent v2 and
> failed to notice that for v3)
> - Fix code style of auxiliary_device_id array in
> drivers/gpio/gpio-shared-proxy.c, missed as I didn't have a script
> for auxiliary_device_id before.
> - Dropped a few broken email addresses from Cc:
>
> Best regards
> Uwe
>
> Uwe Kleine-König (The Capable Hub) (23):
> [...]
> gpio: Use named initializers for acpi_device_id array
> [...]
> gpio: Unify style of acpi_device_id arrays
> [...]
>
> [...]
> drivers/gpio/gpio-novalake-events.c | 4 ++--
> [...]
>
For gpio-novalake-events
Acked-by: Alan Borzeszkowski <alan.borzeszkowski@linux.intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-10-28 13:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-27 10:48 [PATCH v4 00/23] gpio: Improvements around device-id arrays Uwe Kleine-König (The Capable Hub)
2026-10-27 10:49 ` [PATCH v4 23/23] gpio: Unify style of various *_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-10-28 13:57 ` [PATCH v4 00/23] gpio: Improvements around device-id arrays Alan Borzeszkowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox