* [PATCH v2] ACPI: Add stub for acpi_find_child_device()
@ 2026-09-25 15:52 Mario Limonciello
2026-09-25 15:54 ` Rafael J. Wysocki (Intel)
0 siblings, 1 reply; 3+ messages in thread
From: Mario Limonciello @ 2026-09-25 15:52 UTC (permalink / raw)
To: rafael, lenb, maciej.wieczor-retman, pawel.chmielewski
Cc: Mario Limonciello, Arnd Bergmann, Liam Girdwood, Peter Ujfalusi,
Bard Liao, Daniel Baluta, Mark Brown, Jaroslav Kysela,
Takashi Iwai, Vijendar Mukunda, Kai Vehmanen,
Pierre-Louis Bossart, sound-open-firmware, linux-acpi,
acpica-devel
Provide a NULL-returning stub when CONFIG_ACPI is disabled so callers can
be compiled without ACPI support.
Reported-by: Arnd Bergmann <arnd@arndb.de>
Closes: https://lore.kernel.org/linux-sound/20260925131104.118993-1-arnd@kernel.org/
Suggested-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
v2:
* Move to acpi_bus.h
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Cc: Bard Liao <yung-chuan.liao@linux.intel.com>
Cc: Daniel Baluta <daniel.baluta@nxp.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Jaroslav Kysela <perex@perex.cz>
Cc: Takashi Iwai <tiwai@suse.com>
Cc: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Cc: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>
Cc: sound-open-firmware@alsa-project.org
---
include/acpi/acpi_bus.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/acpi/acpi_bus.h b/include/acpi/acpi_bus.h
index 7dbe5d42c67e8..b7771b4f36c80 100644
--- a/include/acpi/acpi_bus.h
+++ b/include/acpi/acpi_bus.h
@@ -954,6 +954,8 @@ u32 arch_acpi_add_auto_dep(acpi_handle handle);
#else /* CONFIG_ACPI */
+#define acpi_find_child_device(...) (NULL)
+
static inline bool acpi_has_method(acpi_handle handle, char *name)
{
return false;
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] ACPI: Add stub for acpi_find_child_device()
2026-09-25 15:52 [PATCH v2] ACPI: Add stub for acpi_find_child_device() Mario Limonciello
@ 2026-09-25 15:54 ` Rafael J. Wysocki (Intel)
2026-09-25 16:01 ` Mario Limonciello
0 siblings, 1 reply; 3+ messages in thread
From: Rafael J. Wysocki (Intel) @ 2026-09-25 15:54 UTC (permalink / raw)
To: Mario Limonciello
Cc: rafael, lenb, maciej.wieczor-retman, pawel.chmielewski,
Arnd Bergmann, Liam Girdwood, Peter Ujfalusi, Bard Liao,
Daniel Baluta, Mark Brown, Jaroslav Kysela, Takashi Iwai,
Vijendar Mukunda, Kai Vehmanen, Pierre-Louis Bossart,
sound-open-firmware, linux-acpi, acpica-devel
On Fri, Sep 25, 2026 at 5:53 PM Mario Limonciello
<mario.limonciello@amd.com> wrote:
>
> Provide a NULL-returning stub when CONFIG_ACPI is disabled so callers can
> be compiled without ACPI support.
>
> Reported-by: Arnd Bergmann <arnd@arndb.de>
> Closes: https://lore.kernel.org/linux-sound/20260925131104.118993-1-arnd@kernel.org/
> Suggested-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
> v2:
> * Move to acpi_bus.h
> Cc: Liam Girdwood <lgirdwood@gmail.com>
> Cc: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
> Cc: Bard Liao <yung-chuan.liao@linux.intel.com>
> Cc: Daniel Baluta <daniel.baluta@nxp.com>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Jaroslav Kysela <perex@perex.cz>
> Cc: Takashi Iwai <tiwai@suse.com>
> Cc: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
> Cc: Kai Vehmanen <kai.vehmanen@linux.intel.com>
> Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>
> Cc: sound-open-firmware@alsa-project.org
> ---
> include/acpi/acpi_bus.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/acpi/acpi_bus.h b/include/acpi/acpi_bus.h
> index 7dbe5d42c67e8..b7771b4f36c80 100644
> --- a/include/acpi/acpi_bus.h
> +++ b/include/acpi/acpi_bus.h
> @@ -954,6 +954,8 @@ u32 arch_acpi_add_auto_dep(acpi_handle handle);
>
> #else /* CONFIG_ACPI */
>
> +#define acpi_find_child_device(...) (NULL)
Well, thanks, but I'd prefer a static inline stub. Any issues with that?
> static inline bool acpi_has_method(acpi_handle handle, char *name)
> {
> return false;
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] ACPI: Add stub for acpi_find_child_device()
2026-09-25 15:54 ` Rafael J. Wysocki (Intel)
@ 2026-09-25 16:01 ` Mario Limonciello
0 siblings, 0 replies; 3+ messages in thread
From: Mario Limonciello @ 2026-09-25 16:01 UTC (permalink / raw)
To: Rafael J. Wysocki (Intel)
Cc: lenb, maciej.wieczor-retman, pawel.chmielewski, Arnd Bergmann,
Liam Girdwood, Peter Ujfalusi, Bard Liao, Daniel Baluta,
Mark Brown, Jaroslav Kysela, Takashi Iwai, Vijendar Mukunda,
Kai Vehmanen, Pierre-Louis Bossart, sound-open-firmware,
linux-acpi, acpica-devel
On 9/25/26 10:54, Rafael J. Wysocki (Intel) wrote:
> On Fri, Sep 25, 2026 at 5:53 PM Mario Limonciello
> <mario.limonciello@amd.com> wrote:
>>
>> Provide a NULL-returning stub when CONFIG_ACPI is disabled so callers can
>> be compiled without ACPI support.
>>
>> Reported-by: Arnd Bergmann <arnd@arndb.de>
>> Closes: https://lore.kernel.org/linux-sound/20260925131104.118993-1-arnd@kernel.org/
>> Suggested-by: Arnd Bergmann <arnd@arndb.de>
>> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
>> ---
>> v2:
>> * Move to acpi_bus.h
>> Cc: Liam Girdwood <lgirdwood@gmail.com>
>> Cc: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
>> Cc: Bard Liao <yung-chuan.liao@linux.intel.com>
>> Cc: Daniel Baluta <daniel.baluta@nxp.com>
>> Cc: Mark Brown <broonie@kernel.org>
>> Cc: Jaroslav Kysela <perex@perex.cz>
>> Cc: Takashi Iwai <tiwai@suse.com>
>> Cc: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
>> Cc: Kai Vehmanen <kai.vehmanen@linux.intel.com>
>> Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>
>> Cc: sound-open-firmware@alsa-project.org
>> ---
>> include/acpi/acpi_bus.h | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/include/acpi/acpi_bus.h b/include/acpi/acpi_bus.h
>> index 7dbe5d42c67e8..b7771b4f36c80 100644
>> --- a/include/acpi/acpi_bus.h
>> +++ b/include/acpi/acpi_bus.h
>> @@ -954,6 +954,8 @@ u32 arch_acpi_add_auto_dep(acpi_handle handle);
>>
>> #else /* CONFIG_ACPI */
>>
>> +#define acpi_find_child_device(...) (NULL)
>
> Well, thanks, but I'd prefer a static inline stub. Any issues with that?
>
That should be fine, I'll test it and send out a v3.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-09-25 16:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-25 15:52 [PATCH v2] ACPI: Add stub for acpi_find_child_device() Mario Limonciello
2026-09-25 15:54 ` Rafael J. Wysocki (Intel)
2026-09-25 16:01 ` Mario Limonciello
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox