From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: Daniel Scally <djrscally@gmail.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Wolfram Sang <wsa@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH v3 1/2] drivers: fwnode: Extend device_get_match_data() to struct bus_type
Date: Wed, 2 Aug 2023 17:46:20 +0300 [thread overview]
Message-ID: <ZMpsPMazqlQFERaM@smile.fi.intel.com> (raw)
In-Reply-To: <OS0PR01MB592219C8BEF733C6A75DDD5C860BA@OS0PR01MB5922.jpnprd01.prod.outlook.com>
On Wed, Aug 02, 2023 at 06:32:18AM +0000, Biju Das wrote:
> > On Tue, Aug 01, 2023 at 06:03:17PM +0100, Biju Das wrote:
...
> > *
> > * Besides the fact that some drivers abuse the device ID driver_data
> > type
> > * and claim it to be integer, for the bus specific ID tables the
> > driver_data
> > * may be defined as kernel_ulong_t. For these tables 0 is a valid
> > response,
> > * but not for this function. It's recommended to covert those either to
>
> Will fix the typo covert->convert
Thank you!
> > avoid
> > * 0 or use a real pointer to the predefined driver data.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2023-08-02 14:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 17:03 [PATCH v3 0/2] Extend device_get_match_data() to struct bus_type Biju Das
2023-08-01 17:03 ` [PATCH v3 1/2] drivers: fwnode: " Biju Das
2023-08-01 19:39 ` Andy Shevchenko
2023-08-02 6:32 ` Biju Das
2023-08-02 14:46 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMpsPMazqlQFERaM@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=djrscally@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox