From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mario Limonciello <superm1@kernel.org>
Cc: Hans de Goede <hansg@kernel.org>,
Mika Westerberg <westeri@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
"open list:GPIO ACPI SUPPORT" <linux-gpio@vger.kernel.org>,
"open list:GPIO ACPI SUPPORT" <linux-acpi@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
"open list:INPUT (KEYBOARD, MOUSE, JOYSTICK,
TOUCHSCREEN)..." <linux-input@vger.kernel.org>,
Mario Limonciello <mario.limonciello@amd.com>
Subject: Re: [PATCH v3 3/4] Input: Don't program hw debounce for soc_button_array devices
Date: Thu, 26 Jun 2025 17:33:50 +0300 [thread overview]
Message-ID: <aF1aThiXUFhHxlZO@smile.fi.intel.com> (raw)
In-Reply-To: <20250625215813.3477840-4-superm1@kernel.org>
On Wed, Jun 25, 2025 at 04:58:12PM -0500, Mario Limonciello wrote:
> From: Mario Limonciello <mario.limonciello@amd.com>
>
> Programming a hardware debounce of 50ms causes problems where a button
> doesn't work properly anymore on some systems. This debounce is intended
> for compatibility with systems with a mechanical switch so soc_button_array
> devices should only be using a sofware debounce.
>
> Add support for indicating that a driver is only requesting gpio_keys
> to use software debounce support and mark that in soc_button_array
> accordingly.
...
> + gpio_keys_pdata->no_hw_debounce = TRUE;
true
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-06-26 14:33 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-25 21:58 [PATCH v3 0/4] Fix soc-button-array debounce Mario Limonciello
2025-06-25 21:58 ` [PATCH v3 1/4] gpiolib: acpi: Add a helper for programming debounce Mario Limonciello
2025-06-26 14:29 ` Andy Shevchenko
2025-06-26 16:04 ` Mario Limonciello
2025-06-25 21:58 ` [PATCH v3 2/4] gpiolib: acpi: Program debounce when finding GPIO Mario Limonciello
2025-06-26 14:31 ` Andy Shevchenko
2025-06-25 21:58 ` [PATCH v3 3/4] Input: Don't program hw debounce for soc_button_array devices Mario Limonciello
2025-06-26 8:27 ` Hans de Goede
2025-06-26 14:33 ` Andy Shevchenko [this message]
2025-06-25 21:58 ` [PATCH v3 4/4] Input: Don't send fake button presses to wake system Mario Limonciello
2025-06-26 8:35 ` Hans de Goede
2025-06-26 11:33 ` Mario Limonciello
2025-06-26 17:44 ` Dmitry Torokhov
2025-06-26 17:53 ` Mario Limonciello
2025-06-26 18:07 ` Dmitry Torokhov
2025-06-26 18:20 ` Mario Limonciello
2025-06-26 18:48 ` Dmitry Torokhov
2025-06-26 18:55 ` Mario Limonciello
2025-06-26 19:06 ` Dmitry Torokhov
2025-06-26 19:37 ` Andy Shevchenko
2025-06-26 18:57 ` Hans de Goede
2025-06-26 19:14 ` Dmitry Torokhov
2025-06-26 19:16 ` Hans de Goede
2025-06-26 19:18 ` Rafael J. Wysocki
2025-06-26 19:28 ` Dmitry Torokhov
2025-06-26 19:31 ` Rafael J. Wysocki
2025-06-26 19:40 ` Dmitry Torokhov
2025-06-26 22:21 ` Mario Limonciello
2025-06-27 4:56 ` Dmitry Torokhov
2025-06-27 14:06 ` Mario Limonciello
2025-06-27 14:14 ` Hans de Goede
2025-06-27 14:44 ` Dmitry Torokhov
2025-06-27 15:56 ` Hans de Goede
2025-06-27 16:12 ` Andy Shevchenko
2025-06-27 17:59 ` Hans de Goede
2025-06-27 18:47 ` Dmitry Torokhov
2025-06-27 18:36 ` Dmitry Torokhov
2025-06-27 18:56 ` Mario Limonciello
2025-06-27 19:18 ` Dmitry Torokhov
2025-06-27 19:38 ` Hans de Goede
2025-06-27 19:44 ` Mario Limonciello
2025-06-27 20:25 ` Hans de Goede
2025-06-27 20:29 ` Mario Limonciello
2025-06-27 19:45 ` Mario Limonciello
2025-06-27 10:36 ` Rafael J. Wysocki
2025-06-26 19:28 ` Rafael J. Wysocki
2025-06-26 18:37 ` Hans de Goede
2025-06-26 18:42 ` Mario Limonciello
2025-06-26 18:45 ` Hans de Goede
2025-06-26 18:47 ` Mario Limonciello
2025-06-26 14:37 ` Andy Shevchenko
2025-06-26 14:35 ` [PATCH v3 0/4] Fix soc-button-array debounce Andy Shevchenko
2025-06-26 15:59 ` Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aF1aThiXUFhHxlZO@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=brgl@bgdev.pl \
--cc=dmitry.torokhov@gmail.com \
--cc=hansg@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=superm1@kernel.org \
--cc=westeri@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox