From: Dan Carpenter <error27@gmail.com>
To: linux-acpi@vger.kernel.org
Subject: double unlock in bt_rfkill_poll()
Date: Sun, 19 Jul 2009 14:47:30 +0300 (EAT) [thread overview]
Message-ID: <alpine.DEB.2.00.0907171544100.12306@bicker> (raw)
Hello,
My source checker tool (http://repo.or.cz/w/smatch.git) found an issue in
bt_rfkill_poll(). I don't know the correct way to fix this.
We unlock on line 337 and again on line 342.
drivers/platform/x86/toshiba_acpi.c
334 hci_result = hci_get_radio_state(&value);
335 if (hci_result != HCI_SUCCESS) {
336 /* Can't do anything useful */
337 mutex_unlock(&dev->mutex);
338 }
339
340 new_rfk_state = value;
341
342 mutex_unlock(&dev->mutex);
regards,
dan carpenter
reply other threads:[~2009-07-19 12:45 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.0907171544100.12306@bicker \
--to=error27@gmail.com \
--cc=linux-acpi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox