* double unlock in bt_rfkill_poll()
@ 2009-07-19 11:47 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2009-07-19 11:47 UTC (permalink / raw)
To: linux-acpi
Hello,
My source checker tool (http://repo.or.cz/w/smatch.git) found an issue in
bt_rfkill_poll(). I don't know the correct way to fix this.
We unlock on line 337 and again on line 342.
drivers/platform/x86/toshiba_acpi.c
334 hci_result = hci_get_radio_state(&value);
335 if (hci_result != HCI_SUCCESS) {
336 /* Can't do anything useful */
337 mutex_unlock(&dev->mutex);
338 }
339
340 new_rfk_state = value;
341
342 mutex_unlock(&dev->mutex);
regards,
dan carpenter
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2009-07-19 12:45 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-19 11:47 double unlock in bt_rfkill_poll() Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox