From: Len Brown <lenb@kernel.org>
To: akpm@linux-foundation.org
Cc: linux-acpi@vger.kernel.org, harvey.harrison@gmail.com,
andi@firstfloor.org, hmh@hmh.eng.br, mjg59@srcf.ucam.org
Subject: Re: [patch 1/5] acpi: toshiba_acpi.c fix sparse signedness mismatch warnings
Date: Fri, 10 Oct 2008 12:58:02 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.1.10.0810101257550.7059@localhost.localdomain> (raw)
In-Reply-To: <200809222137.m8MLbUjg030999@imap1.linux-foundation.org>
applied.
thanks,
-Len
On Mon, 22 Sep 2008, akpm@linux-foundation.org wrote:
> From: Harvey Harrison <harvey.harrison@gmail.com>
>
> set_bit expects unsigned int, and we start with a u32 anyway.
> drivers/acpi/toshiba_acpi.c:397:14: warning: incorrect type in argument 1 (different signedness)
> drivers/acpi/toshiba_acpi.c:397:14: expected unsigned int [usertype] *word
> drivers/acpi/toshiba_acpi.c:397:14: got int *<noident>
> drivers/acpi/toshiba_acpi.c:399:14: warning: incorrect type in argument 1 (different signedness)
> drivers/acpi/toshiba_acpi.c:399:14: expected unsigned int [usertype] *word
> drivers/acpi/toshiba_acpi.c:399:14: got int *<noident>
> drivers/acpi/toshiba_acpi.c:401:14: warning: incorrect type in argument 1 (different signedness)
> drivers/acpi/toshiba_acpi.c:401:14: expected unsigned int [usertype] *word
> drivers/acpi/toshiba_acpi.c:401:14: got int *<noident>
>
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> Cc: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
> Cc: Matthew Garrett <mjg59@srcf.ucam.org>
> Cc: Andi Kleen <andi@firstfloor.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
> drivers/acpi/toshiba_acpi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff -puN drivers/acpi/toshiba_acpi.c~acpi-toshiba_acpic-fix-sparse-signedness-mismatch-warnings drivers/acpi/toshiba_acpi.c
> --- a/drivers/acpi/toshiba_acpi.c~acpi-toshiba_acpic-fix-sparse-signedness-mismatch-warnings
> +++ a/drivers/acpi/toshiba_acpi.c
> @@ -548,7 +548,7 @@ static unsigned long write_video(const c
>
> hci_read1(HCI_VIDEO_OUT, &video_out, &hci_result);
> if (hci_result == HCI_SUCCESS) {
> - int new_video_out = video_out;
> + unsigned int new_video_out = video_out;
> if (lcd_out != -1)
> _set_bit(&new_video_out, HCI_VIDEO_OUT_LCD, lcd_out);
> if (crt_out != -1)
> _
>
prev parent reply other threads:[~2008-10-10 16:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-22 21:37 [patch 1/5] acpi: toshiba_acpi.c fix sparse signedness mismatch warnings akpm
2008-10-10 16:58 ` Len Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.1.10.0810101257550.7059@localhost.localdomain \
--to=lenb@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=harvey.harrison@gmail.com \
--cc=hmh@hmh.eng.br \
--cc=linux-acpi@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox