[patch 1/5] acpi: toshiba_acpi.c fix sparse signedness mismatch warnings

[patch 1/5] acpi: toshiba_acpi.c fix sparse signedness mismatch warnings

[akpm]

From: Harvey Harrison <harvey.harrison@gmail.com>

set_bit expects unsigned int, and we start with a u32 anyway.
drivers/acpi/toshiba_acpi.c:397:14: warning: incorrect type in argument 1 (different signedness)
drivers/acpi/toshiba_acpi.c:397:14:    expected unsigned int [usertype] *word
drivers/acpi/toshiba_acpi.c:397:14:    got int *<noident>
drivers/acpi/toshiba_acpi.c:399:14: warning: incorrect type in argument 1 (different signedness)
drivers/acpi/toshiba_acpi.c:399:14:    expected unsigned int [usertype] *word
drivers/acpi/toshiba_acpi.c:399:14:    got int *<noident>
drivers/acpi/toshiba_acpi.c:401:14: warning: incorrect type in argument 1 (different signedness)
drivers/acpi/toshiba_acpi.c:401:14:    expected unsigned int [usertype] *word
drivers/acpi/toshiba_acpi.c:401:14:    got int *<noident>

Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
Cc: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: Andi Kleen <andi@firstfloor.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/acpi/toshiba_acpi.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN drivers/acpi/toshiba_acpi.c~acpi-toshiba_acpic-fix-sparse-signedness-mismatch-warnings drivers/acpi/toshiba_acpi.c
--- a/drivers/acpi/toshiba_acpi.c~acpi-toshiba_acpic-fix-sparse-signedness-mismatch-warnings
+++ a/drivers/acpi/toshiba_acpi.c
@@ -548,7 +548,7 @@ static unsigned long write_video(const c
 
 	hci_read1(HCI_VIDEO_OUT, &video_out, &hci_result);
 	if (hci_result == HCI_SUCCESS) {
-		int new_video_out = video_out;
+		unsigned int new_video_out = video_out;
 		if (lcd_out != -1)
 			_set_bit(&new_video_out, HCI_VIDEO_OUT_LCD, lcd_out);
 		if (crt_out != -1)
_

Re: [patch 1/5] acpi: toshiba_acpi.c fix sparse signedness mismatch warnings

[Len Brown]

applied.

thanks,
-Len

On Mon, 22 Sep 2008, akpm@linux-foundation.org wrote:

> From: Harvey Harrison <harvey.harrison@gmail.com>
> 
> set_bit expects unsigned int, and we start with a u32 anyway.
> drivers/acpi/toshiba_acpi.c:397:14: warning: incorrect type in argument 1 (different signedness)
> drivers/acpi/toshiba_acpi.c:397:14:    expected unsigned int [usertype] *word
> drivers/acpi/toshiba_acpi.c:397:14:    got int *<noident>
> drivers/acpi/toshiba_acpi.c:399:14: warning: incorrect type in argument 1 (different signedness)
> drivers/acpi/toshiba_acpi.c:399:14:    expected unsigned int [usertype] *word
> drivers/acpi/toshiba_acpi.c:399:14:    got int *<noident>
> drivers/acpi/toshiba_acpi.c:401:14: warning: incorrect type in argument 1 (different signedness)
> drivers/acpi/toshiba_acpi.c:401:14:    expected unsigned int [usertype] *word
> drivers/acpi/toshiba_acpi.c:401:14:    got int *<noident>
> 
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> Cc: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
> Cc: Matthew Garrett <mjg59@srcf.ucam.org>
> Cc: Andi Kleen <andi@firstfloor.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
> 
>  drivers/acpi/toshiba_acpi.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff -puN drivers/acpi/toshiba_acpi.c~acpi-toshiba_acpic-fix-sparse-signedness-mismatch-warnings drivers/acpi/toshiba_acpi.c
> --- a/drivers/acpi/toshiba_acpi.c~acpi-toshiba_acpic-fix-sparse-signedness-mismatch-warnings
> +++ a/drivers/acpi/toshiba_acpi.c
> @@ -548,7 +548,7 @@ static unsigned long write_video(const c
>  
>  	hci_read1(HCI_VIDEO_OUT, &video_out, &hci_result);
>  	if (hci_result == HCI_SUCCESS) {
> -		int new_video_out = video_out;
> +		unsigned int new_video_out = video_out;
>  		if (lcd_out != -1)
>  			_set_bit(&new_video_out, HCI_VIDEO_OUT_LCD, lcd_out);
>  		if (crt_out != -1)
> _
>