Re: [PATCH] Fix possible null ptr dereference

[Len Brown <lenb@kernel.org>]

applied.

thanks,
-Len

On Fri, 17 Oct 2008, donald.d.dugger@intel.com wrote:

> Code in `pci_link.c' is calling the internal routine `acpi_ut_evaluate_object'
> which is dangerous given that it is passing a NULL pointer when it should
> be passing a pointer to a real object.  The patch corrects the issue by
> having the code call the external routine `acpi_evaluate_object', which
> correctly handles a NULL pointer.
> 
> Signed-off-by: Don Dugger <donald.d.dugger@intel.com>
> 
> 
> ----- cut here for patch.d/acpi_null-1017.patch -----
> diff --git a/drivers/acpi/pci_link.c b/drivers/acpi/pci_link.c
> index cf47805..65bf4fa 100644
> --- a/drivers/acpi/pci_link.c
> +++ b/drivers/acpi/pci_link.c
> @@ -709,7 +709,7 @@ int acpi_pci_link_free_irq(acpi_handle handle)
>  			  acpi_device_bid(link->device)));
>  
>  	if (link->refcnt == 0) {
> -		acpi_ut_evaluate_object(link->device->handle, "_DIS", 0, NULL);
> +		acpi_evaluate_object(link->device->handle, "_DIS", NULL, NULL);
>  	}
>  	mutex_unlock(&acpi_link_lock);
>  	return (link->irq.active);
> @@ -773,7 +773,7 @@ static int acpi_pci_link_add(struct acpi_device *device)
>  
>        end:
>  	/* disable all links -- to be activated on use */
> -	acpi_ut_evaluate_object(device->handle, "_DIS", 0, NULL);
> +	acpi_evaluate_object(device->handle, "_DIS", NULL, NULL);
>  	mutex_unlock(&acpi_link_lock);
>  
>  	if (result)
>