From: Len Brown <lenb@kernel.org>
To: "Moore, Robert" <robert.moore@intel.com>
Cc: "Dugger, Donald D" <donald.d.dugger@intel.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"bjorn.helgaas@hp.com" <bjorn.helgaas@hp.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"astarikovskiy@suse.de" <astarikovskiy@suse.de>,
"Lin, Ming M" <ming.m.lin@intel.com>
Subject: RE: [PATCH] Fix possible null ptr dereference
Date: Fri, 17 Oct 2008 16:55:21 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.1.10.0810171653510.3006@localhost.localdomain> (raw)
In-Reply-To: <4911F71203A09E4D9981D27F9D830858032E0245@orsmsx503.amr.corp.intel.com>
> In general, the internal ACPICA functions do not perform nearly as much parameter validation as the external functions. The Host OS should not be calling any of the ACPICA internal functions for this and a few other good reasons -- such as the fact that internal functions can disappear, be renamed, or have the parameters changed without warning at any time.
>
> It would probably be a good idea to audit Linux for the use of internal ACPICA functions and fix these bugs.
I think the way to do this is to clean up the headers
so that code outside of ACPICA doesn't even see
the declarations of the internal ACPICA functions.
Right now everything includes everything, so the headers can't help us.
-Len
next prev parent reply other threads:[~2008-10-17 20:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-17 14:49 [PATCH] Fix possible null ptr dereference donald.d.dugger
2008-10-17 16:44 ` Len Brown
2008-10-17 18:02 ` Moore, Robert
2008-10-17 20:55 ` Len Brown [this message]
2008-10-17 21:49 ` Moore, Robert
2008-10-18 16:33 ` ACPICA header files Moore, Robert
2008-10-18 17:42 ` Alexey Starikovskiy
2008-10-18 21:05 ` Moore, Robert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.1.10.0810171653510.3006@localhost.localdomain \
--to=lenb@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=astarikovskiy@suse.de \
--cc=bjorn.helgaas@hp.com \
--cc=donald.d.dugger@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).