From: Len Brown <lenb@kernel.org>
To: yakui_zhao <yakui.zhao@intel.com>
Cc: Norbert Preining <preining@logic.at>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
Eric Anholt <eric@anholt.net>, "Zhang, Rui" <rui.zhang@intel.com>,
Keith Packard <keithp@keithp.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: Re: 2.6.30-rc3 video/i915 build error
Date: Fri, 24 Apr 2009 11:49:27 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.2.00.0904241145220.10096@localhost.localdomain> (raw)
In-Reply-To: <1240544791.3651.82.camel@localhost.localdomain>
From: Len Brown <len.brown@intel.com>
Subject: [PATCH] ACPI, i915: build fix
drivers/built-in.o: In function `intel_opregion_init':
(.text+0x9d540): undefined reference to `acpi_video_register'
Signed-off-by: Len Brown <len.brown@intel.com>
---
drivers/gpu/drm/Kconfig | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
index 3a22eb9..f33d252 100644
--- a/drivers/gpu/drm/Kconfig
+++ b/drivers/gpu/drm/Kconfig
@@ -83,6 +83,12 @@ config DRM_I915
config DRM_I915_KMS
bool "Enable modesetting on intel by default"
depends on DRM_I915
+ # i915 KMS depends on ACPI_VIDEO when ACPI is enabled
+ # but for select to work, need to select ACPI_VIDEO's dependencies, ick
+ select VIDEO_OUTPUT_CONTROL if ACPI
+ select BACKLIGHT_CLASS_DEVICE if ACPI
+ select INPUT if ACPI
+ select ACPI_VIDEO if ACPI
help
Choose this option if you want kernel modesetting enabled by default,
and you have a new enough userspace to support this. Running old
--
1.6.3.rc1.51.gea0b7
next prev parent reply other threads:[~2009-04-24 15:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-23 16:36 2.6.30-rc3 video/i915 build error Len Brown
2009-04-23 16:46 ` Norbert Preining
2009-04-23 19:50 ` Len Brown
2009-04-24 1:10 ` yakui_zhao
2009-04-24 1:57 ` Len Brown
2009-04-24 3:46 ` yakui_zhao
2009-04-24 15:49 ` Len Brown [this message]
2009-04-28 6:02 ` yakui_zhao
2009-04-24 15:13 ` Len Brown
2009-04-30 18:07 ` Norbert Preining
2009-04-30 18:12 ` Norbert Preining
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0904241145220.10096@localhost.localdomain \
--to=lenb@kernel.org \
--cc=eric@anholt.net \
--cc=jbarnes@virtuousgeek.org \
--cc=keithp@keithp.com \
--cc=linux-acpi@vger.kernel.org \
--cc=preining@logic.at \
--cc=rui.zhang@intel.com \
--cc=yakui.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox