From: yakui_zhao <yakui.zhao@intel.com>
To: Len Brown <lenb@kernel.org>
Cc: Norbert Preining <preining@logic.at>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
Eric Anholt <eric@anholt.net>, "Zhang, Rui" <rui.zhang@intel.com>,
Keith Packard <keithp@keithp.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: Re: 2.6.30-rc3 video/i915 build error
Date: Fri, 24 Apr 2009 11:46:31 +0800 [thread overview]
Message-ID: <1240544791.3651.82.camel@localhost.localdomain> (raw)
In-Reply-To: <alpine.LFD.2.00.0904232156040.15843@localhost.localdomain>
On Fri, 2009-04-24 at 09:57 +0800, Len Brown wrote:
Hi, Len
In my test if VIDEO_OUTPUT_CONTROL is not selected, there exists the
following failure:
>drivers/built-in.o: In function `acpi_video_bus_put_devices':
>video.c:(.text+0x41307): undefined reference to
`video_output_unregister'
>drivers/built-in.o: In function `acpi_video_bus_add':
video.c:(.text+0x43024): undefined reference to `video_output_register'
>make: *** [.tmp_vmlinux1] Error 1
In order to fix this issue we must select the VIDEO_OUTPUT_CONTROL
when ACPI_VIDEO is selected.
I add the following content in drivers/gpu/drm/Kconfig
>select ACPI_VIDEO if ACPI
>select VIDEO_OUTPUT_CONTROL if ACPI_VIDEO
And then it will report that there exits recursive dependency:
ACPI_VIDEO -> VIDEO_OUTPUT_CONTROL -> ACPI_VIDEO
In fact in current kernel there exists the following dependency:
ACPI_VIDEO depends on VIDEO_OUTPUT_CONTROL.
If we delete the ACPI_VIDEO configuration in drivers/acpi/Kconfig,
we can't select the acpi_video configuration when i915 is not used.
So IMO it is not very good to change the dependency. After changing
the dependency between ACPI_VIDEO and I915, the new issue about
dependency is triggered.
Thanks.
>
> thanks,
> Len Brown, Intel Open Source Technology Center
>
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-04-24 3:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-23 16:36 2.6.30-rc3 video/i915 build error Len Brown
2009-04-23 16:46 ` Norbert Preining
2009-04-23 19:50 ` Len Brown
2009-04-24 1:10 ` yakui_zhao
2009-04-24 1:57 ` Len Brown
2009-04-24 3:46 ` yakui_zhao [this message]
2009-04-24 15:49 ` Len Brown
2009-04-28 6:02 ` yakui_zhao
2009-04-24 15:13 ` Len Brown
2009-04-30 18:07 ` Norbert Preining
2009-04-30 18:12 ` Norbert Preining
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1240544791.3651.82.camel@localhost.localdomain \
--to=yakui.zhao@intel.com \
--cc=eric@anholt.net \
--cc=jbarnes@virtuousgeek.org \
--cc=keithp@keithp.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=preining@logic.at \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox