2.6.30-rc3 video/i915 build error

2.6.30-rc3 video/i915 build error

[Len Brown]

I thought we had addressed this, no?
(not that this is a reasonable/realistic config, but it is possible)

For
CONFIG_DRM_I915=y
CONFIG_ACPI_VIDEO=m

drivers/built-in.o: In function `intel_opregion_init':
(.text+0x9d540): undefined reference to `acpi_video_register'


Len Brown, Intel Open Source Technology Center

Re: 2.6.30-rc3 video/i915 build error

[Norbert Preining]

On Do, 23 Apr 2009, Len Brown wrote:
> I thought we had addressed this, no?

The last I have seen are the two patches by  Zhao Yakui in the emails
subject: 
	ACPI: Weaken the dependency between ACPI video driver and I915
and
	ACPI: Check whether the acpi video is deferrable only when KMS is enabled

> CONFIG_DRM_I915=y
> CONFIG_ACPI_VIDEO=m
> 
> drivers/built-in.o: In function `intel_opregion_init':
> (.text+0x9d540): undefined reference to `acpi_video_register'

For me these two patches fix the problem.

Best wishes

Norbert

-------------------------------------------------------------------------------
Dr. Norbert Preining <preining@logic.at>        Vienna University of Technology
Debian Developer <preining@debian.org>                         Debian TeX Group
gpg DSA: 0x09C5B094      fp: 14DF 2E6C 0307 BE6D AD76  A9C0 D2BF 4AA3 09C5 B094
-------------------------------------------------------------------------------
FRATING GREEN (adj.)
The shade of green which is supposed to make you feel comfortable in
hospitals, industrious in schools and uneasy in police stations.
			--- Douglas Adams, The Meaning of Liff

Re: 2.6.30-rc3 video/i915 build error

[Len Brown]

On Thu, 23 Apr 2009, Norbert Preining wrote:

> On Do, 23 Apr 2009, Len Brown wrote:
> > I thought we had addressed this, no?
> 
> The last I have seen are the two patches by  Zhao Yakui in the emails
> subject: 
> 	ACPI: Weaken the dependency between ACPI video driver and I915
> and
> 	ACPI: Check whether the acpi video is deferrable only when KMS is enabled
> 
> > CONFIG_DRM_I915=y
> > CONFIG_ACPI_VIDEO=m
> > 
> > drivers/built-in.o: In function `intel_opregion_init':
> > (.text+0x9d540): undefined reference to `acpi_video_register'
> 
> For me these two patches fix the problem.

Matthew's response to those patches seems to be sufficient:

http://patchwork.kernel.org/patch/18420/

thanks,
Len Brown, Intel Open Source Technology Center

Re: 2.6.30-rc3 video/i915 build error

[yakui_zhao]

On Fri, 2009-04-24 at 03:50 +0800, Len Brown wrote:

Hi, Len
    The issue can be fixed by the patch from Matthew.
    In Matthew's patch the acpi video is also selected when the i915 is
compiled as builtin-kernel module.
    But IMO this is not very good. From the Kconfig file we know that
acpi video driver depends on the following configuration:
    BACKLIGHT_CLASS_DEVICE && VIDEO_OUTPUT_CONTROL

    If the VIDEO_OUTPUT_CONTROL/BACKLIGHT_CLASS_DEVICE is not selected,
then it will still fail in kernel compilation.

    Thanks.
> 
> http://patchwork.kernel.org/patch/18420/
> 
> thanks,
> Len Brown, Intel Open Source Technology Center
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: 2.6.30-rc3 video/i915 build error

[Len Brown]

On Fri, 24 Apr 2009, yakui_zhao wrote:

> On Fri, 2009-04-24 at 03:50 +0800, Len Brown wrote:
> 
> Hi, Len
>     The issue can be fixed by the patch from Matthew.
>     In Matthew's patch the acpi video is also selected when the i915 is
> compiled as builtin-kernel module.
>     But IMO this is not very good. From the Kconfig file we know that
> acpi video driver depends on the following configuration:
>     BACKLIGHT_CLASS_DEVICE && VIDEO_OUTPUT_CONTROL
> 
>     If the VIDEO_OUTPUT_CONTROL/BACKLIGHT_CLASS_DEVICE is not selected,
> then it will still fail in kernel compilation.

Matthew's patch is in.
Please send me an additional patch for the additionanl failure case.

thanks,
Len Brown, Intel Open Source Technology Center

Re: 2.6.30-rc3 video/i915 build error

[yakui_zhao]

On Fri, 2009-04-24 at 09:57 +0800, Len Brown wrote:

Hi, Len
    In my test if VIDEO_OUTPUT_CONTROL is not selected, there exists the
following failure:
    >drivers/built-in.o: In function `acpi_video_bus_put_devices':
    >video.c:(.text+0x41307): undefined reference to
`video_output_unregister'
    >drivers/built-in.o: In function `acpi_video_bus_add':
video.c:(.text+0x43024): undefined reference to `video_output_register'
    >make: *** [.tmp_vmlinux1] Error 1

    In order to fix this issue we must select the VIDEO_OUTPUT_CONTROL
when ACPI_VIDEO is selected. 
    I add the following content in drivers/gpu/drm/Kconfig
    >select ACPI_VIDEO if ACPI 
    >select VIDEO_OUTPUT_CONTROL if ACPI_VIDEO
    
    And then it will report that there exits recursive dependency:
ACPI_VIDEO -> VIDEO_OUTPUT_CONTROL -> ACPI_VIDEO

    In fact in current kernel there exists the following dependency:
    ACPI_VIDEO depends on VIDEO_OUTPUT_CONTROL.

    If we delete the ACPI_VIDEO configuration in drivers/acpi/Kconfig,
we can't select the acpi_video configuration when i915 is not used.

    So IMO it is not very good to change the dependency. After changing
the dependency between ACPI_VIDEO and I915, the new issue about
dependency is triggered. 

    Thanks.
> 
> thanks,
> Len Brown, Intel Open Source Technology Center
> 
> 
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: 2.6.30-rc3 video/i915 build error

[Len Brown]

From: Len Brown <len.brown@intel.com>
Subject: [PATCH] ACPI, i915: build fix

drivers/built-in.o: In function `intel_opregion_init':
(.text+0x9d540): undefined reference to `acpi_video_register'

Signed-off-by: Len Brown <len.brown@intel.com>
---
 drivers/gpu/drm/Kconfig |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
index 3a22eb9..f33d252 100644
--- a/drivers/gpu/drm/Kconfig
+++ b/drivers/gpu/drm/Kconfig
@@ -83,6 +83,12 @@ config DRM_I915
 config DRM_I915_KMS
 	bool "Enable modesetting on intel by default"
 	depends on DRM_I915
+	# i915 KMS depends on ACPI_VIDEO when ACPI is enabled
+	# but for select to work, need to select ACPI_VIDEO's dependencies, ick
+	select VIDEO_OUTPUT_CONTROL if ACPI
+	select BACKLIGHT_CLASS_DEVICE if ACPI
+	select INPUT if ACPI
+	select ACPI_VIDEO if ACPI
 	help
 	  Choose this option if you want kernel modesetting enabled by default,
 	  and you have a new enough userspace to support this. Running old
-- 
1.6.3.rc1.51.gea0b7

Re: 2.6.30-rc3 video/i915 build error

[yakui_zhao]

On Fri, 2009-04-24 at 23:49 +0800, Len Brown wrote:
> From: Len Brown <len.brown@intel.com>
> Subject: [PATCH] ACPI, i915: build fix
Hi, Len
    It seems that the issue still exists if KMS is not set in kernel
configuration.
    	
    Maybe this should depend on whether the I915 is selected.

thanks.
	
> 
> drivers/built-in.o: In function `intel_opregion_init':
> (.text+0x9d540): undefined reference to `acpi_video_register'
> 
> Signed-off-by: Len Brown <len.brown@intel.com>
> ---
>  drivers/gpu/drm/Kconfig |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
> index 3a22eb9..f33d252 100644
> --- a/drivers/gpu/drm/Kconfig
> +++ b/drivers/gpu/drm/Kconfig
> @@ -83,6 +83,12 @@ config DRM_I915
>  config DRM_I915_KMS
>  	bool "Enable modesetting on intel by default"
>  	depends on DRM_I915
> +	# i915 KMS depends on ACPI_VIDEO when ACPI is enabled
> +	# but for select to work, need to select ACPI_VIDEO's dependencies, ick
> +	select VIDEO_OUTPUT_CONTROL if ACPI
> +	select BACKLIGHT_CLASS_DEVICE if ACPI
> +	select INPUT if ACPI
> +	select ACPI_VIDEO if ACPI
>  	help
>  	  Choose this option if you want kernel modesetting enabled by default,
>  	  and you have a new enough userspace to support this. Running old

Re: 2.6.30-rc3 video/i915 build error

[Len Brown]

On Thu, 23 Apr 2009, Len Brown wrote:

> On Fri, 24 Apr 2009, yakui_zhao wrote:
> 
> > On Fri, 2009-04-24 at 03:50 +0800, Len Brown wrote:
> > 
> > Hi, Len
> >     The issue can be fixed by the patch from Matthew.
> >     In Matthew's patch the acpi video is also selected when the i915 is
> > compiled as builtin-kernel module.
> >     But IMO this is not very good. From the Kconfig file we know that
> > acpi video driver depends on the following configuration:
> >     BACKLIGHT_CLASS_DEVICE && VIDEO_OUTPUT_CONTROL
> > 
> >     If the VIDEO_OUTPUT_CONTROL/BACKLIGHT_CLASS_DEVICE is not selected,
> > then it will still fail in kernel compilation.
> 
> Matthew's patch is in.
> Please send me an additional patch for the additionanl failure case.

Yakui speaks the truth, all hail Yakui:-)

"ACPI/i915: build fix" is dropped, because it fixes

    drivers/built-in.o: In function `intel_opregion_init':
    (.text+0x9d540): undefined reference to `acpi_video_register'

but in defconfig, it causes:

drivers/built-in.o: In function `acpi_video_bus_put_devices':
video.c:(.text+0x411d2): undefined reference to `video_output_unregister'
drivers/built-in.o: In function `acpi_video_bus_add':
video.c:(.text+0x42c4e): undefined reference to `video_output_register'

Re: 2.6.30-rc3 video/i915 build error

[Norbert Preining]

On Do, 23 Apr 2009, Len Brown wrote:
> > > CONFIG_DRM_I915=y
> > > CONFIG_ACPI_VIDEO=m
> > > 
> > > drivers/built-in.o: In function `intel_opregion_init':
> > > (.text+0x9d540): undefined reference to `acpi_video_register'
> > 
> > For me these two patches fix the problem.
> 
> Matthew's response to those patches seems to be sufficient:
> 
> http://patchwork.kernel.org/patch/18420/

I have to disagree. 2.6.30-rc4, with that patch I get that in my config:
	CONFIG_DRM_I915=y
	# CONFIG_DRM_I915_KMS is not set
	CONFIG_ACPI_VIDEO=y
and it finishes with
  MODPOST vmlinux.o
drivers/built-in.o: In function `acpi_video_bus_put_devices': video.c:(.text+0x383a1): undefined reference to `backlight_device_unregister'
drivers/built-in.o: In function `acpi_video_bus_add': video.c:(.text+0x39c6a): undefined reference to `backlight_device_register'

So I tried to activate the backlight device to =y but calling make
config always ended with
	CONFIG_BACKLIGHT_CLASS_DEVICE=m

So still not working, which is bad. And the patches I mentioned before
do not apply anymore, so rc4 is out for testing for me.

Full .config on request.

Best wishes

Norbert

-------------------------------------------------------------------------------
Dr. Norbert Preining <preining@logic.at>        Vienna University of Technology
Debian Developer <preining@debian.org>                         Debian TeX Group
gpg DSA: 0x09C5B094      fp: 14DF 2E6C 0307 BE6D AD76  A9C0 D2BF 4AA3 09C5 B094
-------------------------------------------------------------------------------
HULL (adj.)
Descriptive of the smell of a weekend cottage.
			--- Douglas Adams, The Meaning of Liff

Re: 2.6.30-rc3 video/i915 build error

[Norbert Preining]

On Do, 30 Apr 2009, Norbert Preining wrote:
> So I tried to activate the backlight device to =y but calling make
> config always ended with
> 	CONFIG_BACKLIGHT_CLASS_DEVICE=m

Ok, I guess it needs a 
	select CONFIG_BACKLIGHT_LCD_SUPPORT
	select CONFIG_LCD_CLASS_DEVICE
	select CONFIG_BACKLIGHT_CLASS_DEVICE
or something similar.

Then it compiles.

Best wishes

Norbert

-------------------------------------------------------------------------------
Dr. Norbert Preining <preining@logic.at>        Vienna University of Technology
Debian Developer <preining@debian.org>                         Debian TeX Group
gpg DSA: 0x09C5B094      fp: 14DF 2E6C 0307 BE6D AD76  A9C0 D2BF 4AA3 09C5 B094
-------------------------------------------------------------------------------
SAFFRON WALDEN (n.)
To spray the person you are talking to with half-chewed breadcrumbs or
small pieces of whitebait.
			--- Douglas Adams, The Meaning of Liff