From: Len Brown <lenb@kernel.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Christian Hofstaedtler <ch@zeha.at>,
x86@kernel.org, Arjan van de Ven <arjan@infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
bruce.w.allan@intel.com, Thomas Gleixner <tglx@linutronix.de>,
Justin Piszcz <jpiszcz@lucidpixels.com>,
linux-acpi@vger.kernel.org,
Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>,
Andrey Borzenkov <arvidjaar@mail.ru>
Subject: Re: [PATCH] Add DMI quirk for Intel DP55KG mainboard
Date: Mon, 04 Jan 2010 17:03:34 -0500 (EST) [thread overview]
Message-ID: <alpine.LFD.2.00.1001041632330.4012@localhost.localdomain> (raw)
In-Reply-To: <4B4225B3.8070705@zytor.com>
> > I believe that Venki is sending a patch to make all recent
> > motherboards use acpi reset by default; and I'd rather
> > see that kind of patch than this one.
> >
> > I've had the patch below patch in acpi-test, and thus linus-next,
> > and -mm since Nov 2008 to change the default for
> > all systems w/ no issues.
> >
>
> Maybe I'm misremembering, but didn't we have to pull this patch after it
> hit mainstream the last time?
c7ffa6c26277b403920e2255d10df849bd613380
"x86: default to reboot via ACPI"
set ACPI as the default in 2.6.28-rc1
8d00450d296dedec9ada38d43b83e79cca6fd5a3
Revert "x86: default to reboot via ACPI"
pulled it in v2.6.28-rc4
The original patch was justified by VMX support,
and the revert was in response to Andrey Borzenkov's
DMI patch to usee BIOS reset on his Toshiba Porgege 4000:
http://lkml.org/lkml/2008/10/31/242
The Toshiba Portege 4000 shipped in early 2002.
The patch to restore ACPI reset to default has been in Linux-next
(with occasional drops) since the day it was dropped from 2.6.28-rc4.
As we have an existence proof, I have no doubt that using
ACPI reset by default will un-earth some regressions. However,
my guess is that the DMI list of old machines that will fail
with ACPI reset will be smaller than by the DMI list of
brand-new machines that will fail without ACPI reset.
We couuld use a DMI year cut-off as we do with
ACPI itself CONFIG_ACPI_BLACKLIST_YEAR, though that
doesn't work on systems that don't have DMI...
If I were to propose a year, I'd say 2006 and newer,
since XP was "Windows 2006".
thanks,
Len Brown, Intel Open Source Technology Center
next prev parent reply other threads:[~2010-01-04 22:03 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100104162114.GA30113@percival.namespace.at>
2010-01-04 17:15 ` [PATCH] Add DMI quirk for Intel DP55KG mainboard Len Brown
2010-01-04 17:30 ` H. Peter Anvin
2010-01-04 22:03 ` Len Brown [this message]
2010-01-05 2:15 ` Robert Hancock
2010-01-05 3:37 ` H. Peter Anvin
2010-01-05 12:30 ` [PATCH] Default to ACPI reboots on newish X86 hardware Christian Hofstaedtler
2010-01-05 17:04 ` H. Peter Anvin
2010-01-05 18:26 ` Christian Hofstaedtler
2010-01-06 6:06 ` H. Peter Anvin
2010-01-06 19:38 ` Len Brown
2010-01-07 20:03 ` Christian Hofstaedtler
2010-01-07 20:05 ` Christian Hofstaedtler
2010-01-07 23:05 ` H. Peter Anvin
2010-01-20 5:21 ` Len Brown
2010-01-21 17:18 ` [PATCH 1/2] x86: Unify reboot_type selection Christian Hofstaedtler
2010-01-21 17:18 ` [PATCH 2/2] Default to ACPI reboots on newish X86 hardware Christian Hofstaedtler
2010-01-23 19:57 ` Len Brown
2010-01-21 18:29 ` [PATCH 1/2] x86: Unify reboot_type selection H. Peter Anvin
2010-01-21 17:24 ` [PATCH] Default to ACPI reboots on newish X86 hardware Christian Hofstaedtler
2010-01-05 1:45 ` [PATCH] Add DMI quirk for Intel DP55KG mainboard Arjan van de Ven
2010-01-06 14:36 ` Matthew Garrett
2010-01-06 19:26 ` Len Brown
2010-01-06 19:36 ` Matthew Garrett
2010-01-06 20:22 ` Len Brown
2010-01-06 20:29 ` Matthew Garrett
2010-01-06 21:26 ` H. Peter Anvin
2010-01-20 5:06 ` Len Brown
2010-01-07 1:15 ` Robert Hancock
2010-01-06 7:41 ` Pavel Machek
2010-01-06 14:51 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1001041632330.4012@localhost.localdomain \
--to=lenb@kernel.org \
--cc=arjan@infradead.org \
--cc=arvidjaar@mail.ru \
--cc=bruce.w.allan@intel.com \
--cc=ch@zeha.at \
--cc=hpa@zytor.com \
--cc=jpiszcz@lucidpixels.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=venkatesh.pallipadi@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox