From: Len Brown <lenb@kernel.org>
To: Christian Hofstaedtler <ch@zeha.at>
Cc: x86@kernel.org, hpa@zytor.com, tglx@linutronix.de,
linux-acpi@vger.kernel.org, venkatesh.pallipadi@intel.com,
arjan@infradead.org, bruce.w.allan@intel.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] Default to ACPI reboots on newish X86 hardware
Date: Sat, 23 Jan 2010 14:57:28 -0500 (EST) [thread overview]
Message-ID: <alpine.LFD.2.00.1001231455440.5156@localhost.localdomain> (raw)
In-Reply-To: <1264094323-7187-2-git-send-email-ch@zeha.at>
Hi Christian,
I've replaced your previous patch in the acpi-test tree with this
refreshed pair.
Note that the 2nd patch had some checkpatch issues.
Perhaps you can run checkpatch before sending future patches.
WARNING: braces {} are not necessary for single statement blocks
#35: FILE: arch/x86/kernel/reboot.c:464:
+ if (!dmi_get_date(DMI_BIOS_DATE, &year, NULL, NULL)) {
+ return 1;
+ }
WARNING: braces {} are not necessary for single statement blocks
#38: FILE: arch/x86/kernel/reboot.c:467:
+ if (year == 0) {
+ return 1;
+ }
WARNING: braces {} are not necessary for single statement blocks
#43: FILE: arch/x86/kernel/reboot.c:472:
+ if (year < 2003) {
+ return 0;
+ }
ERROR: Missing Signed-off-by: line(s)
total: 1 errors, 3 warnings, 47 lines checked
thanks,
Len Brown, Intel Open Source Technology Center
next prev parent reply other threads:[~2010-01-23 19:57 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100104162114.GA30113@percival.namespace.at>
2010-01-04 17:15 ` [PATCH] Add DMI quirk for Intel DP55KG mainboard Len Brown
2010-01-04 17:30 ` H. Peter Anvin
2010-01-04 22:03 ` Len Brown
2010-01-05 2:15 ` Robert Hancock
2010-01-05 3:37 ` H. Peter Anvin
2010-01-05 12:30 ` [PATCH] Default to ACPI reboots on newish X86 hardware Christian Hofstaedtler
2010-01-05 17:04 ` H. Peter Anvin
2010-01-05 18:26 ` Christian Hofstaedtler
2010-01-06 6:06 ` H. Peter Anvin
2010-01-06 19:38 ` Len Brown
2010-01-07 20:03 ` Christian Hofstaedtler
2010-01-07 20:05 ` Christian Hofstaedtler
2010-01-07 23:05 ` H. Peter Anvin
2010-01-20 5:21 ` Len Brown
2010-01-21 17:18 ` [PATCH 1/2] x86: Unify reboot_type selection Christian Hofstaedtler
2010-01-21 17:18 ` [PATCH 2/2] Default to ACPI reboots on newish X86 hardware Christian Hofstaedtler
2010-01-23 19:57 ` Len Brown [this message]
2010-01-21 18:29 ` [PATCH 1/2] x86: Unify reboot_type selection H. Peter Anvin
2010-01-21 17:24 ` [PATCH] Default to ACPI reboots on newish X86 hardware Christian Hofstaedtler
2010-01-05 1:45 ` [PATCH] Add DMI quirk for Intel DP55KG mainboard Arjan van de Ven
2010-01-06 14:36 ` Matthew Garrett
2010-01-06 19:26 ` Len Brown
2010-01-06 19:36 ` Matthew Garrett
2010-01-06 20:22 ` Len Brown
2010-01-06 20:29 ` Matthew Garrett
2010-01-06 21:26 ` H. Peter Anvin
2010-01-20 5:06 ` Len Brown
2010-01-07 1:15 ` Robert Hancock
2010-01-06 7:41 ` Pavel Machek
2010-01-06 14:51 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1001231455440.5156@localhost.localdomain \
--to=lenb@kernel.org \
--cc=arjan@infradead.org \
--cc=bruce.w.allan@intel.com \
--cc=ch@zeha.at \
--cc=hpa@zytor.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=venkatesh.pallipadi@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox