Linux ACPI
 help / color / mirror / Atom feed
* [PATCH 2.6.32.stable] ACPI: don't cond_resched if irq is disabled
@ 2010-01-23 19:14 Len Brown
  0 siblings, 0 replies; only message in thread
From: Len Brown @ 2010-01-23 19:14 UTC (permalink / raw)
  To: stable
  Cc: Larry Finger, Justin P. Mattock, Xiaotian Feng,
	Alexey Starikovskiy, linux-acpi, Linux Kernel Mailing List

From: Xiaotian Feng <dfeng@redhat.com>

upstream c084ca704a3661bf77690a05bc6bd2c305d87c34

commit 8bd108d adds preemption point after each opcode parse, then
a sleeping function called from invalid context bug was founded
during suspend/resume stage. this was fixed in commit abe1dfa by
don't cond_resched when irq_disabled. But recent commit 138d156 changes
the behaviour to don't cond_resched when in_atomic. This makes the
sleeping function called from invalid context bug happen again, which
is reported in http://lkml.org/lkml/2009/12/1/371.

This patch also fixes http://bugzilla.kernel.org/show_bug.cgi?id=14483

Reported-and-bisected-by: Larry Finger <Larry.Finger@lwfinger.net>
Reported-and-bisected-by: Justin P. Mattock <justinmattock@gmail.com>
Signed-off-by: Xiaotian Feng <dfeng@redhat.com>
Acked-by: Alexey Starikovskiy <astarikovskiy@suse.de>
Signed-off-by: Len Brown <len.brown@intel.com>
---
 include/acpi/platform/aclinux.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/acpi/platform/aclinux.h b/include/acpi/platform/aclinux.h
index 9d7febd..0946997 100644
--- a/include/acpi/platform/aclinux.h
+++ b/include/acpi/platform/aclinux.h
@@ -152,7 +152,7 @@ static inline void *acpi_os_acquire_object(acpi_cache_t * cache)
 #include <linux/hardirq.h>
 #define ACPI_PREEMPTION_POINT() \
 	do { \
-		if (!in_atomic_preempt_off()) \
+		if (!in_atomic_preempt_off() && !irqs_disabled()) \
 			cond_resched(); \
 	} while (0)
 
-- 
1.6.6.1.383.g5a9f

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2010-01-23 19:14 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-23 19:14 [PATCH 2.6.32.stable] ACPI: don't cond_resched if irq is disabled Len Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox