public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Len Brown <lenb@kernel.org>
To: Philip Langdale <philipl@overt.org>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>,
	Jeff Garrett <jeff@jgarrett.org>,
	Andi Kleen <andi@firstfloor.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-acpi@vger.kernel.org, luming.yu@intel.com,
	venki@google.com
Subject: Re: acpi_idle: Very idle Core i7 machine never enters C3
Date: Tue, 25 May 2010 01:43:26 -0400 (EDT)	[thread overview]
Message-ID: <alpine.LFD.2.00.1005250125590.20648@localhost.localdomain> (raw)
In-Reply-To: <d7f2dd35a4361e5156079278543769a0@localhost>

> >> I am hopeful that the "right thing to do" is to not look at bm-status
> >> and that perhaps there is a bug where we are looking at it
> >> "by mistake".
> > 
> > https://patchwork.kernel.org/patch/58962/ - it seems to be a win.
> 
> Indeed. This patch does solve the C6 problem. I'm not in a position to
> speak about whether there's any undesirable I/O latency, but it
> passes the basic sanity check.
> 
> I have filed https://bugzilla.kernel.org/show_bug.cgi?id=15886 with
> my acpi dump - assuming that's still useful.

Luming's patch above basically deletes acpi_idle_bm_check() --
the BM_STS check -- from the C3 path on all Intel SMP boxes.
This is effectively the same as my test patch
https://patchwork.kernel.org/patch/77370/
that made acpi_idle_bm_check() do nothing.

I'm told by the hardware guys that BM_STS is _not_ always
a NOP, and so we're not supposed to simply ignore it on C3 --
though it should be extremely rare that we see it set.
If it is ever set, it should go on and off depending on 
activity on some latency sensitive device, like out on the LPC.
It may be possible for the BIOS writer to configure the chipset
so that BM_STS is enabled always, presumably to accomodate
some latency sensitve device -- or maybe by mistake.

(is it observed to be set always on your systems, or does
 it ever change its value?)

The logic in Luming's patch doesn't make sense to me.
bm_check and bm_control are related to C3 need to flush
the cache or ability to invoke ARB_DIS.  They are not
directly related to BM_STS -- which is a bit that tells
us if there has recently been bus master activity of
a type that would break us out of C3.

-Len Brown, Intel Open Source Technology Center


  reply	other threads:[~2010-05-25  5:43 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-26  8:47 acpi_idle: Very idle Core i7 machine never enters C3 Jeff Garrett
2010-01-26 12:41 ` peng huang
2010-01-26 14:59   ` Jeff Garrett
2010-01-27 13:27     ` peng huang
2010-02-05 16:22       ` Jeff Garrett
2010-01-26 21:45 ` Andi Kleen
2010-02-05 16:09   ` Jeff Garrett
2010-02-05 17:45     ` Len Brown
2010-02-05 20:53       ` Jeff Garrett
2010-04-27  2:40       ` Philip Langdale
2010-04-27  7:26         ` Len Brown
2010-04-27 15:41           ` Philip Langdale
2010-04-27 12:47         ` Jeff Garrett
2010-04-30 14:57           ` Philip Langdale
2010-04-30 16:25           ` Len Brown
2010-04-30 17:44             ` Matthew Garrett
2010-04-30 18:35               ` Philip Langdale
2010-05-25  5:43                 ` Len Brown [this message]
2010-05-25  5:59                   ` Yu, Luming
2010-05-25 12:39                     ` Matthew Garrett
2010-05-25 12:43                     ` Matthew Garrett
2010-05-25 15:33                       ` Len Brown
2010-05-25 18:55                         ` Matthew Garrett
2010-07-21 21:31                           ` [PATCH] ACPI: make acpi_idle Nehalem-aware Len Brown
2010-07-22  0:53                             ` Venkatesh Pallipadi
2010-07-22  7:47                             ` Andi Kleen
2010-07-22 15:57                               ` Len Brown
2010-07-22 21:21                                 ` [PATCH] ACPI: skip checking BM_STS if the BIOS doesn't ask for it Len Brown
2010-07-22 21:40                                   ` [PATCH] ACPI: create "processor.bm_check_disable" boot param Len Brown
2010-07-26  7:24                                     ` Andi Kleen
2010-07-27  0:19                                       ` Len Brown
2010-07-27 11:28                                         ` Andi Kleen
2010-07-28 18:58                                           ` Len Brown
2010-07-22 21:25                                 ` [PATCH] ACPI: make acpi_idle Nehalem-aware Iain
2010-07-22 21:53                                   ` Iain
2010-07-22 22:01                                   ` Len Brown
2010-07-23 12:40                                     ` Iain
2010-08-03  6:55                             ` Pavel Machek
2010-08-03  7:05                               ` Andi Kleen
2010-05-25 12:37                   ` acpi_idle: Very idle Core i7 machine never enters C3 Matthew Garrett
2010-05-25 15:40                     ` Len Brown
2010-07-22  5:34           ` Len Brown
2010-02-01 14:10 ` Pavel Machek
2010-02-05 16:30   ` Jeff Garrett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.1005250125590.20648@localhost.localdomain \
    --to=lenb@kernel.org \
    --cc=andi@firstfloor.org \
    --cc=jeff@jgarrett.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luming.yu@intel.com \
    --cc=mjg59@srcf.ucam.org \
    --cc=philipl@overt.org \
    --cc=venki@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox