public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Len Brown <lenb@kernel.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>,
	"Yu, Luming" <luming.yu@intel.com>,
	Philip Langdale <philipl@overt.org>,
	Jeff Garrett <jeff@jgarrett.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
	"venki@google.com" <venki@google.com>
Subject: [PATCH] ACPI: create "processor.bm_check_disable" boot param
Date: Thu, 22 Jul 2010 17:40:02 -0400 (EDT)	[thread overview]
Message-ID: <alpine.LFD.2.00.1007221739260.7970@localhost.localdomain> (raw)
In-Reply-To: <alpine.LFD.2.00.1007221720270.7970@localhost.localdomain>

From: Len Brown <len.brown@intel.com>

processor.bm_check_disable=1" prevents Linux from checking BM_STS
before entering C3-type cpu power states.

This may be useful for a system running acpi_idle
where the BIOS exports FADT C-states, _CST IO C-states,
or _CST FFH C-states with the BM_STS bit set;
while configuring the chipset to set BM_STS
more frequently than perhaps is optimal.

Note that such systems may have been developed
using a tickful OS that would quickly clear BM_STS,
rather than a tickless OS that may go for some time
between checking and clearing BM_STS.

Note also that an alternative for newer systems
is to use the intel_idle driver, which always
ignores BM_STS, relying Linux device drivers
to register constraints explicitly via PM_QOS.

https://bugzilla.kernel.org/show_bug.cgi?id=15886

Signed-off-by: Len Brown <len.brown@intel.com>
---
 drivers/acpi/processor_idle.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
index b351342..1d41048 100644
--- a/drivers/acpi/processor_idle.c
+++ b/drivers/acpi/processor_idle.c
@@ -76,6 +76,8 @@ static unsigned int max_cstate __read_mostly = ACPI_PROCESSOR_MAX_POWER;
 module_param(max_cstate, uint, 0000);
 static unsigned int nocst __read_mostly;
 module_param(nocst, uint, 0000);
+static int bm_check_disable __read_mostly;
+module_param(bm_check_disable, uint, 0000);
 
 static unsigned int latency_factor __read_mostly = 2;
 module_param(latency_factor, uint, 0644);
@@ -763,6 +765,9 @@ static int acpi_idle_bm_check(void)
 {
 	u32 bm_status = 0;
 
+	if (bm_check_disable)
+		return 0;
+
 	acpi_read_bit_register(ACPI_BITREG_BUS_MASTER_STATUS, &bm_status);
 	if (bm_status)
 		acpi_write_bit_register(ACPI_BITREG_BUS_MASTER_STATUS, 1);
-- 
1.7.2



  reply	other threads:[~2010-07-22 21:40 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-26  8:47 acpi_idle: Very idle Core i7 machine never enters C3 Jeff Garrett
2010-01-26 12:41 ` peng huang
2010-01-26 14:59   ` Jeff Garrett
2010-01-27 13:27     ` peng huang
2010-02-05 16:22       ` Jeff Garrett
2010-01-26 21:45 ` Andi Kleen
2010-02-05 16:09   ` Jeff Garrett
2010-02-05 17:45     ` Len Brown
2010-02-05 20:53       ` Jeff Garrett
2010-04-27  2:40       ` Philip Langdale
2010-04-27  7:26         ` Len Brown
2010-04-27 15:41           ` Philip Langdale
2010-04-27 12:47         ` Jeff Garrett
2010-04-30 14:57           ` Philip Langdale
2010-04-30 16:25           ` Len Brown
2010-04-30 17:44             ` Matthew Garrett
2010-04-30 18:35               ` Philip Langdale
2010-05-25  5:43                 ` Len Brown
2010-05-25  5:59                   ` Yu, Luming
2010-05-25 12:39                     ` Matthew Garrett
2010-05-25 12:43                     ` Matthew Garrett
2010-05-25 15:33                       ` Len Brown
2010-05-25 18:55                         ` Matthew Garrett
2010-07-21 21:31                           ` [PATCH] ACPI: make acpi_idle Nehalem-aware Len Brown
2010-07-22  0:53                             ` Venkatesh Pallipadi
2010-07-22  7:47                             ` Andi Kleen
2010-07-22 15:57                               ` Len Brown
2010-07-22 21:21                                 ` [PATCH] ACPI: skip checking BM_STS if the BIOS doesn't ask for it Len Brown
2010-07-22 21:40                                   ` Len Brown [this message]
2010-07-26  7:24                                     ` [PATCH] ACPI: create "processor.bm_check_disable" boot param Andi Kleen
2010-07-27  0:19                                       ` Len Brown
2010-07-27 11:28                                         ` Andi Kleen
2010-07-28 18:58                                           ` Len Brown
2010-07-22 21:25                                 ` [PATCH] ACPI: make acpi_idle Nehalem-aware Iain
2010-07-22 21:53                                   ` Iain
2010-07-22 22:01                                   ` Len Brown
2010-07-23 12:40                                     ` Iain
2010-08-03  6:55                             ` Pavel Machek
2010-08-03  7:05                               ` Andi Kleen
2010-05-25 12:37                   ` acpi_idle: Very idle Core i7 machine never enters C3 Matthew Garrett
2010-05-25 15:40                     ` Len Brown
2010-07-22  5:34           ` Len Brown
2010-02-01 14:10 ` Pavel Machek
2010-02-05 16:30   ` Jeff Garrett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.1007221739260.7970@localhost.localdomain \
    --to=lenb@kernel.org \
    --cc=andi@firstfloor.org \
    --cc=jeff@jgarrett.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luming.yu@intel.com \
    --cc=mjg59@srcf.ucam.org \
    --cc=philipl@overt.org \
    --cc=venki@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox