* [PATCH] ACPI: Disable Vista compatibility for Sony VGN-NS50B_L
@ 2010-06-08 7:28 Zhang Rui
2010-06-08 12:46 ` Matthew Garrett
2010-06-09 21:55 ` Len Brown
0 siblings, 2 replies; 6+ messages in thread
From: Zhang Rui @ 2010-06-08 7:28 UTC (permalink / raw)
To: Brown, Len; +Cc: linux-acpi@vger.kernel.org, Zhang, Rui, harestomper
Disable Vista compatibility for Sony VGN-NS50B_L.
https://bugzilla.kernel.org/show_bug.cgi?id=12904#c46
Tested-by: Voldemar <harestomper@gmail.com>
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
---
drivers/acpi/blacklist.c | 8 ++++++++
1 file changed, 8 insertions(+)
Index: linux-2.6/drivers/acpi/blacklist.c
===================================================================
--- linux-2.6.orig/drivers/acpi/blacklist.c
+++ linux-2.6/drivers/acpi/blacklist.c
@@ -218,6 +218,14 @@ static struct dmi_system_id acpi_osi_dmi
},
},
{
+ .callback = dmi_disable_osi_vista,
+ .ident = "VGN-NS50B_L",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Sony Corporation"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "VGN-NS50B_L"),
+ },
+ },
+ {
.callback = dmi_disable_osi_win7,
.ident = "ASUS K50IJ",
.matches = {
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ACPI: Disable Vista compatibility for Sony VGN-NS50B_L
2010-06-08 7:28 [PATCH] ACPI: Disable Vista compatibility for Sony VGN-NS50B_L Zhang Rui
@ 2010-06-08 12:46 ` Matthew Garrett
2010-06-09 21:55 ` Len Brown
1 sibling, 0 replies; 6+ messages in thread
From: Matthew Garrett @ 2010-06-08 12:46 UTC (permalink / raw)
To: Zhang Rui; +Cc: Brown, Len, linux-acpi@vger.kernel.org, harestomper
On Tue, Jun 08, 2010 at 03:28:40PM +0800, Zhang Rui wrote:
>
> Disable Vista compatibility for Sony VGN-NS50B_L.
> https://bugzilla.kernel.org/show_bug.cgi?id=12904#c46
Given that these machines *shipped* with Vista, this is a workaround
rather than a fix. I've no real problem with it being applied as a
temporary measure, but the bug shouldn't be closed.
--
Matthew Garrett | mjg59@srcf.ucam.org
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ACPI: Disable Vista compatibility for Sony VGN-NS50B_L
2010-06-08 7:28 [PATCH] ACPI: Disable Vista compatibility for Sony VGN-NS50B_L Zhang Rui
2010-06-08 12:46 ` Matthew Garrett
@ 2010-06-09 21:55 ` Len Brown
2010-06-09 22:28 ` Matthew Garrett
1 sibling, 1 reply; 6+ messages in thread
From: Len Brown @ 2010-06-09 21:55 UTC (permalink / raw)
To: Zhang Rui; +Cc: linux-acpi@vger.kernel.org, harestomper
applied
thanks,
Len Brown, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ACPI: Disable Vista compatibility for Sony VGN-NS50B_L
2010-06-09 21:55 ` Len Brown
@ 2010-06-09 22:28 ` Matthew Garrett
2010-06-10 1:07 ` Zhang Rui
0 siblings, 1 reply; 6+ messages in thread
From: Matthew Garrett @ 2010-06-09 22:28 UTC (permalink / raw)
To: Len Brown; +Cc: Zhang Rui, linux-acpi@vger.kernel.org, harestomper
On Wed, Jun 09, 2010 at 05:55:22PM -0400, Len Brown wrote:
> applied
Len, as mentioned, there's absolutely no way that this can be the
correct fix. Could you make note of that in the commit?
--
Matthew Garrett | mjg59@srcf.ucam.org
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ACPI: Disable Vista compatibility for Sony VGN-NS50B_L
2010-06-09 22:28 ` Matthew Garrett
@ 2010-06-10 1:07 ` Zhang Rui
2010-06-10 15:30 ` Len Brown
0 siblings, 1 reply; 6+ messages in thread
From: Zhang Rui @ 2010-06-10 1:07 UTC (permalink / raw)
To: Matthew Garrett
Cc: Len Brown, linux-acpi@vger.kernel.org, harestomper@gmail.com
On Thu, 2010-06-10 at 06:28 +0800, Matthew Garrett wrote:
> On Wed, Jun 09, 2010 at 05:55:22PM -0400, Len Brown wrote:
> > applied
>
> Len, as mentioned, there's absolutely no way that this can be the
> correct fix. Could you make note of that in the commit?
>
agree.
thanks,
rui
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ACPI: Disable Vista compatibility for Sony VGN-NS50B_L
2010-06-10 1:07 ` Zhang Rui
@ 2010-06-10 15:30 ` Len Brown
0 siblings, 0 replies; 6+ messages in thread
From: Len Brown @ 2010-06-10 15:30 UTC (permalink / raw)
To: Zhang Rui
Cc: Matthew Garrett, linux-acpi@vger.kernel.org,
harestomper@gmail.com
On Thu, 10 Jun 2010, Zhang Rui wrote:
> On Thu, 2010-06-10 at 06:28 +0800, Matthew Garrett wrote:
> > On Wed, Jun 09, 2010 at 05:55:22PM -0400, Len Brown wrote:
> > > applied
> >
> > Len, as mentioned, there's absolutely no way that this can be the
> > correct fix. Could you make note of that in the commit?
> >
> agree.
I put it on a branch called bugzilla-102904-workaround,
but I'll add a note that it is just a workaround to the commit message.
Of course we claim that we are compatible with the latest windows
but frankly, discovering what compatible means is an ongoing process...
thanks,
Len Brown, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-06-10 15:31 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-08 7:28 [PATCH] ACPI: Disable Vista compatibility for Sony VGN-NS50B_L Zhang Rui
2010-06-08 12:46 ` Matthew Garrett
2010-06-09 21:55 ` Len Brown
2010-06-09 22:28 ` Matthew Garrett
2010-06-10 1:07 ` Zhang Rui
2010-06-10 15:30 ` Len Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox